<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
+ some display folks.<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Julien Isorce <julien.isorce@gmail.com><br>
<b>Sent:</b> Tuesday, October 8, 2019 12:06 PM<br>
<b>To:</b> amd-gfx list <amd-gfx@lists.freedesktop.org><br>
<b>Subject:</b> Re: [PATCH] drm/amd/display: Use pixel encoding 444 for dongle usb-c to hdmi</font>
<div> </div>
</div>
<div>
<div dir="ltr">
<div>Hi,</div>
<div><br>
</div>
<div>Gentle ping ?</div>
<div><br>
</div>
<div>Thx</div>
<div>Julien</div>
<br>
<div class="x_gmail_quote">
<div dir="ltr" class="x_gmail_attr">On Tue, Oct 1, 2019 at 3:21 PM Julien Isorce <<a href="mailto:julien.isorce@gmail.com">julien.isorce@gmail.com</a>> wrote:<br>
</div>
<blockquote class="x_gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
Fix pinkish color issue around grey areas. This also happens<br>
when not using any dongle so directly with a usb-c to Display<br>
Port cable. Meaning there is something wrong when using pixel<br>
encoding RGB with amd driver in the general case. In the meantime<br>
just use the same pixel encoding as when using HDMI without dongle.<br>
This way users will see the same thing on 2 identical screens when<br>
one is connected with hdmi-to-hdmi and the other is connected with<br>
usb-c-to-hdmi.<br>
<br>
Signed-off-by: Julien Isorce <<a href="mailto:jisorce@oblong.com" target="_blank">jisorce@oblong.com</a>><br>
---<br>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +++++<br>
1 file changed, 5 insertions(+)<br>
<br>
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c<br>
index d3f404f097eb..8139dcc0bfba 100644<br>
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c<br>
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c<br>
@@ -3313,6 +3313,7 @@ static void fill_stream_properties_from_drm_display_mode(<br>
{<br>
struct dc_crtc_timing *timing_out = &stream->timing;<br>
const struct drm_display_info *info = &connector->display_info;<br>
+ const struct dc_link *link = stream->sink->link;<br>
<br>
memset(timing_out, 0, sizeof(struct dc_crtc_timing));<br>
<br>
@@ -3327,6 +3328,10 @@ static void fill_stream_properties_from_drm_display_mode(<br>
else if ((connector->display_info.color_formats & DRM_COLOR_FORMAT_YCRCB444)<br>
&& stream->signal == SIGNAL_TYPE_HDMI_TYPE_A)<br>
timing_out->pixel_encoding = PIXEL_ENCODING_YCBCR444;<br>
+ else if ((connector->display_info.color_formats & DRM_COLOR_FORMAT_YCRCB444)<br>
+ && stream->sink->sink_signal == SIGNAL_TYPE_DISPLAY_PORT<br>
+ && link->dpcd_caps.dongle_type == DISPLAY_DONGLE_DP_HDMI_CONVERTER)<br>
+ timing_out->pixel_encoding = PIXEL_ENCODING_YCBCR444;<br>
else<br>
timing_out->pixel_encoding = PIXEL_ENCODING_RGB;<br>
<br>
-- <br>
2.17.1<br>
<br>
</blockquote>
</div>
</div>
</div>
</body>
</html>