<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=Windows-1252"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Reviewed-by: Kevin Wang <kevin1.wang@amd.com></div> <div id="appendonsend"></div> <div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)"> <br> </div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Feng, Kenneth <Kenneth.Feng@amd.com><br> <b>Sent:</b> Thursday, October 10, 2019 3:00 PM<br> <b>To:</b> Yuan, Xiaojie <Xiaojie.Yuan@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br> <b>Cc:</b> Xiao, Jack <Jack.Xiao@amd.com>; Wang, Kevin(Yang) <Kevin1.Wang@amd.com>; Zhang, Hawking <Hawking.Zhang@amd.com>; Quan, Evan <Evan.Quan@amd.com><br> <b>Subject:</b> RE: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit</font> <div> </div> </div> <div lang="EN-US"> <div class="x_WordSection1"> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D">Hi Alex,</span></p> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D">This issue was navi10 specific and was found in May, 2019.</span></p> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D">It was early after the asic back, then since gfxoff was removed from navi10, we didn’t really verify which firmware version started to have a fix.</span></p> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D">For navi14/navi12, there’s no such issue at all.</span></p> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D">Sorry for losing the track of it.</span></p> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D"> </span></p> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D"> </span></p> <div> <div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0in 0in 0in"> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <b><span style="font-size:11.0pt; font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt; font-family:"Calibri",sans-serif"> Yuan, Xiaojie <br> <b>Sent:</b> Thursday, October 10, 2019 1:17 AM<br> <b>To:</b> Deucher, Alexander <Alexander.Deucher@amd.com>; amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> Xiao, Jack <Jack.Xiao@amd.com>; Wang, Kevin(Yang) <Kevin1.Wang@amd.com>; Zhang, Hawking <Hawking.Zhang@amd.com>; Quan, Evan <Evan.Quan@amd.com>; Feng, Kenneth <Kenneth.Feng@amd.com><br> <b>Subject:</b> Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit</span></p> </div> </div> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> </p> <div> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black">Hi Alex,</span></p> </div> <div> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black"> </span></p> </div> <div> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black">For now, gfxoff for navi10 is disabled by default, and I also verified on navi14 with both GFXOFF and FW_DSTATE feature bits toggled on.</span></p> </div> <div> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black"> </span></p> </div> <div> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black">Hi Kenneth / Jack,</span></p> </div> <div> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black"> </span></p> </div> <div> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black">Could you help to confirm the firmware version?</span></p> </div> <div> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black"> </span></p> </div> <div> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black">BR,</span></p> </div> <div> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black">Xiaojie</span></p> </div> <div class="x_MsoNormal" align="center" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="x_divRplyFwdMsg"> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <b><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black">From:</span></b><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black"> Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>><br> <b>Sent:</b> Wednesday, October 9, 2019 9:35 PM<br> <b>To:</b> Yuan, Xiaojie <<a href="mailto:Xiaojie.Yuan@amd.com">Xiaojie.Yuan@amd.com</a>>; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>><br> <b>Cc:</b> Xiao, Jack <<a href="mailto:Jack.Xiao@amd.com">Jack.Xiao@amd.com</a>>; Wang, Kevin(Yang) <<a href="mailto:Kevin1.Wang@amd.com">Kevin1.Wang@amd.com</a>>; Zhang, Hawking <<a href="mailto:Hawking.Zhang@amd.com">Hawking.Zhang@amd.com</a>>; Quan, Evan <<a href="mailto:Evan.Quan@amd.com">Evan.Quan@amd.com</a>>; Feng, Kenneth <<a href="mailto:Kenneth.Feng@amd.com">Kenneth.Feng@amd.com</a>><br> <b>Subject:</b> Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit</span> </p> <div> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> </p> </div> </div> <div> <div> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-family:"Calibri",sans-serif; color:black">What version of firmware has the fix? Was it recently fixed? We should check the version if the old one may be out in the wild.</span></p> </div> <div> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-family:"Calibri",sans-serif; color:black"> </span></p> </div> <div> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-family:"Calibri",sans-serif; color:black">Alex</span></p> </div> <div class="x_MsoNormal" align="center" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="x_x_divRplyFwdMsg"> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <b><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black">From:</span></b><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black"> amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of Yuan, Xiaojie <<a href="mailto:Xiaojie.Yuan@amd.com">Xiaojie.Yuan@amd.com</a>><br> <b>Sent:</b> Wednesday, October 9, 2019 7:08 AM<br> <b>To:</b> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>><br> <b>Cc:</b> Xiao, Jack <<a href="mailto:Jack.Xiao@amd.com">Jack.Xiao@amd.com</a>>; Wang, Kevin(Yang) <<a href="mailto:Kevin1.Wang@amd.com">Kevin1.Wang@amd.com</a>>; Zhang, Hawking <<a href="mailto:Hawking.Zhang@amd.com">Hawking.Zhang@amd.com</a>>; Quan, Evan <<a href="mailto:Evan.Quan@amd.com">Evan.Quan@amd.com</a>>; Feng, Kenneth <<a href="mailto:Kenneth.Feng@amd.com">Kenneth.Feng@amd.com</a>>; Yuan, Xiaojie <<a href="mailto:Xiaojie.Yuan@amd.com">Xiaojie.Yuan@amd.com</a>><br> <b>Subject:</b> [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit</span> </p> <div> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> </p> </div> </div> <div> <div> <p class="x_MsoNormal" style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt">SMU firmware has fix the bug, so remove this workaround.<br> <br> Signed-off-by: Xiaojie Yuan <<a href="mailto:xiaojie.yuan@amd.com">xiaojie.yuan@amd.com</a>><br> ---<br> drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 5 +----<br> 1 file changed, 1 insertion(+), 4 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c<br> index 44152c1f01c7..3628295469c4 100644<br> --- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c<br> +++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c<br> @@ -359,11 +359,8 @@ navi10_get_allowed_feature_mask(struct smu_context *smu,<br> | FEATURE_MASK(FEATURE_MEM_VDDCI_SCALING_BIT)<br> | FEATURE_MASK(FEATURE_MEM_MVDD_SCALING_BIT);<br> <br> - if (adev->pm.pp_feature & PP_GFXOFF_MASK) {<br> + if (adev->pm.pp_feature & PP_GFXOFF_MASK)<br> *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_GFXOFF_BIT);<br> - /* TODO: remove it once fw fix the bug */<br> - *(uint64_t *)feature_mask &= ~FEATURE_MASK(FEATURE_FW_DSTATE_BIT);<br> - }<br> <br> if (smu->adev->pg_flags & AMD_PG_SUPPORT_MMHUB)<br> *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_MMHUB_PG_BIT);<br> -- <br> 2.20.1<br> <br> _______________________________________________<br> amd-gfx mailing list<br> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></span></p> </div> </div> </div> </div> </div> </body> </html>