<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks Luben!</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Patch 8 v2 has sent out, please review again.<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Tuikov, Luben <Luben.Tuikov@amd.com><br>
<b>Sent:</b> Wednesday, October 16, 2019 2:01<br>
<b>To:</b> Yin, Tianci (Rico) <Tianci.Yin@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com><br>
<b>Subject:</b> Re: [PATCH 1/8] drm/amdgpu: update amdgpu_discovery to handle revision</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Patches 1-7: Looks good.<br>
Reviewed-by: Luben Tuikov <luben.tuikov@amd.com><br>
<br>
Patch 8: NAK! for the same exact reason as the previous review. No changes to NAK reasoning from previous review.<br>
<br>
Regards,<br>
Luben<br>
<br>
On 2019-10-13 11:21 p.m., Tianci Yin wrote:<br>
> From: "Tianci.Yin" <tianci.yin@amd.com><br>
> <br>
> update amdgpu_discovery to get IP revision.<br>
> <br>
> Change-Id: If8152103d03b58e1dc0f32db63625e290f5f08a0<br>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com><br>
> Signed-off-by: Tianci.Yin <tianci.yin@amd.com><br>
> ---<br>
> drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 4 +++-<br>
> drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h | 2 +-<br>
> 2 files changed, 4 insertions(+), 2 deletions(-)<br>
> <br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c<br>
> index 71198c5318e1..ddd8364102a2 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c<br>
> @@ -333,7 +333,7 @@ int amdgpu_discovery_reg_base_init(struct amdgpu_device *adev)<br>
> }<br>
> <br>
> int amdgpu_discovery_get_ip_version(struct amdgpu_device *adev, int hw_id,<br>
> - int *major, int *minor)<br>
> + int *major, int *minor, int *revision)<br>
> {<br>
> struct binary_header *bhdr;<br>
> struct ip_discovery_header *ihdr;<br>
> @@ -369,6 +369,8 @@ int amdgpu_discovery_get_ip_version(struct amdgpu_device *adev, int hw_id,<br>
> *major = ip->major;<br>
> if (minor)<br>
> *minor = ip->minor;<br>
> + if (revision)<br>
> + *revision = ip->revision;<br>
> return 0;<br>
> }<br>
> ip_offset += sizeof(*ip) + 4 * (ip->num_base_address - 1);<br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h<br>
> index 5a6693d7d269..ba78e15d9b05 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h<br>
> @@ -30,7 +30,7 @@ int amdgpu_discovery_init(struct amdgpu_device *adev);<br>
> void amdgpu_discovery_fini(struct amdgpu_device *adev);<br>
> int amdgpu_discovery_reg_base_init(struct amdgpu_device *adev);<br>
> int amdgpu_discovery_get_ip_version(struct amdgpu_device *adev, int hw_id,<br>
> - int *major, int *minor);<br>
> + int *major, int *minor, int *revision);<br>
> int amdgpu_discovery_get_gfx_info(struct amdgpu_device *adev);<br>
> <br>
> #endif /* __AMDGPU_DISCOVERY__ */<br>
> <br>
<br>
</div>
</span></font></div>
</body>
</html>