<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> </head> <body> <div dir="ltr" text-align="left"> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255); text-align: left;" dir="ltr"> This is actually setting DIG mode a second time, right? I don't think this is what sets GC_SEND.</div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255); text-align: left;" dir="ltr"> <br> </div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255); text-align: left;" dir="ltr"> Please mention that this is setting the DIG_MODE to the correct value after having been overridden by the call to transmitter control in your patch description. Also correct the HACK comment to mention that this second call is needed to reconfigure the DIG as a workaround for the incorrect value being applied from transmitter control. Specifics help in source.</div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255); text-align: left;" dir="ltr"> <br> </div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255); text-align: left;" dir="ltr"> I don't think there is a case where we'd want HDMI changed to DVI so it's probably fine to leave this as is for now...</div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255); text-align: left;" dir="ltr"> <br> </div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255); text-align: left;" dir="ltr"> With those fixed, you can add my:</div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255); text-align: left;" dir="ltr"> <br> </div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255); text-align: left;" dir="ltr"> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com></div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255); text-align: left;" dir="ltr"> <br> </div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255); text-align: left;" dir="ltr"> Thanks,</div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255); text-align: left;" dir="ltr"> <br> </div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255); text-align: left;" dir="ltr"> Nicholas Kazlauskas</div> <div id="id-77342fb2-e4ed-464c-97e1-4a1a620e36e9" class="ms-outlook-mobile-reference-message"> <div style="font-family: sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"><br> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg"><strong>From:</strong> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Liu, Zhan <Zhan.Liu@amd.com><br> <strong>Sent:</strong> Thursday, October 17, 2019, 3:04 PM<br> <strong>To:</strong> amd-gfx@lists.freedesktop.org; Liu, Zhan<br> <strong>Subject:</strong> [PATCH v2] drm/amd/display: Modify display link stream setup sequence.<br> </div> <br> <meta name="Generator" content="Microsoft Exchange Server"> <style></style><font size="2"><span style="font-size:11pt;"> <div class="PlainText">[Why]<br> This patch is for fixing Navi14 pink screen issue. With this<br> patch, stream->link->link_enc->funcs->setup will be called<br> twice: this will make sure GC_SEND is set to 1. Though we<br> still need to look into why the issue only happens on<br> Linux, but not on Windows side.<br> <br> [How]<br> Call stream->link->link_enc->funcs->setup twice.<br> <br> Signed-off-by: Zhan liu <zhan.liu@amd.com><br> ---<br> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 ++++++<br> 1 file changed, 6 insertions(+)<br> <br> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c<br> index 935053664160..8683e8613ec2 100644<br> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c<br> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c<br> @@ -2842,6 +2842,12 @@ void core_link_enable_stream(<br> CONTROLLER_DP_TEST_PATTERN_VIDEOMODE,<br> COLOR_DEPTH_UNDEFINED);<br> <br> + /* Hack on Navi14: fixes Navi14 HDMI pink screen issue */<br> + if (!dc_is_virtual_signal(pipe_ctx->stream->signal))<br> + stream->link->link_enc->funcs->setup(<br> + stream->link->link_enc,<br> + pipe_ctx->stream->signal);<br> +<br> #ifdef CONFIG_DRM_AMD_DC_DSC_SUPPORT<br> if (pipe_ctx->stream->timing.flags.DSC) {<br> if (dc_is_dp_signal(pipe_ctx->stream->signal) ||<br> --<br> 2.17.0<br> _______________________________________________<br> amd-gfx mailing list<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br> amd-gfx@lists.freedesktop.org<br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></div> </span></font><br> </div> </div> </body> </html>