<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Hi Saurav,</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> the driver already has the same fix patch,</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> you can pull the latest driver tree and check it again,</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> thanks.</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <span style="font-family: "Courier New", monospace;"><i>From 2032324682c1ca563e33c56e51d9ae17a2b38105 Mon Sep 17 00:00:00 2001</i></span><span><i><br> </i></span> <div><span style="font-family: "Courier New", monospace;"><i>From: zhong jiang <zhongjiang@huawei.com></i></span><i><br> </i></div> <div><span style="font-family: "Courier New", monospace;"><i>Date: Tue, 3 Sep 2019 14:15:05 +0800</i></span><i><br> </i></div> <div><span style="font-family: "Courier New", monospace;"><i>Subject: [PATCH] drm/amdgpu: remove the redundant null checks</i></span><i><br> </i></div> <div><i><br> </i></div> <div><span style="font-family: "Courier New", monospace;"><i>debugfs_remove and kfree has taken the null check in account.</i></span><i><br> </i></div> <div><span style="font-family: "Courier New", monospace;"><i>hence it is unnecessary to check it. Just remove the condition.</i></span><i><br> </i></div> <div><span style="font-family: "Courier New", monospace;"><i>No functional change.</i></span><i><br> </i></div> <div><i><br> </i></div> <div><span style="font-family: "Courier New", monospace;"><i>This issue was detected by using the Coccinelle software.</i></span><i><br> </i></div> <div><i><br> </i></div> <div><span style="font-family: "Courier New", monospace;"><i>Signed-off-by: zhong jiang <zhongjiang@huawei.com></i></span><i><br> </i></div> <i><span style="font-family: "Courier New", monospace;">Signed-off-by: Alex Deucher <alexander.deucher@amd.com></span><br> </i></div> <i><span></span></i> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <span style="color: rgb(0, 0, 0); font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;">Best Regards,</span><br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Kevin</div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Saurav Girepunje <saurav.girepunje@gmail.com><br> <b>Sent:</b> Tuesday, October 29, 2019 5:19 PM<br> <b>To:</b> Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Zhou, David(ChunMing) <David1.Zhou@amd.com>; airlied@linux.ie <airlied@linux.ie>; daniel@ffwll.ch <daniel@ffwll.ch>; StDenis, Tom <Tom.StDenis@amd.com>; xywang.sjtu@sjtu.edu.cn <xywang.sjtu@sjtu.edu.cn>; Xiao, Jack <Jack.Xiao@amd.com>; sam@ravnborg.org <sam@ravnborg.org>; Wang, Kevin(Yang) <Kevin1.Wang@amd.com>; saurav.girepunje@gmail.com <saurav.girepunje@gmail.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org><br> <b>Cc:</b> saurav.girepunje@hotmail.com <saurav.girepunje@hotmail.com><br> <b>Subject:</b> [PATCH] drm: amd: amdgpu: Remove NULL check not needed before freeing functions</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt"> <div class="PlainText">Remove unneeded NULL check before freeing functions<br> kfree and debugfs_remove.<br> <br> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com><br> ---<br> drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 6 ++----<br> 1 file changed, 2 insertions(+), 4 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c<br> index 5652cc72ed3a..cb94627fc0f4 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c<br> @@ -1077,8 +1077,7 @@ static int amdgpu_debugfs_ib_preempt(void *data, u64 val)<br> <br> ttm_bo_unlock_delayed_workqueue(&adev->mman.bdev, resched);<br> <br> - if (fences)<br> - kfree(fences);<br> + kfree(fences);<br> <br> return 0;<br> }<br> @@ -1103,8 +1102,7 @@ int amdgpu_debugfs_init(struct amdgpu_device *adev)<br> <br> void amdgpu_debugfs_preempt_cleanup(struct amdgpu_device *adev)<br> {<br> - if (adev->debugfs_preempt)<br> - debugfs_remove(adev->debugfs_preempt);<br> + debugfs_remove(adev->debugfs_preempt);<br> }<br> <br> #else<br> -- <br> 2.20.1<br> <br> </div> </span></font></div> </body> </html>