<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:14.0pt;
font-family:"Calibri",sans-serif;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri",sans-serif;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 81.65pt 1.0in 81.65pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">> -----Original Message-----</p>
<p class="MsoPlainText">> From: Chen, Guchun <Guchun.Chen@amd.com></p>
<p class="MsoPlainText">> Sent: Tuesday, October 29, 2019 9:28 AM</p>
<p class="MsoPlainText">> To: Ma, Le <Le.Ma@amd.com>; amd-gfx@lists.freedesktop.org</p>
<p class="MsoPlainText">> Cc: Ma, Le <Le.Ma@amd.com></p>
<p class="MsoPlainText">> Subject: RE: [PATCH 2/4] drm/amdgpu: reset err_event_athub flag if gpu</p>
<p class="MsoPlainText">> recovery succeeded</p>
<p class="MsoPlainText">> </p>
<p class="MsoPlainText">> </p>
<p class="MsoPlainText">> </p>
<p class="MsoPlainText">> Regards,</p>
<p class="MsoPlainText">> Guchun</p>
<p class="MsoPlainText">> </p>
<p class="MsoPlainText">> -----Original Message-----</p>
<p class="MsoPlainText">> From: amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org"><span style="color:windowtext;text-decoration:none">amd-gfx-bounces@lists.freedesktop.org</span></a>> On Behalf Of Le Ma</p>
<p class="MsoPlainText">> Sent: Monday, October 28, 2019 7:31 PM</p>
<p class="MsoPlainText">> To: <a href="mailto:amd-gfx@lists.freedesktop.org"><span style="color:windowtext;text-decoration:none">amd-gfx@lists.freedesktop.org</span></a></p>
<p class="MsoPlainText">> Cc: Ma, Le <<a href="mailto:Le.Ma@amd.com"><span style="color:windowtext;text-decoration:none">Le.Ma@amd.com</span></a>></p>
<p class="MsoPlainText">> Subject: [PATCH 2/4] drm/amdgpu: reset err_event_athub flag if gpu recovery</p>
<p class="MsoPlainText">> succeeded</p>
<p class="MsoPlainText">> </p>
<p class="MsoPlainText">> Otherwise next err_event_athub error cannot call gpu reset.</p>
<p class="MsoPlainText">> </p>
<p class="MsoPlainText">> Change-Id: I5cd293f30f23876bf2a1860681bcb50f47713ecd</p>
<p class="MsoPlainText">> Signed-off-by: Le Ma <<a href="mailto:le.ma@amd.com"><span style="color:windowtext;text-decoration:none">le.ma@amd.com</span></a>></p>
<p class="MsoPlainText">> ---</p>
<p class="MsoPlainText">> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++</p>
<p class="MsoPlainText">> 1 file changed, 3 insertions(+)</p>
<p class="MsoPlainText">> </p>
<p class="MsoPlainText">> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c</p>
<p class="MsoPlainText">> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c</p>
<p class="MsoPlainText">> index 676cad1..51d74bb 100644</p>
<p class="MsoPlainText">> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c</p>
<p class="MsoPlainText">> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c</p>
<p class="MsoPlainText">> @@ -4089,6 +4089,9 @@ int amdgpu_device_gpu_recover(struct</p>
<p class="MsoPlainText">> amdgpu_device *adev,</p>
<p class="MsoPlainText">> }</p>
<p class="MsoPlainText">> }</p>
<p class="MsoPlainText">> </p>
<p class="MsoPlainText">> + if (!r && in_ras_intr)</p>
<p class="MsoPlainText">> + atomic_set(&amdgpu_ras_in_intr, 0);</p>
<p class="MsoPlainText">> [Guchun]To access this atomic variable, maybe it's better we create a new</p>
<p class="MsoPlainText">> function like reset or clear in amdgpu_ras.h or .c first, then we can call that</p>
<p class="MsoPlainText">> function here, like we we do to amdgpu_ras_intr_triggered in this same</p>
<p class="MsoPlainText">> function. This will do assist to modularity of ras driver.</p>
<p class="MsoPlainText">> <span style="color:#203864;mso-style-textfill-fill-color:#203864;mso-style-textfill-fill-alpha:100.0%">
[Le] Agree with you. We could make it paired with amdgpu_ras_intr_triggered. <o:p>
</o:p></span></p>
<p class="MsoPlainText"><span style="color:black"><o:p> </o:p></span></p>
<p class="MsoPlainText">> skip_sched_resume:</p>
<p class="MsoPlainText">> list_for_each_entry(tmp_adev, device_list_handle, gmc.xgmi.head) {</p>
<p class="MsoPlainText">> /*unlock kfd: SRIOV would do it separately */</p>
<p class="MsoPlainText">> --</p>
<p class="MsoPlainText">> 2.7.4</p>
<p class="MsoPlainText">> </p>
<p class="MsoPlainText">> _______________________________________________</p>
<p class="MsoPlainText">> amd-gfx mailing list</p>
<p class="MsoPlainText">> <a href="mailto:amd-gfx@lists.freedesktop.org"><span style="color:windowtext;text-decoration:none">amd-gfx@lists.freedesktop.org</span></a></p>
<p class="MsoPlainText">> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">
<span style="color:windowtext;text-decoration:none">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</span></a></p>
</div>
</body>
</html>