<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Ping.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<a id="OWAAM822686" class="_1OtrSZdhKXVv3UhaivrdJ4 mention ms-bgc-nlr ms-fcl-b" href="mailto:Emily.Deng@amd.com">@Deng, Emily</a>
<a id="OWAAM720573" class="_1OtrSZdhKXVv3UhaivrdJ4 mention ms-bgc-nlr ms-fcl-b" href="mailto:Monk.Liu@amd.com">
@Liu, Monk</a>, can you help review this patch?</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks!</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Jiange<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Zhao, Jiange <jianzh@amd.com><br>
<b>Sent:</b> Tuesday, October 29, 2019 3:43 PM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Deng, Emily <Emily.Deng@amd.com>; Liu, Monk <Monk.Liu@amd.com>; Chang, HaiJun <HaiJun.Chang@amd.com>; Zhao, Jiange <Jiange.Zhao@amd.com><br>
<b>Subject:</b> [PATCH] drm/amdgpu/SRIOV: Only reset hw.status for target IP</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">From: Jiange Zhao <Jiange.Zhao@amd.com><br>
<br>
In the old way, when doing IH hw_init, PSP, nv_common<br>
and GMC hw.status would be reset to false, even though<br>
their hw_init have been done. In the next step, fw_loading,<br>
PSP would do hw_init again.<br>
<br>
In the new way, only reset hw.status to false for the target<br>
IP in the list. In this way, PSP will only do hw_init once.<br>
<br>
Signed-off-by: Jiange Zhao <Jiange.Zhao@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br>
index 4eee40b9d0b0..ad6d2452fed9 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br>
@@ -2352,11 +2352,11 @@ static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev)<br>
for (j = 0; j < adev->num_ip_blocks; j++) {<br>
block = &adev->ip_blocks[j];<br>
<br>
- block->status.hw = false;<br>
if (block->version->type != ip_order[i] ||<br>
!block->status.valid)<br>
continue;<br>
<br>
+ block->status.hw = false;<br>
r = block->version->funcs->hw_init(adev);<br>
DRM_INFO("RE-INIT-early: %s %s\n", block->version->funcs->name, r?"failed":"succeeded");<br>
if (r)<br>
-- <br>
2.20.1<br>
<br>
</div>
</span></font></div>
</body>
</html>