<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=Windows-1252"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Reviewed-by: Marek Olšák <marek.olsak@amd.com></div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Marek </div> <div id="appendonsend"></div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr">From: Zhu, Changfeng <Changfeng.Zhu@amd.com> Sent: November 4, 2019 02:07 To: Cui, Flora <Flora.Cui@amd.com>; brahma_sw_dev <brahma_sw_dev@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Liu, Aaron <Aaron.Liu@amd.com>; Zhang, Hawking <Hawking.Zhang@amd.com>; Huang, Ray <Ray.Huang@amd.com>; Huang, Shimmer <Xinmei.Huang@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Olsak, Marek <Marek.Olsak@amd.com> Subject: RE: enable dispatch/draw tests for renoir <div> </div> </div> <style>  </style> <div lang="EN-US" link="#0563C1" vlink="#954F72"> <div class="x_WordSection1"> Thanks for review, Flora. Hi Alex & Marek, Here is a libdrm patch for Renoir dispatch/draw tests. Could you please help review it? It needs to be upstream. BR, Changfeng. <div> <div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0in 0in 0in"> From: Cui, Flora <Flora.Cui@amd.com> Sent: Monday, November 4, 2019 1:21 PM To: Zhu, Changfeng <Changfeng.Zhu@amd.com>; brahma_sw_dev <brahma_sw_dev@amd.com> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Liu, Aaron <Aaron.Liu@amd.com>; Zhang, Hawking <Hawking.Zhang@amd.com>; Huang, Ray <Ray.Huang@amd.com>; Huang, Shimmer <Xinmei.Huang@amd.com> Subject: RE: enable dispatch/draw tests for renoir </div> </div> Good catch. rb <div> <div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0in 0in 0in"> From: Zhu, Changfeng <<a href="mailto:Changfeng.Zhu@amd.com">Changfeng.Zhu@amd.com</a>> Sent: Monday, November 4, 2019 11:59 AM To: brahma_sw_dev <<a href="mailto:brahma_sw_dev@amd.com">brahma_sw_dev@amd.com</a>> Cc: Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>>; Liu, Aaron <<a href="mailto:Aaron.Liu@amd.com">Aaron.Liu@amd.com</a>>; Cui, Flora <<a href="mailto:Flora.Cui@amd.com">Flora.Cui@amd.com</a>>; Zhang, Hawking <<a href="mailto:Hawking.Zhang@amd.com">Hawking.Zhang@amd.com</a>>; Huang, Ray <<a href="mailto:Ray.Huang@amd.com">Ray.Huang@amd.com</a>>; Huang, Shimmer <<a href="mailto:Xinmei.Huang@amd.com">Xinmei.Huang@amd.com</a>> Subject: enable dispatch/draw tests for renoir </div> </div> Hi Ray & Flora, It can run dispatch/draw tests on new Renoir chips. So we can take back dispatch/draw tests for Renoir. Could you please help review this patch? From 793b7fd4dd1580f29e27bd2a90da787535abee14 Mon Sep 17 00:00:00 2001 From: changzhu <<a href="mailto:Changfeng.Zhu@amd.com">Changfeng.Zhu@amd.com</a>> Date: Mon, 4 Nov 2019 11:48:19 +0800 Subject: [PATCH libdrm] tests/amdgpu: enable dispatch/draw tests for Renoir It can run dispatch/draw tests on new renoir chips. So it needs to enable dispatch/draw tests for Renoir again. Change-Id: I3a72a4bbfe0fc663ee0e3e58d8e9c304f513e568 Signed-off-by: changzhu <<a href="mailto:Changfeng.Zhu@amd.com">Changfeng.Zhu@amd.com</a>> --- tests/amdgpu/basic_tests.c | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/tests/amdgpu/basic_tests.c b/tests/amdgpu/basic_tests.c index e75b9d0d..a57dcbb4 100644 --- a/tests/amdgpu/basic_tests.c +++ b/tests/amdgpu/basic_tests.c @@ -592,20 +592,6 @@ int suite_basic_tests_init(void) family_id = gpu_info.family_id; - if (gpu_info.asic_id == 0x1636) { - if (amdgpu_set_test_active("Basic Tests", - "Dispatch Test", - CU_FALSE)) - fprintf(stderr, "test deactivation failed - %s\n", - CU_get_error_msg()); - - if (amdgpu_set_test_active("Basic Tests", - "Draw Test", - CU_FALSE)) - fprintf(stderr, "test deactivation failed - %s\n", - CU_get_error_msg()); - } - return CUE_SUCCESS; } @@ -2992,7 +2978,7 @@ void amdgpu_memset_draw(amdgpu_device_handle device_handle, resources[1] = bo_shader_ps; resources[2] = bo_shader_vs; resources[3] = bo_cmd; - r = amdgpu_bo_list_create(device_handle, 3, resources, NULL, &bo_list); + r = amdgpu_bo_list_create(device_handle, 4, resources, NULL, &bo_list); CU_ASSERT_EQUAL(r, 0); ib_info.ib_mc_address = mc_address_cmd; -- 2.17.1 BR, Changfeng. </div> </div> </body> </html>