<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> Ashkan,<o:p></o:p> <o:p> </o:p> Can you comment on the observation from Alex regarding RLC_GPU_CLOCK_COUNT_LSB/MSB register with GFXoff and GPU reset?<o:p></o:p> <o:p> </o:p> If the statement from Alex is the real situation, we can simply our change.<o:p></o:p> <o:p> </o:p> Jerry<o:p></o:p> <o:p> </o:p> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Deucher, Alexander <Alexander.Deucher@amd.com> Sent: Wednesday, November 6, 2019 9:10 AM To: Jiang, Jerry (SW) <Jerry.Jiang@amd.com>; Huang, JinHuiEric <JinHuiEric.Huang@amd.com>; Alex Deucher <alexdeucher@gmail.com> Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: change read of GPU clock counter on Vega10 VF<o:p></o:p> </div> </div> <o:p> </o:p> <div> The current bare metal registers also get reset with gfxoff and GPU reset.<o:p></o:p> </div> <div> <o:p> </o:p> </div> <div> Alex<o:p></o:p> </div> <div> <o:p> </o:p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> From: amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of Jiang, Jerry (SW) <<a href="mailto:Jerry.Jiang@amd.com">Jerry.Jiang@amd.com</a>> Sent: Tuesday, November 5, 2019 7:04 PM To: Huang, JinHuiEric <<a href="mailto:JinHuiEric.Huang@amd.com">JinHuiEric.Huang@amd.com</a>>; Alex Deucher <<a href="mailto:alexdeucher@gmail.com">alexdeucher@gmail.com</a>> Cc: <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>> Subject: RE: [PATCH] drm/amdgpu: change read of GPU clock counter on Vega10 VF <o:p></o:p> <div> <o:p></o:p> </div> </div> <div> <div> Hi Alex, Under the SRIOV mode, the L1 policy prevent the write to mmRLC_CAPTURE_GPU_CLOCK_COUNT on VF, so the RLC_GPU_CLOCK_COUNT_LSB/MSB doesn't get updated for each read under SRIOV VF. On the other hand, the read from RLC_REFCLOCK_TIMESTAMP_LSB/MSB doesn't rely on any write, so it is available on VF. And of cause it is available for bare metal also. However, the RLC_REFCLOCK_TIMESTAMP_LSB/MSB will reset to zero under two cases: 1) GFXOFF 2) Reset. Since SRIOV doesn't have GFXOFF, and after reset, the guest will have to restart the app, so there is no problem for SRIOV to switch to this new register set. On bare metal, there is concern with these two cases. We didn't get confirmation from Rocm team that the counter reset to zero after 1) GFXOFF 2) Reset will not affect the usage of GPU timestamp, we can't make the switch for bare metal. I would be more than happy to switch all over if we can.. Jerry -----Original Message----- From: Huang, JinHuiEric <<a href="mailto:JinHuiEric.Huang@amd.com">JinHuiEric.Huang@amd.com</a>> Sent: Tuesday, November 5, 2019 6:48 PM To: Alex Deucher <<a href="mailto:alexdeucher@gmail.com">alexdeucher@gmail.com</a>> Cc: <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>; Jiang, Jerry (SW) <<a href="mailto:Jerry.Jiang@amd.com">Jerry.Jiang@amd.com</a>> Subject: Re: [PATCH] drm/amdgpu: change read of GPU clock counter on Vega10 VF On 2019-11-05 6:06 p.m., Alex Deucher wrote: > On Tue, Nov 5, 2019 at 5:26 PM Huang, JinHuiEric > <<a href="mailto:JinHuiEric.Huang@amd.com">JinHuiEric.Huang@amd.com</a>> wrote: >> Using unified VBIOS has performance drop in sriov environment. >> The fix is switching to another register instead. >> >> Signed-off-by: Eric Huang <<a href="mailto:JinhuiEric.Huang@amd.com">JinhuiEric.Huang@amd.com</a>> >> --- >> drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 19 ++++++++++++++++--- >> 1 file changed, 16 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c >> b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c >> index 829d623..e44a3ea 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c >> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c >> @@ -3885,9 +3885,22 @@ static uint64_t gfx_v9_0_get_gpu_clock_counter(struct amdgpu_device *adev) >> uint64_t clock; >> >> mutex_lock(&adev->gfx.gpu_clock_mutex); >> - WREG32_SOC15(GC, 0, mmRLC_CAPTURE_GPU_CLOCK_COUNT, 1); >> - clock = (uint64_t)RREG32_SOC15(GC, 0, mmRLC_GPU_CLOCK_COUNT_LSB) | >> - ((uint64_t)RREG32_SOC15(GC, 0, mmRLC_GPU_CLOCK_COUNT_MSB) << 32ULL); >> + if (adev->asic_type == CHIP_VEGA10 && amdgpu_sriov_runtime(adev)) { >> + uint32_t tmp, lsb, msb, i = 0; >> + do { >> + if (i != 0) >> + udelay(1); >> + tmp = RREG32_SOC15(GC, 0, mmRLC_REFCLOCK_TIMESTAMP_MSB); >> + lsb = RREG32_SOC15(GC, 0, mmRLC_REFCLOCK_TIMESTAMP_LSB); >> + msb = RREG32_SOC15(GC, 0, mmRLC_REFCLOCK_TIMESTAMP_MSB); >> + i++; >> + } while (unlikely(tmp != msb) && (i < adev->usec_timeout)); >> + clock = (uint64_t)lsb | ((uint64_t)msb << 32ULL); >> + } else { >> + WREG32_SOC15(GC, 0, mmRLC_CAPTURE_GPU_CLOCK_COUNT, 1); >> + clock = (uint64_t)RREG32_SOC15(GC, 0, mmRLC_GPU_CLOCK_COUNT_LSB) | >> + ((uint64_t)RREG32_SOC15(GC, 0, mmRLC_GPU_CLOCK_COUNT_MSB) << 32ULL); >> + } > Is there a reason we can't use the same regs on bare metal and SR-IOV? > I'd like to minimize the deltas if possible. As Jerry's request, this change will avoid P1 policy protection on RLC_GPU_CLOCK_COUNT_LSB/MSB. Eric > > Alex > >> mutex_unlock(&adev->gfx.gpu_clock_mutex); >> return clock; >> } >> -- >> 2.7.4 >> >> _______________________________________________ >> amd-gfx mailing list >> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> >> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> _______________________________________________ amd-gfx mailing list <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><o:p></o:p> </div> </div> </div> </body> </html>