<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
If this is not submitted, I would like to see some comments regarding the explanation of MC address and logical address, which I prefer to mention as GPU physical/virtual address.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Regards,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Yong</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Alex Deucher <alexdeucher@gmail.com><br>
<b>Sent:</b> Thursday, November 7, 2019 9:02 AM<br>
<b>To:</b> Zeng, Oak <Oak.Zeng@amd.com><br>
<b>Cc:</b> Kuehling, Felix <Felix.Kuehling@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Subject:</b> Re: [PATCH] drm/amdgpu: Add comments to gmc structure</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On Wed, Nov 6, 2019 at 12:27 PM Zeng, Oak <Oak.Zeng@amd.com> wrote:<br>
><br>
> Explain fields like aper_base, agp_start etc. The definition<br>
> of those fields are confusing as they are from different view<br>
> (CPU or GPU). Add comments for easier understand.<br>
><br>
> Change-Id: I02c2a27cd0dbc205498eb86aafa722f2e0c25fe6<br>
> Signed-off-by: Oak Zeng <Oak.Zeng@amd.com><br>
<br>
Same comments as the previous version. With those addressed,<br>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com><br>
<br>
> ---<br>
> drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 26 ++++++++++++++++++++++++++<br>
> 1 file changed, 26 insertions(+)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h<br>
> index 555d8e5..1356ff9 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h<br>
> @@ -127,18 +127,44 @@ struct amdgpu_xgmi {<br>
> };<br>
><br>
> struct amdgpu_gmc {<br>
> + /* FB's physical address in MMIO space (for CPU to<br>
> + * map FB). This is different compared to the apg/<br>
> + * gart/vram_start/end field as the later is from<br>
> + * GPU's view and aper_base is from CPU's view.<br>
> + */<br>
> resource_size_t aper_size;<br>
> resource_size_t aper_base;<br>
> /* for some chips with <= 32MB we need to lie<br>
> * about vram size near mc fb location */<br>
> u64 mc_vram_size;<br>
> u64 visible_vram_size;<br>
> + /* APG aperture start and end in MC address space<br>
> + * Driver find a hole in the MC address space<br>
> + * to place AGP by setting MC_VM_AGP_BOT/TOP registers<br>
> + * Under VMID0, logical address == MC address<br>
> + * AGP aperture is used to simulate FB in ZFB case<br>
> + */<br>
> u64 agp_size;<br>
> u64 agp_start;<br>
> u64 agp_end;<br>
> + /* GART aperture start and end in MC address space<br>
> + * Driver find a hole in the MC address space<br>
> + * to place GART by setting VM_CONTEXT0_PAGE_TABLE_START/END_ADDR<br>
> + * registers<br>
> + * Under VMID0, logical address inside GART aperture will<br>
> + * be translated through gpuvm gart page table to access<br>
> + * paged system memory<br>
> + */<br>
> u64 gart_size;<br>
> u64 gart_start;<br>
> u64 gart_end;<br>
> + /* Frame buffer aperture of this GPU device. Different from<br>
> + * fb_start (see below), this only covers the local GPU device.<br>
> + * Driver get fb_start from MC_VM_FB_LOCATION_BASE (set by vbios)<br>
> + * and calculate vram_start of this local device by adding an<br>
> + * offset inside the XGMI hive.<br>
> + * Under VMID0, logical address == MC address<br>
> + */<br>
> u64 vram_start;<br>
> u64 vram_end;<br>
> /* FB region , it's same as local vram region in single GPU, in XGMI<br>
> --<br>
> 2.7.4<br>
><br>
> _______________________________________________<br>
> amd-gfx mailing list<br>
> amd-gfx@lists.freedesktop.org<br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></div>
</span></font></div>
</body>
</html>