<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Reviewed-by: Alex Deucher <alexander.deucher@amd.com><br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Hawking Zhang <Hawking.Zhang@amd.com><br>
<b>Sent:</b> Wednesday, November 20, 2019 7:36 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; Chen, Guchun <Guchun.Chen@amd.com>; Clements, John <John.Clements@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com><br>
<b>Cc:</b> Zhang, Hawking <Hawking.Zhang@amd.com><br>
<b>Subject:</b> [PATCH] drm/amdgpu: apply gpr/gds workaround before enabling GFX EDC mode</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">gfx memory should be initialized before enabling<br>
DED and FUE field in mmGB_EDC_MODE<br>
<br>
Change-Id: I248a087364cbd9858cba32a70be456af3f07c90d<br>
Signed-off-by: Hawking Zhang <Hawking.Zhang@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 8 ++++----<br>
1 file changed, 4 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c<br>
index 0d6965ba7a86..68359059e390 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c<br>
@@ -4213,10 +4213,6 @@ static int gfx_v9_0_ecc_late_init(void *handle)<br>
struct amdgpu_device *adev = (struct amdgpu_device *)handle;<br>
int r;<br>
<br>
- r = amdgpu_gfx_ras_late_init(adev);<br>
- if (r)<br>
- return r;<br>
-<br>
r = gfx_v9_0_do_edc_gds_workarounds(adev);<br>
if (r)<br>
return r;<br>
@@ -4226,6 +4222,10 @@ static int gfx_v9_0_ecc_late_init(void *handle)<br>
if (r)<br>
return r;<br>
<br>
+ r = amdgpu_gfx_ras_late_init(adev);<br>
+ if (r)<br>
+ return r;<br>
+<br>
return 0;<br>
}<br>
<br>
-- <br>
2.17.1<br>
<br>
</div>
</span></font></div>
</body>
</html>