<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:14.0pt;
font-family:"Calibri",sans-serif;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri",sans-serif;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">-----Original Message-----<br>
From: Chen, Guchun <Guchun.Chen@amd.com> <br>
Sent: Wednesday, November 27, 2019 5:50 PM<br>
To: Ma, Le <Le.Ma@amd.com>; amd-gfx@lists.freedesktop.org<br>
Cc: Zhang, Hawking <Hawking.Zhang@amd.com>; Zhou1, Tao <Tao.Zhou1@amd.com>; Li, Dennis <Dennis.Li@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Ma, Le <Le.Ma@amd.com><br>
Subject: RE: [PATCH 10/10] drm/amdgpu: reduce redundant uvd context lost warning message</p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">[AMD Official Use Only - Internal Distribution Only]<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">-----Original Message-----<o:p></o:p></p>
<p class="MsoPlainText">From: Le Ma <<a href="mailto:le.ma@amd.com"><span style="color:windowtext;text-decoration:none">le.ma@amd.com</span></a>>
<o:p></o:p></p>
<p class="MsoPlainText">Sent: Wednesday, November 27, 2019 5:15 PM<o:p></o:p></p>
<p class="MsoPlainText">To: <a href="mailto:amd-gfx@lists.freedesktop.org"><span style="color:windowtext;text-decoration:none">amd-gfx@lists.freedesktop.org</span></a><o:p></o:p></p>
<p class="MsoPlainText">Cc: Zhang, Hawking <<a href="mailto:Hawking.Zhang@amd.com"><span style="color:windowtext;text-decoration:none">Hawking.Zhang@amd.com</span></a>>; Chen, Guchun <<a href="mailto:Guchun.Chen@amd.com"><span style="color:windowtext;text-decoration:none">Guchun.Chen@amd.com</span></a>>;
Zhou1, Tao <<a href="mailto:Tao.Zhou1@amd.com"><span style="color:windowtext;text-decoration:none">Tao.Zhou1@amd.com</span></a>>; Li, Dennis <<a href="mailto:Dennis.Li@amd.com"><span style="color:windowtext;text-decoration:none">Dennis.Li@amd.com</span></a>>;
Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com"><span style="color:windowtext;text-decoration:none">Alexander.Deucher@amd.com</span></a>>; Ma, Le <<a href="mailto:Le.Ma@amd.com"><span style="color:windowtext;text-decoration:none">Le.Ma@amd.com</span></a>><o:p></o:p></p>
<p class="MsoPlainText">Subject: [PATCH 10/10] drm/amdgpu: reduce redundant uvd context lost warning message<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">Move the print out of uvd instance loop in amdgpu_uvd_suspend<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">Change-Id: Ifad997debd84763e1b55d668e144b729598f115e<o:p></o:p></p>
<p class="MsoPlainText">Signed-off-by: Le Ma <<a href="mailto:le.ma@amd.com"><span style="color:windowtext;text-decoration:none">le.ma@amd.com</span></a>><o:p></o:p></p>
<p class="MsoPlainText">---<o:p></o:p></p>
<p class="MsoPlainText">drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 5 ++++-<o:p></o:p></p>
<p class="MsoPlainText">1 file changed, 4 insertions(+), 1 deletion(-)<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c<o:p></o:p></p>
<p class="MsoPlainText">index e324bfe..ac7c7795 100644<o:p></o:p></p>
<p class="MsoPlainText">--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c<o:p></o:p></p>
<p class="MsoPlainText">+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c<o:p></o:p></p>
<p class="MsoPlainText">@@ -377,12 +377,15 @@ int amdgpu_uvd_suspend(struct amdgpu_device *adev)<o:p></o:p></p>
<p class="MsoPlainText"><o:p></o:p></p>
<p class="MsoPlainText"> /* re-write 0 since err_event_athub will corrupt VCPU buffer */<o:p></o:p></p>
<p class="MsoPlainText"> if (amdgpu_ras_intr_triggered()) {<o:p></o:p></p>
<p class="MsoPlainText">- DRM_WARN("UVD VCPU state may lost due to RAS ERREVENT_ATHUB_INTERRUPT\n");<o:p></o:p></p>
<p class="MsoPlainText"> memset(adev->uvd.inst[j].saved_bo, 0, size);<o:p></o:p></p>
<p class="MsoPlainText"> } else {<o:p></o:p></p>
<p class="MsoPlainText"> memcpy_fromio(adev->uvd.inst[j].saved_bo, ptr, size);<o:p></o:p></p>
<p class="MsoPlainText"> }<o:p></o:p></p>
<p class="MsoPlainText"> }<o:p></o:p></p>
<p class="MsoPlainText">+<o:p></o:p></p>
<p class="MsoPlainText">+ if (amdgpu_ras_intr_triggered()) {<o:p></o:p></p>
<p class="MsoPlainText">+ DRM_WARN("UVD VCPU state may lost due to RAS ERREVENT_ATHUB_INTERRUPT\n");<o:p></o:p></p>
<p class="MsoPlainText">+<o:p></o:p></p>
<p class="MsoPlainText">[Guchun]the "{" after the if condition needs to be removed?<o:p></o:p></p>
<p class="MsoPlainText"><span style="color:#203864;mso-style-textfill-fill-color:#203864;mso-style-textfill-fill-alpha:100.0%">[Le] Yes, sent it too quickly and made a mistake here.<o:p></o:p></span></p>
<p class="MsoPlainText"> return 0;<o:p></o:p></p>
<p class="MsoPlainText">}<o:p></o:p></p>
<p class="MsoPlainText"><o:p></o:p></p>
<p class="MsoPlainText">-- <o:p></o:p></p>
<p class="MsoPlainText">2.7.4<o:p></o:p></p>
</div>
</body>
</html>