<html><head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body text="#000000" bgcolor="#FFFFFF"> <div class="moz-cite-prefix">On 12/2/19 6:42 AM, Ma, Le wrote: </div> <blockquote type="cite" cite="mid:MN2PR12MB428532FA663C99770AA71263F6430@MN2PR12MB4285.namprd12.prod.outlook.com"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> <div class="WordSection1"> [AMD Official Use Only - Internal Distribution Only]<o:p></o:p> <o:p> </o:p> <o:p> </o:p> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Grodzovsky, Andrey <a class="moz-txt-link-rfc2396E" href="mailto:Andrey.Grodzovsky@amd.com"><Andrey.Grodzovsky@amd.com></a> Sent: Saturday, November 30, 2019 12:22 AM To: Ma, Le <a class="moz-txt-link-rfc2396E" href="mailto:Le.Ma@amd.com"><Le.Ma@amd.com></a>; <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> Cc: Chen, Guchun <a class="moz-txt-link-rfc2396E" href="mailto:Guchun.Chen@amd.com"><Guchun.Chen@amd.com></a>; Zhou1, Tao <a class="moz-txt-link-rfc2396E" href="mailto:Tao.Zhou1@amd.com"><Tao.Zhou1@amd.com></a>; Deucher, Alexander <a class="moz-txt-link-rfc2396E" href="mailto:Alexander.Deucher@amd.com"><Alexander.Deucher@amd.com></a>; Li, Dennis <a class="moz-txt-link-rfc2396E" href="mailto:Dennis.Li@amd.com"><Dennis.Li@amd.com></a>; Zhang, Hawking <a class="moz-txt-link-rfc2396E" href="mailto:Hawking.Zhang@amd.com"><Hawking.Zhang@amd.com></a> Subject: Re: [PATCH 07/10] drm/amdgpu: add concurrent baco reset support for XGMI<o:p></o:p> </div> </div> <o:p> </o:p> <o:p> </o:p> <div> On 11/28/19 4:00 AM, Ma, Le wrote:<o:p></o:p> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <o:p></o:p> <o:p></o:p> -----Original Message----- From: Grodzovsky, Andrey <a href="mailto:Andrey.Grodzovsky@amd.com" moz-do-not-send="true"><Andrey.Grodzovsky@amd.com></a> Sent: Wednesday, November 27, 2019 11:46 PM To: Ma, Le <a href="mailto:Le.Ma@amd.com" moz-do-not-send="true"><Le.Ma@amd.com></a>; <a href="mailto:amd-gfx@lists.freedesktop.org" moz-do-not-send="true"> amd-gfx@lists.freedesktop.org</a> Cc: Chen, Guchun <a href="mailto:Guchun.Chen@amd.com" moz-do-not-send="true"><Guchun.Chen@amd.com></a>; Zhou1, Tao <a href="mailto:Tao.Zhou1@amd.com" moz-do-not-send="true"><Tao.Zhou1@amd.com></a>; Deucher, Alexander <a href="mailto:Alexander.Deucher@amd.com" moz-do-not-send="true"> <Alexander.Deucher@amd.com></a>; Li, Dennis <a href="mailto:Dennis.Li@amd.com" moz-do-not-send="true"><Dennis.Li@amd.com></a>; Zhang, Hawking <a href="mailto:Hawking.Zhang@amd.com" moz-do-not-send="true"><Hawking.Zhang@amd.com></a> Subject: Re: [PATCH 07/10] drm/amdgpu: add concurrent baco reset support for XGMI<o:p></o:p> <o:p></o:p> <o:p></o:p> On 11/27/19 4:15 AM, Le Ma wrote:<o:p></o:p> > Currently each XGMI node reset wq does not run in parrallel because <o:p></o:p> > same work item bound to same cpu runs in sequence. So change to bound <o:p></o:p> > the xgmi_reset_work item to different cpus.<o:p></o:p> <o:p></o:p> It's not the same work item, see more bellow<o:p></o:p> <o:p></o:p> <o:p></o:p> > <o:p></o:p> > XGMI requires all nodes enter into baco within very close proximity <o:p></o:p> > before any node exit baco. So schedule the xgmi_reset_work wq twice <o:p></o:p> > for enter/exit baco respectively.<o:p></o:p> > <o:p></o:p> > The default reset code path and methods do not change for vega20 production:<o:p></o:p> > - baco reset without xgmi/ras<o:p></o:p> > - psp reset with xgmi/ras<o:p></o:p> > <o:p></o:p> > To enable baco for XGMI/RAS case, both 2 conditions below are needed:<o:p></o:p> > - amdgpu_ras_enable=2<o:p></o:p> > - baco-supported smu firmware<o:p></o:p> > <o:p></o:p> > The case that PSP reset and baco reset coexist within an XGMI hive is <o:p></o:p> > not in the consideration.<o:p></o:p> > <o:p></o:p> > Change-Id: I9c08cf90134f940b42e20d2129ff87fba761c532<o:p></o:p> > Signed-off-by: Le Ma <<a href="mailto:le.ma@amd.com" moz-do-not-send="true">le.ma@amd.com</a>><o:p></o:p> > ---<o:p></o:p> > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +<o:p></o:p> > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 78 ++++++++++++++++++++++++++----<o:p></o:p> > 2 files changed, 70 insertions(+), 10 deletions(-)<o:p></o:p> > <o:p></o:p> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h <o:p></o:p> > b/drivers/gpu/drm/amd/amdgpu/amdgpu.h<o:p></o:p> > index d120fe5..08929e6 100644<o:p></o:p> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h<o:p></o:p> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h<o:p></o:p> > @@ -998,6 +998,8 @@ struct amdgpu_device {<o:p></o:p> > int pstate;<o:p></o:p> > /* enable runtime pm on the device */<o:p></o:p> > bool runpm;<o:p></o:p> > +<o:p></o:p> > + bool in_baco;<o:p></o:p> > };<o:p></o:p> > <o:p></o:p> > static inline struct amdgpu_device *amdgpu_ttm_adev(struct <o:p></o:p> > ttm_bo_device *bdev) diff --git <o:p></o:p> > a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c <o:p></o:p> > b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<o:p></o:p> > index bd387bb..71abfe9 100644<o:p></o:p> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<o:p></o:p> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<o:p></o:p> > @@ -2654,7 +2654,13 @@ static void amdgpu_device_xgmi_reset_func(struct work_struct *__work)<o:p></o:p> > struct amdgpu_device *adev =<o:p></o:p> > container_of(__work, struct amdgpu_device, xgmi_reset_work);<o:p></o:p> > <o:p></o:p> > - adev->asic_reset_res = amdgpu_asic_reset(adev);<o:p></o:p> > + if (amdgpu_asic_reset_method(adev) == AMD_RESET_METHOD_BACO)<o:p></o:p> > + adev->asic_reset_res = (adev->in_baco == false) ?<o:p></o:p> > + amdgpu_device_baco_enter(adev->ddev) :<o:p></o:p> > + amdgpu_device_baco_exit(adev->ddev);<o:p></o:p> > + else<o:p></o:p> > + adev->asic_reset_res = amdgpu_asic_reset(adev);<o:p></o:p> > +<o:p></o:p> > if (adev->asic_reset_res)<o:p></o:p> > DRM_WARN("ASIC reset failed with error, %d for drm dev, %s",<o:p></o:p> > adev->asic_reset_res, adev->ddev->unique); @@ -3796,6 +3802,7 @@ <o:p></o:p> > static int amdgpu_do_asic_reset(struct amdgpu_hive_info *hive,<o:p></o:p> > struct amdgpu_device *tmp_adev = NULL;<o:p></o:p> > bool need_full_reset = *need_full_reset_arg, vram_lost = false;<o:p></o:p> > int r = 0;<o:p></o:p> > + int cpu = smp_processor_id();<o:p></o:p> > <o:p></o:p> > /*<o:p></o:p> > * ASIC reset has to be done on all HGMI hive nodes ASAP @@ <o:p></o:p> > -3803,21 +3810,24 @@ static int amdgpu_do_asic_reset(struct amdgpu_hive_info *hive,<o:p></o:p> > */<o:p></o:p> > if (need_full_reset) {<o:p></o:p> > list_for_each_entry(tmp_adev, device_list_handle, gmc.xgmi.head) {<o:p></o:p> > - /* For XGMI run all resets in parallel to speed up the process */<o:p></o:p> > + /*<o:p></o:p> > + * For XGMI run all resets in parallel to speed up the<o:p></o:p> > + * process by scheduling the highpri wq on different<o:p></o:p> > + * cpus. For XGMI with baco reset, all nodes must enter<o:p></o:p> > + * baco within close proximity before anyone exit.<o:p></o:p> > + */<o:p></o:p> > if (tmp_adev->gmc.xgmi.num_physical_nodes > 1) {<o:p></o:p> > - if (!queue_work(system_highpri_wq, &tmp_adev->xgmi_reset_work))<o:p></o:p> <o:p></o:p> <o:p></o:p> Note that tmp_adev->xgmi_reset_work (the work item) is per device in XGMI hive and not the same work item. So I don't see why you need to explicitly queue them on different CPUs, they should run in parallel already.<o:p></o:p> <o:p></o:p> Andrey<o:p></o:p> <o:p></o:p> [Le]: It’s also beyond my understanding that the 2 node reset work items scheduled to same cpu does not run in parallel. But from the experiment result in my side, the 2nd work item always run after 1st work item finished. Based on this result, I changed to queue them on different CPUs to make sure more XGMI nodes case to run in parallel, because baco requires all nodes enter baco within very close proximity. <o:p></o:p> <o:p></o:p> The experiment code is as following for your reference. When card0 worker running, card1 worker is not observed to run.<o:p></o:p> </blockquote> <o:p> </o:p> The code bellow will only test that they don't run concurrently - but this doesn't mean they don't run on different CPUs and threads,I don't have an XGMI setup at hand to test this theory but what if there is some locking dependency between them that serializes their execution ? Can you just add a one line print inside amdgpu_device_xgmi_reset_func that prints CPU id, thread name/id and card number ?<o:p></o:p> Andrey<o:p></o:p> [Le]: I checked if directly use queue_work() several times, the same CPU thread will be used. And the worker per CPU will execute the item one by one. Our goal here is to make the xgmi_reset_func run concurrently for XGMI BACO case. That’s why I schedule them on different CPUs to run parallelly. And I can share the XGMI system with you if you’d like to verify more. </div> </blockquote> I tried today to setup XGMI 2P setup to test this but weren't able to load with the XGMI bridge in place (maybe faulty bridge) - so yea - maybe leave me your setup before your changes (the original code) so i can try to open some kernel traces that show CPU id and thread id to check this. It's just so weird that system_highpri_wq which is documented to be multi-cpu and multi-threaded wouldn't queue those work items to different cpus and worker threads. Andrey <blockquote type="cite" cite="mid:MN2PR12MB428532FA663C99770AA71263F6430@MN2PR12MB4285.namprd12.prod.outlook.com"> <div class="WordSection1"> <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <o:p></o:p> +atomic_t card0_in_baco = ATOMIC_INIT(0);<o:p></o:p> +atomic_t card1_in_baco = ATOMIC_INIT(0);<o:p></o:p> +<o:p></o:p> static void amdgpu_device_xgmi_reset_func(struct work_struct *__work)<o:p></o:p> {<o:p></o:p> struct amdgpu_device *adev =<o:p></o:p> container_of(__work, struct amdgpu_device, xgmi_reset_work);<o:p></o:p> <o:p></o:p> + printk("lema1: card 0x%x goes into reset wq\n", adev->pdev->bus->number);<o:p></o:p> + if (adev->pdev->bus->number == 0x7) {<o:p></o:p> + atomic_set(&card1_in_baco, 1);<o:p></o:p> + printk("lema1: card1 in baco from card1 view\n");<o:p></o:p> + }<o:p></o:p> +<o:p></o:p> if (amdgpu_asic_reset_method(adev) == AMD_RESET_METHOD_BACO)<o:p></o:p> adev->asic_reset_res = (adev->in_baco == false) ?<o:p></o:p> amdgpu_device_baco_enter(adev->ddev) :<o:p></o:p> @@ -2664,6 +2673,23 @@ static void amdgpu_device_xgmi_reset_func(struct work_struct *__work)<o:p></o:p> if (adev->asic_reset_res)<o:p></o:p> DRM_WARN("ASIC reset failed with error, %d for drm dev, %s",<o:p></o:p> adev->asic_reset_res, adev->ddev->unique);<o:p></o:p> +<o:p></o:p> + if (adev->pdev->bus->number == 0x4) {<o:p></o:p> + atomic_set(&card0_in_baco, 1);<o:p></o:p> + printk("lema1: card0 in baco from card0 view\n");<o:p></o:p> +<o:p></o:p> + while (true)<o:p></o:p> + if (!!atomic_read(&card1_in_baco))<o:p></o:p> + break;<o:p></o:p> + printk("lema1: card1 in baco from card0 view\n");<o:p></o:p> + }<o:p></o:p> +<o:p></o:p> + if (adev->pdev->bus->number == 0x7) {<o:p></o:p> + while (true)<o:p></o:p> + if (!!atomic_read(&card0_in_baco))<o:p></o:p> + break;<o:p></o:p> + printk("lema1: card0 in baco from card1 view\n");<o:p></o:p> + }<o:p></o:p> <o:p></o:p> > + if (!queue_work_on(cpu, system_highpri_wq,<o:p></o:p> > + &tmp_adev->xgmi_reset_work))<o:p></o:p> > r = -EALREADY;<o:p></o:p> > + cpu = cpumask_next(cpu, cpu_online_mask);<o:p></o:p> > } else<o:p></o:p> > r = amdgpu_asic_reset(tmp_adev);<o:p></o:p> > -<o:p></o:p> > - if (r) {<o:p></o:p> > - DRM_ERROR("ASIC reset failed with error, %d for drm dev, %s",<o:p></o:p> > - r, tmp_adev->ddev->unique);<o:p></o:p> > + if (r)<o:p></o:p> > break;<o:p></o:p> > - }<o:p></o:p> > }<o:p></o:p> > <o:p></o:p> > - /* For XGMI wait for all PSP resets to complete before proceed */<o:p></o:p> > + /* For XGMI wait for all work to complete before proceed */<o:p></o:p> > if (!r) {<o:p></o:p> > list_for_each_entry(tmp_adev, device_list_handle,<o:p></o:p> > gmc.xgmi.head) {<o:p></o:p> > @@ -3826,11 +3836,59 @@ static int amdgpu_do_asic_reset(struct amdgpu_hive_info *hive,<o:p></o:p> > r = tmp_adev->asic_reset_res;<o:p></o:p> > if (r)<o:p></o:p> > break;<o:p></o:p> > + if(AMD_RESET_METHOD_BACO ==<o:p></o:p> > + amdgpu_asic_reset_method(tmp_adev))<o:p></o:p> > + tmp_adev->in_baco = true;<o:p></o:p> > }<o:p></o:p> > }<o:p></o:p> > }<o:p></o:p> > - }<o:p></o:p> > <o:p></o:p> > + /*<o:p></o:p> > + * For XGMI with baco reset, need exit baco phase by scheduling<o:p></o:p> > + * xgmi_reset_work one more time. PSP reset skips this phase.<o:p></o:p> > + * Not assume the situation that PSP reset and baco reset<o:p></o:p> > + * coexist within an XGMI hive.<o:p></o:p> > + */<o:p></o:p> > +<o:p></o:p> > + if (!r) {<o:p></o:p> > + cpu = smp_processor_id();<o:p></o:p> > + list_for_each_entry(tmp_adev, device_list_handle,<o:p></o:p> > + gmc.xgmi.head) {<o:p></o:p> > + if (tmp_adev->gmc.xgmi.num_physical_nodes > 1<o:p></o:p> > + && AMD_RESET_METHOD_BACO ==<o:p></o:p> > + amdgpu_asic_reset_method(tmp_adev)) {<o:p></o:p> > + if (!queue_work_on(cpu,<o:p></o:p> > + system_highpri_wq,<o:p></o:p> > + &tmp_adev->xgmi_reset_work))<o:p></o:p> > + r = -EALREADY;<o:p></o:p> > + if (r)<o:p></o:p> > + break;<o:p></o:p> > + cpu = cpumask_next(cpu, cpu_online_mask);<o:p></o:p> > + }<o:p></o:p> > + }<o:p></o:p> > + }<o:p></o:p> > +<o:p></o:p> > + if (!r) {<o:p></o:p> > + list_for_each_entry(tmp_adev, device_list_handle,<o:p></o:p> > + gmc.xgmi.head) {<o:p></o:p> > + if (tmp_adev->gmc.xgmi.num_physical_nodes > 1<o:p></o:p> > + && AMD_RESET_METHOD_BACO ==<o:p></o:p> > + amdgpu_asic_reset_method(tmp_adev)) {<o:p></o:p> > + flush_work(&tmp_adev->xgmi_reset_work);<o:p></o:p> > + r = tmp_adev->asic_reset_res;<o:p></o:p> > + if (r)<o:p></o:p> > + break;<o:p></o:p> > + tmp_adev->in_baco = false;<o:p></o:p> > + }<o:p></o:p> > + }<o:p></o:p> > + }<o:p></o:p> > +<o:p></o:p> > + if (r) {<o:p></o:p> > + DRM_ERROR("ASIC reset failed with error, %d for drm dev, %s",<o:p></o:p> > + r, tmp_adev->ddev->unique);<o:p></o:p> > + goto end;<o:p></o:p> > + }<o:p></o:p> > + }<o:p></o:p> > <o:p></o:p> > list_for_each_entry(tmp_adev, device_list_handle, gmc.xgmi.head) {<o:p></o:p> > if (need_full_reset) {<o:p></o:p> </blockquote> </div> </blockquote> </body> </html>