<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> <p class="MsoNormal">Ping…<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b>From:</b> Zhang, Jack (Jian) <br> <b>Sent:</b> Tuesday, December 24, 2019 11:51 AM<br> <b>To:</b> Wang, Kevin(Yang) <Kevin1.Wang@amd.com>; Feng, Kenneth <Kenneth.Feng@amd.com>; Tao, Yintian <Yintian.Tao@amd.com>; amd-gfx@lists.freedesktop.org; Deng, Emily <Emily.Deng@amd.com>; Quan, Evan <Evan.Quan@amd.com><br> <b>Subject:</b> RE: [PATCH] amd/amdgpu/sriov enable onevf mode for ARCTURUS VF<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Hi, Kevin,<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Thank you for your code review.<o:p></o:p></p> <ol style="margin-top:0in" start="1" type="1"> <li class="MsoListParagraph" style="margin-left:0in;mso-list:l0 level1 lfo3">I updated the patch to refine pm_enbable logic (attached).<o:p></o:p></li></ol> <p class="MsoNormal"><o:p> </o:p></p> <ol style="margin-top:0in" start="2" type="1"> <li class="MsoListParagraph" style="margin-left:0in;mso-list:l0 level1 lfo3">For the following comments. “* Copy pptable bo in the vram…”, it is the original bare-metal comments. I didn’t change it. <o:p></o:p></li></ol> <p class="MsoNormal"><o:p> </o:p></p> <ol style="margin-top:0in" start="3" type="1"> <li class="MsoListParagraph" style="margin-left:0in;mso-list:l0 level1 lfo3">“could you describe the function of pp_one_vf and sriov_vf ?”<o:p></o:p></li></ol> <ol style="margin-top:0in" start="1" type="1"> <li class="MsoListParagraph" style="mso-list:l2 level1 lfo8">amdgpu_sriov_vf marks if it is sriov or bare-metal. While amdgpu_sriov_is_pp_one_vf is <span style="background:yellow;mso-highlight:yellow">a mode of sriov</span>- It means there is only one VF generated by host driver.<o:p></o:p></li><li class="MsoListParagraph" style="mso-list:l2 level1 lfo8">When host driver is loaded, host administrator can determine “vf number”. If vf_num =1, host driver will let guest driver know it is under one vf mode-pp_one_vf return true. Otherwise, pp_one_vf return false. Without unloading guest driver and host driver, vf_num cannot be changed. So it is a static process.<o:p></o:p></li><li class="MsoListParagraph" style="mso-list:l2 level1 lfo8">Under pp_one_vf mode, guest driver will do hw_init for smu, the purpose of it is to enable guest driver to “talk” with smu by sending authorized smu messages. This will help user mode app to dump info like clks, temperature, GPU usage…. Currently we don’t support guest driver to write value to smu. Only support read permission to dump smu infos.<o:p></o:p></li></ol> <p class="MsoListParagraph" style="margin-left:1.0in">Besides, as host driver has already initialized smu hw, some hw init steps need to skip in guest hw_init function of smu block,such as write pptable, load smc firmware.<o:p></o:p></p> <ol style="margin-top:0in" start="4" type="1"> <li class="MsoListParagraph" style="mso-list:l2 level1 lfo8">pp_one_vf mode need smu some firmware changes to open permission for certain messages in VF.<o:p></o:p></li></ol> <p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p> <p class="MsoNormal">B.R.<o:p></o:p></p> <p class="MsoNormal">Jack<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b>From:</b> Wang, Kevin(Yang) <<a href="mailto:Kevin1.Wang@amd.com">Kevin1.Wang@amd.com</a>> <br> <b>Sent:</b> Monday, December 23, 2019 6:11 PM<br> <b>To:</b> Zhang, Jack (Jian) <<a href="mailto:Jack.Zhang1@amd.com">Jack.Zhang1@amd.com</a>>; Feng, Kenneth <<a href="mailto:Kenneth.Feng@amd.com">Kenneth.Feng@amd.com</a>>; Tao, Yintian <<a href="mailto:Yintian.Tao@amd.com">Yintian.Tao@amd.com</a>>; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>; Deng, Emily <<a href="mailto:Emily.Deng@amd.com">Emily.Deng@amd.com</a>><br> <b>Cc:</b> Quan, Evan <<a href="mailto:Evan.Quan@amd.com">Evan.Quan@amd.com</a>><br> <b>Subject:</b> Re: [PATCH] amd/amdgpu/sriov enable onevf mode for ARCTURUS VF<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">add <a id="OWAAM10677" href="mailto:Evan.Quan@amd.com"> <span style="font-family:"Calibri",sans-serif;text-decoration:none">@Quan, Evan</span></a> to support arcturus asic.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">comment inline.<o:p></o:p></span></p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> <p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> Zhang, Jack (Jian) <<a href="mailto:Jack.Zhang1@amd.com">Jack.Zhang1@amd.com</a>><br> <b>Sent:</b> Monday, December 23, 2019 4:42 PM<br> <b>To:</b> Feng, Kenneth <<a href="mailto:Kenneth.Feng@amd.com">Kenneth.Feng@amd.com</a>>; Wang, Kevin(Yang) <<a href="mailto:Kevin1.Wang@amd.com">Kevin1.Wang@amd.com</a>>; Tao, Yintian <<a href="mailto:Yintian.Tao@amd.com">Yintian.Tao@amd.com</a>>; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>>; Deng, Emily <<a href="mailto:Emily.Deng@amd.com">Emily.Deng@amd.com</a>><br> <b>Cc:</b> Zhang, Jack (Jian) <<a href="mailto:Jack.Zhang1@amd.com">Jack.Zhang1@amd.com</a>><br> <b>Subject:</b> RE: [PATCH] amd/amdgpu/sriov enable onevf mode for ARCTURUS VF</span> <o:p></o:p></p> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal"><br> <br> -----Original Message-----<br> From: Jack Zhang <<a href="mailto:Jack.Zhang1@amd.com">Jack.Zhang1@amd.com</a>> <br> Sent: Monday, December 23, 2019 4:40 PM<br> To: <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> Cc: Zhang, Jack (Jian) <<a href="mailto:Jack.Zhang1@amd.com">Jack.Zhang1@amd.com</a>><br> Subject: [PATCH] amd/amdgpu/sriov enable onevf mode for ARCTURUS VF<br> <br> Before, initialization of smu ip block would be skipped for sriov ASICs. But if there's only one VF being used, guest driver should be able to dump some HW info such as clks, temperature,etc.<br> <br> To solve this, now after onevf mode is enabled, host driver will notify guest. If it's onevf mode, guest will do smu hw_init and skip some steps in normal smu hw_init flow because host driver has already done it for smu.<br> <br> With this fix, guest app can talk with smu and dump hw information from smu.<br> <br> Signed-off-by: Jack Zhang <<a href="mailto:Jack.Zhang1@amd.com">Jack.Zhang1@amd.com</a>><br> ---<br> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 +-<br> drivers/gpu/drm/amd/amdgpu/soc15.c | 3 +-<br> drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 49 ++++++++++++++++++------------<br> 3 files changed, 33 insertions(+), 22 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c<br> index 8469834..08130a6 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c<br> @@ -1448,7 +1448,8 @@ static int psp_np_fw_load(struct psp_context *psp)<br> || ucode->ucode_id == AMDGPU_UCODE_ID_RLC_G<br> || ucode->ucode_id == AMDGPU_UCODE_ID_RLC_RESTORE_LIST_CNTL<br> || ucode->ucode_id == AMDGPU_UCODE_ID_RLC_RESTORE_LIST_GPM_MEM<br> - || ucode->ucode_id == AMDGPU_UCODE_ID_RLC_RESTORE_LIST_SRM_MEM))<br> + || ucode->ucode_id == AMDGPU_UCODE_ID_RLC_RESTORE_LIST_SRM_MEM<br> + || ucode->ucode_id == AMDGPU_UCODE_ID_SMC))<br> /*skip ucode loading in SRIOV VF */<br> continue;<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c<br> index b53d401..a271496 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/soc15.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/soc15.c<br> @@ -827,8 +827,7 @@ int soc15_set_ip_blocks(struct amdgpu_device *adev)<br> amdgpu_device_ip_block_add(adev, &dce_virtual_ip_block);<br> amdgpu_device_ip_block_add(adev, &gfx_v9_0_ip_block);<br> amdgpu_device_ip_block_add(adev, &sdma_v4_0_ip_block);<br> - if (!amdgpu_sriov_vf(adev))<br> - amdgpu_device_ip_block_add(adev, &smu_v11_0_ip_block);<br> + amdgpu_device_ip_block_add(adev, &smu_v11_0_ip_block);<br> <br> if (amdgpu_sriov_vf(adev)) {<br> if (likely(adev->firmware.load_type == AMDGPU_FW_LOAD_PSP)) diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c<br> index 936c682..c07fb26 100644<br> --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c<br> +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c<br> @@ -531,10 +531,14 @@ bool is_support_sw_smu(struct amdgpu_device *adev)<br> if (adev->asic_type == CHIP_VEGA20)<br> return (amdgpu_dpm == 2) ? true : false;<br> else if (adev->asic_type >= CHIP_ARCTURUS) {<br> - if (amdgpu_sriov_vf(adev))<br> - return false;<br> - else<br> + if (amdgpu_sriov_vf(adev)) {<br> + if(amdgpu_sriov_is_pp_one_vf(adev))<br> + return true;<br> + else<br> + return false;<br> + } else {<br> return true;<br> + }<br> } else<br> return false;<br> }<br> @@ -1062,20 +1066,19 @@ static int smu_smc_table_hw_init(struct smu_context *smu,<br> }<br> <br> /* smu_dump_pptable(smu); */<br> + if(amdgpu_sriov_vf(adev) && !amdgpu_sriov_is_pp_one_vf(adev)){<br> + /*<br> + * Copy pptable bo in the vram to smc with SMU MSGs such as<br> + * SetDriverDramAddr and TransferTableDram2Smu.<br> + */<o:p></o:p></p> </div> <div> <p class="MsoNormal">[kevin]: this comment is not neccessary in smu module.<o:p></o:p></p> </div> <div> <p class="MsoNormal">and could you describe the function of pp_one_vf and sriov_vf ?<o:p></o:p></p> </div> <div> <p class="MsoNormal">it is useful to help us understand your patch. <o:p></o:p></p> </div> <div> <p class="MsoNormal">thanks.<o:p></o:p></p> </div> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal">+ ret = smu_write_pptable(smu);<br> + if (ret)<br> + return ret;<br> <br> - /*<br> - * Copy pptable bo in the vram to smc with SMU MSGs such as<br> - * SetDriverDramAddr and TransferTableDram2Smu.<br> - */<br> - ret = smu_write_pptable(smu);<br> - if (ret)<br> - return ret;<br> -<br> - /* issue Run*Btc msg */<br> - ret = smu_run_btc(smu);<br> - if (ret)<br> - return ret;<br> -<br> + /* issue Run*Btc msg */<br> + ret = smu_run_btc(smu);<br> + if (ret)<br> + return ret;<br> ret = smu_feature_set_allowed_mask(smu);<br> if (ret)<br> return ret;<br> @@ -1083,7 +1086,7 @@ static int smu_smc_table_hw_init(struct smu_context *smu,<br> ret = smu_system_features_control(smu, true);<br> if (ret)<br> return ret;<br> -<br> + }<br> if (adev->asic_type != CHIP_ARCTURUS) {<br> ret = smu_notify_display_change(smu);<br> if (ret)<br> @@ -1136,8 +1139,9 @@ static int smu_smc_table_hw_init(struct smu_context *smu,<br> /*<br> * Set PMSTATUSLOG table bo address with SetToolsDramAddr MSG for tools.<br> */<br> - ret = smu_set_tool_table_location(smu);<br> -<br> + if(amdgpu_sriov_vf(adev) && !amdgpu_sriov_is_pp_one_vf(adev)){<br> + ret = smu_set_tool_table_location(smu);<br> + }<br> if (!smu_is_dpm_running(smu))<br> pr_info("dpm has been disabled\n");<br> <br> @@ -1249,6 +1253,13 @@ static int smu_hw_init(void *handle)<br> smu_set_gfx_cgpg(&adev->smu, true);<br> }<br> <br> + if (amdgpu_sriov_vf(adev)) {<br> + if(amdgpu_sriov_is_pp_one_vf(adev))<br> + smu->pm_enabled = true;<br> + else<br> + smu->pm_enabled = false;<br> + }<br> +<o:p></o:p></p> </div> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal">[kevin]:<o:p></o:p></p> </div> <div> <p class="MsoNormal">the variable of "smu->pm_enabeld" is initialize in smu_eary_init(), it is only depend on module param amdgpu_dpm.<o:p></o:p></p> </div> <p class="MsoNormal">after initialized, this variable should not be changed arbitrarily.<o:p></o:p></p> </div> <div> <p class="MsoNormal">so i hope you can refine the above code logic.<o:p></o:p></p> </div> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <div> <p class="MsoNormal" style="margin-bottom:12.0pt"> if (!smu->pm_enabled)<br> return 0;<br> <br> --<br> 2.7.4<o:p></o:p></p> </div> </div> </div> </div> </body> </html>