<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#317100;margin:15pt;" align="Left">
[AMD Public Use]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
If you resend the patch set, it might be good to include the script in the series for reference as well.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Alex<br>
</div>
<div id="appendonsend"></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Harry Wentland <hwentlan@amd.com><br>
<b>Sent:</b> Wednesday, January 22, 2020 2:27 PM<br>
<b>To:</b> Lakha, Bhawanpreet <Bhawanpreet.Lakha@amd.com>; Alex Deucher <alexdeucher@gmail.com><br>
<b>Cc:</b> Wentland, Harry <Harry.Wentland@amd.com>; amd-gfx list <amd-gfx@lists.freedesktop.org><br>
<b>Subject:</b> Re: [PATCH 0/5] HDCP SRM interface</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText"><br>
<br>
On 2020-01-22 11:44 a.m., Bhawanpreet Lakha wrote:<br>
> <br>
> On 2020-01-22 11:23 a.m., Alex Deucher wrote:<br>
>> On Wed, Jan 22, 2020 at 11:12 AM Harry Wentland <hwentlan@amd.com> wrote:<br>
>>> On 2020-01-16 3:29 p.m., Bhawanpreet Lakha wrote:<br>
>>>> These patches adds support for SRM loading. By providing an<br>
>>>> interface to the<br>
>>>> usermode<br>
>>>><br>
>>>> SRM has to be persistent and since the kernel cannot directly write<br>
>>>> to system<br>
>>>> storage we need to provide an interface so that the usermode can do<br>
>>>> it for us<br>
>>>><br>
>>> We'll want to elaborate a bit more on why and how this is done. As<br>
>>> mentioned on my patch 2 comments I recommend to do this there as the<br>
>>> cover letter is lost after merge.<br>
>>><br>
>> You might also want to cc dri-devel if you resend to get more reviews.<br>
>> I'm also not crazy about having to update the file in chunks, but I<br>
>> don't have any better ideas off hand. Maybe an ioctl would be<br>
>> cleaner?<br>
>><br>
>> Alex<br>
> <br>
> The kernel can only send PAGE_SIZE (4KB) at once, so if the file is<br>
> bigger than PAGE_SIZE (max SRM is 5KB) it will send it again until its<br>
> finished (unless we increase the page size).<br>
> <br>
> From the user space its just a single command to read/write<br>
> <br>
> save to storage : cat /sys/class/drm/card0/device/hdcp_srm > file<br>
> <br>
> load from storage : cat file> /sys/class/drm/card0/device/hdcp_srm<br>
> <br>
<br>
Please also add this info in the patch description or cover letter as<br>
well, including how you iterate for a large SRM. A simple copy-paste<br>
from the shell script should suffice. It's a bit hard to see how this<br>
interface is being used from userspace, especially around the get/set in<br>
chunks.<br>
<br>
Harry<br>
<br>
> I will send it to dri-devel after fixing what Harry suggested.<br>
> <br>
> Thanks<br>
> <br>
> Bhawan<br>
> <br>
>>> Harry<br>
>>><br>
>>>> Bhawanpreet Lakha (5):<br>
>>>> drm/amd/display: Pass amdgpu_device instead of psp_context<br>
>>>> drm/amd/display: update psp interface header<br>
>>>> drm/amd/display: Add sysfs interface for set/get srm<br>
>>>> drm/amd/display: Load srm before enabling HDCP<br>
>>>> drm/amd/display: call psp set/get interfaces<br>
>>>><br>
>>>> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-<br>
>>>> .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.c | 182<br>
>>>> +++++++++++++++++-<br>
>>>> .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.h | 9 +-<br>
>>>> .../drm/amd/display/modules/hdcp/hdcp_psp.h | 26 ++-<br>
>>>> 4 files changed, 212 insertions(+), 7 deletions(-)<br>
>>>><br>
>>> _______________________________________________<br>
>>> amd-gfx mailing list<br>
>>> amd-gfx@lists.freedesktop.org<br>
>>> <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Calexander.deucher%40amd.com%7C6045839ca9f14797ff3a08d79f713094%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637153180855191595&sdata=evmiajEJOkOb2L2GgUxg6JsWadR99PgoTE%2F6cQoBKfs%3D&reserved=0">
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Calexander.deucher%40amd.com%7C6045839ca9f14797ff3a08d79f713094%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637153180855191595&sdata=evmiajEJOkOb2L2GgUxg6JsWadR99PgoTE%2F6cQoBKfs%3D&reserved=0</a><br>
>>><br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Calexander.deucher%40amd.com%7C6045839ca9f14797ff3a08d79f713094%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637153180855191595&sdata=evmiajEJOkOb2L2GgUxg6JsWadR99PgoTE%2F6cQoBKfs%3D&reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Calexander.deucher%40amd.com%7C6045839ca9f14797ff3a08d79f713094%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637153180855191595&sdata=evmiajEJOkOb2L2GgUxg6JsWadR99PgoTE%2F6cQoBKfs%3D&reserved=0</a><br>
</div>
</span></font></div>
</div>
</body>
</html>