<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <p style="font-family:Arial;font-size:10pt;color:#317100;margin:15pt;" align="Left"> [AMD Public Use]<br> </p> <br> <div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Acked-by: Alex Deucher <alexander.deucher@amd.com><br> </div> <div id="appendonsend"></div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Jack Zhang <Jack.Zhang1@amd.com><br> <b>Sent:</b> Friday, February 7, 2020 4:51 AM<br> <b>To:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br> <b>Cc:</b> Zhang, Jack (Jian) <Jack.Zhang1@amd.com><br> <b>Subject:</b> [PATCH] drm/amdgpu/sriov set driver_table address in VF</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">With the recent patch to unify VRAM address for driver<br> table(a83f82e). VF cannot dump table info any more because<br> SMU_MSG_SetDriverDramAddrHigh/Low were deleted in the<br> function of smu_update_table.<br> <br> Therefore, VF also needs to set driver_table address<br> in smu_hw_init to fix this regression issue.<br> <br> Signed-off-by: Jack Zhang <Jack.Zhang1@amd.com><br> ---<br> drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 ++++----<br> 1 file changed, 4 insertions(+), 4 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c<br> index 99ad4dd..b155f04 100644<br> --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c<br> +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c<br> @@ -1113,12 +1113,12 @@ static int smu_smc_table_hw_init(struct smu_context *smu,<br> return ret;<br> }<br> <br> + ret = smu_set_driver_table_location(smu);<br> + if (ret)<br> + return ret;<br> +<br> /* smu_dump_pptable(smu); */<br> if (!amdgpu_sriov_vf(adev)) {<br> - ret = smu_set_driver_table_location(smu);<br> - if (ret)<br> - return ret;<br> -<br> /*<br> * Copy pptable bo in the vram to smc with SMU MSGs such as<br> * SetDriverDramAddr and TransferTableDram2Smu.<br> -- <br> 2.7.4<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Calexander.deucher%40amd.com%7Caf208aa3ff7b4af7901308d7abb35adb%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637166659148950161&sdata=y56uFDZzrgroC8VLFTQsB8Oe0%2BmNyIoMoMvNrjqhrIs%3D&reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Calexander.deucher%40amd.com%7Caf208aa3ff7b4af7901308d7abb35adb%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637166659148950161&sdata=y56uFDZzrgroC8VLFTQsB8Oe0%2BmNyIoMoMvNrjqhrIs%3D&reserved=0</a><br> </div> </span></font></div> </div> </body> </html>