<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#317100;margin:15pt;" align="Left">
[AMD Public Use]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Reviewed-by: Alex Deucher <alexander.deucher@amd.com><br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Changfeng.Zhu <changfeng.zhu@amd.com><br>
<b>Sent:</b> Thursday, February 13, 2020 11:03 PM<br>
<b>To:</b> Huang, Ray <Ray.Huang@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Zhu, Changfeng <Changfeng.Zhu@amd.com><br>
<b>Subject:</b> [PATCH] drm/amdgpu: add is_raven_kicker judgement for raven1</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">From: changzhu <Changfeng.Zhu@amd.com><br>
<br>
The rlc version of raven_kicer_rlc is different from the legacy rlc<br>
version of raven_rlc. So it needs to add a judgement function for<br>
raven_kicer_rlc and avoid disable GFXOFF when loading raven_kicer_rlc.<br>
<br>
Change-Id: I00d726cc39eae4ea788c1d5faeb8ce75ec0b884d<br>
Signed-off-by: changzhu <Changfeng.Zhu@amd.com><br>
---<br>
 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 11 +++++++++--<br>
 1 file changed, 9 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c<br>
index 4d8b58e9d0ae..9b7ff783e9a5 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c<br>
@@ -1193,6 +1193,14 @@ static bool gfx_v9_0_should_disable_gfxoff(struct pci_dev *pdev)<br>
         return false;<br>
 }<br>
 <br>
+static bool is_raven_kicker(struct amdgpu_device *adev)<br>
+{<br>
+       if (adev->pm.fw_version >= 0x41e2b)<br>
+               return true;<br>
+       else<br>
+               return false;<br>
+}<br>
+<br>
 static void gfx_v9_0_check_if_need_gfxoff(struct amdgpu_device *adev)<br>
 {<br>
         if (gfx_v9_0_should_disable_gfxoff(adev->pdev))<br>
@@ -1205,9 +1213,8 @@ static void gfx_v9_0_check_if_need_gfxoff(struct amdgpu_device *adev)<br>
                 break;<br>
         case CHIP_RAVEN:<br>
                 if (!(adev->rev_id >= 0x8 || adev->pdev->device == 0x15d8) &&<br>
-                   ((adev->gfx.rlc_fw_version != 106 &&<br>
+                   ((!is_raven_kicker(adev) &&<br>
                       adev->gfx.rlc_fw_version < 531) ||<br>
-                    (adev->gfx.rlc_fw_version == 53815) ||<br>
                      (adev->gfx.rlc_feature_version < 1) ||<br>
                      !adev->gfx.rlc.is_rlc_v2_1))<br>
                         adev->pm.pp_feature &= ~PP_GFXOFF_MASK;<br>
-- <br>
2.17.1<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Calexander.deucher%40amd.com%7C5839d10e3a0e4c5615ac08d7b102fbc3%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637172498725043115&amp;sdata=3D1zzp0A4FGFntc4f%2F4K3u%2FB4wYKtTtwDsPJkYoIslo%3D&amp;reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Calexander.deucher%40amd.com%7C5839d10e3a0e4c5615ac08d7b102fbc3%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637172498725043115&amp;sdata=3D1zzp0A4FGFntc4f%2F4K3u%2FB4wYKtTtwDsPJkYoIslo%3D&amp;reserved=0</a><br>
</div>
</span></font></div>
</div>
</body>
</html>