<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <p style="font-family:Arial;font-size:10pt;color:#0078D7;margin:15pt;" align="Left"> [AMD Official Use Only - Internal Distribution Only]<br> </p> <br> <div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <span style="color: rgb(32, 31, 30); font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 14.6667px; background-color: rgb(255, 255, 255); display: inline !important">It looks good to me. I was thinking maybe we should go one step further, adding more explanation comments around the MQD control stack workaround, so that people have a clearer idea of what's that <span style="font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; background-color: rgb(255, 255, 255); display: inline !important"> MQD control stack<span> </span></span>workaround is about. We can do that in a following commit.</span></div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <span style="color: rgb(32, 31, 30); font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 14.6667px; background-color: rgb(255, 255, 255); display: inline !important"><br> </span></div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <span style="color: rgb(32, 31, 30); font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 14.6667px; background-color: rgb(255, 255, 255); display: inline !important">Acked-by: Yong Zhao <Yong.Zhao@amd.com></span><br> </div> <div id="appendonsend"></div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Eric Huang <JinhuiEric.Huang@amd.com><br> <b>Sent:</b> Wednesday, February 26, 2020 2:37 PM<br> <b>To:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br> <b>Cc:</b> Huang, JinHuiEric <JinHuiEric.Huang@amd.com><br> <b>Subject:</b> [PATCH] drm/amdkfd: change SDMA MQD memory type</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">SDMA MQD memory type is NC that causes MQD data overwritten<br> accidentally by an old stable cache line. Changing it to UC<br> default for GART will fix the issue.<br> <br> Change-Id: If609f47c78cb97e2c8dc930df2ab5c10c29dfe56<br> Signed-off-by: Eric Huang <jinhuieric.huang@amd.com><br> ---<br> drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c<br> index 692abfd..77ea0f0 100644<br> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c<br> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c<br> @@ -1734,7 +1734,7 @@ static int allocate_hiq_sdma_mqd(struct device_queue_manager *dqm)<br> <br> retval = amdgpu_amdkfd_alloc_gtt_mem(dev->kgd, size,<br> &(mem_obj->gtt_mem), &(mem_obj->gpu_addr),<br> - (void *)&(mem_obj->cpu_ptr), true);<br> + (void *)&(mem_obj->cpu_ptr), false);<br> <br> return retval;<br> }<br> -- <br> 2.7.4<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cyong.zhao%40amd.com%7C2cbbb3322952475590f508d7baf34ce6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637183426468344453&sdata=2zCqxZJFXSbBlezU7UIZxc%2FQC0PBTum90MmIjCioHGw%3D&reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cyong.zhao%40amd.com%7C2cbbb3322952475590f508d7baf34ce6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637183426468344453&sdata=2zCqxZJFXSbBlezU7UIZxc%2FQC0PBTum90MmIjCioHGw%3D&reserved=0</a><br> </div> </span></font></div> </div> </body> </html>