<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=gb2312"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> [AMD Public Use]<o:p></o:p> <o:p> </o:p> Patch3: Acked-by: Feifei Xu <Feifei.Xu@amd.com><o:p></o:p> <o:p> </o:p> <div> Regards,<o:p></o:p> Feifei<o:p></o:p> </div> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Xu, Feifei Sent: 2020年3月6日 9:54 To: Deucher, Alexander <Alexander.Deucher@amd.com>; Alex Deucher <alexdeucher@gmail.com>; amd-gfx list <amd-gfx@lists.freedesktop.org> Cc: Tawfik, Aly <Aly.Tawfik@amd.com> Subject: RE: [PATCH 1/2] drm/amdgpu/display: fix pci revision id fetching<o:p></o:p> </div> </div> <o:p> </o:p> [AMD Public Use]<o:p></o:p> <o:p> </o:p> Patch1, Patch2 are :<o:p></o:p> <o:p> </o:p> <o:p> </o:p> <div> Reviewed-by: Feifei Xu <<a href="mailto:Feifei.Xu@amd.com">Feifei.Xu@amd.com</a>><o:p></o:p> <o:p> </o:p> </div> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>> Sent: 2020年3月6日 0:00 To: Xu, Feifei <<a href="mailto:Feifei.Xu@amd.com">Feifei.Xu@amd.com</a>>; Alex Deucher <<a href="mailto:alexdeucher@gmail.com">alexdeucher@gmail.com</a>>; amd-gfx list <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>> Cc: Tawfik, Aly <<a href="mailto:Aly.Tawfik@amd.com">Aly.Tawfik@amd.com</a>> Subject: Re: [PATCH 1/2] drm/amdgpu/display: fix pci revision id fetching<o:p></o:p> </div> </div> <o:p> </o:p> [AMD Public Use]<o:p></o:p> <o:p> </o:p> <div> <div> Is this for the series, or just this patch? Thanks!<o:p></o:p> </div> <div> <o:p> </o:p> </div> <div> Alex<o:p></o:p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> From: Xu, Feifei <<a href="mailto:Feifei.Xu@amd.com">Feifei.Xu@amd.com</a>> Sent: Thursday, March 5, 2020 12:24 AM To: Alex Deucher <<a href="mailto:alexdeucher@gmail.com">alexdeucher@gmail.com</a>>; amd-gfx list <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>> Cc: Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>>; Tawfik, Aly <<a href="mailto:Aly.Tawfik@amd.com">Aly.Tawfik@amd.com</a>> Subject: RE: [PATCH 1/2] drm/amdgpu/display: fix pci revision id fetching <o:p></o:p> <div> <o:p></o:p> </div> </div> <div> <div> [AMD Official Use Only - Internal Distribution Only] Reviewed-by: Feifei Xu <<a href="mailto:Feifei.Xu@amd.com">Feifei.Xu@amd.com</a>> -----Original Message----- From: amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> On Behalf Of Alex Deucher Sent: 2020年3月5日 13:23 To: amd-gfx list <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>> Cc: Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>>; Tawfik, Aly <<a href="mailto:Aly.Tawfik@amd.com">Aly.Tawfik@amd.com</a>> Subject: Re: [PATCH 1/2] drm/amdgpu/display: fix pci revision id fetching Ping? On Tue, Feb 25, 2020 at 3:32 PM Alex Deucher <<a href="mailto:alexdeucher@gmail.com">alexdeucher@gmail.com</a>> wrote: > > From: Aly-Tawfik <<a href="mailto:altawfik@amd.com">altawfik@amd.com</a>> > > Use the pci revision id rather than the asic silicon revision id. > > Signed-off-by: Aly-Tawfik <<a href="mailto:altawfik@amd.com">altawfik@amd.com</a>> > Signed-off-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com">alexander.deucher@amd.com</a>> > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > index 0c55d44c9d5b..92166150bf9f 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > @@ -902,7 +902,7 @@ static int amdgpu_dm_init(struct amdgpu_device *adev) > > init_data.asic_id.chip_family = adev->family; > > - init_data.asic_id.pci_revision_id = adev->rev_id; > + init_data.asic_id.pci_revision_id = adev->pdev->revision; > init_data.asic_id.hw_internal_rev = adev->external_rev_id; > > init_data.asic_id.vram_width = adev->gmc.vram_width; > -- > 2.24.1 > _______________________________________________ amd-gfx mailing list <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7CFeifei.Xu%40amd.com%7Cdd57c60d9a094f71f0cd08d7c1713880%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637190564935585723&sdata=N79NoA72vZ9zZRYsS92VIY0foejZG6igq57bbx7DIsI%3D&reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7CFeifei.Xu%40amd.com%7Cdd49232261ac4267a33f08d7c0c54ad8%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637189825908683804&sdata=sN%2BGSvrmnz5Qdrf4JR0sFUDWMWyu7tsOh6ZG9lb9I5Y%3D&reserved=0</a><o:p></o:p> </div> </div> </div> </div> </body> </html>