<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> </head> <body> [AMD Official Use Only - Internal Distribution Only] <div> <div dir="auto" style="direction: ltr; margin: 0; padding: 0; font-family: sans-serif; font-size: 11pt; color: black; "> page table BOs share same resv.It should be ok using any of them, root bo resv or bo resv. </div> <div dir="auto" style="direction: ltr; margin: 0; padding: 0; font-family: sans-serif; font-size: 11pt; color: black; "> I forgot to unref bos which cause problems. not good at rebasing... </div> <div dir="auto" style="direction: ltr; margin: 0; padding: 0; font-family: sans-serif; font-size: 11pt; color: black; "> thanks </div> <div dir="auto" style="direction: ltr; margin: 0; padding: 0; font-family: sans-serif; font-size: 11pt; color: black; "> xinhui</div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr">From: Koenig, Christian <Christian.Koenig@amd.com> Sent: Friday, March 13, 2020 9:34:42 PM To: Pan, Xinhui <Xinhui.Pan@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Kuehling, Felix <Felix.Kuehling@amd.com> Subject: Re: [PATCH 1/2] drm//amdgpu: Add job fence to resv conditionally <div> </div> </div> <div class="BodyFragment"> <div class="PlainText">Am 13.03.20 um 12:53 schrieb xinhui pan: > If a job need sync the bo resv, it is likely that bo need the job fence > to sync with others. That won't work because this is the wrong resv object :) You added the fence to the mapped BO and not the page table. No wonder that this doesn't work, Christian. > > Cc: Christian König <christian.koenig@amd.com> > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: Felix Kuehling <Felix.Kuehling@amd.com> > Suggested-by: Christian König <christian.koenig@amd.com> > Signed-off-by: xinhui pan <xinhui.pan@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 5 +++++ > drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 9 +++++++++ > 2 files changed, 14 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h > index b5705fcfc935..ca6021b4200b 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h > @@ -226,6 +226,11 @@ struct amdgpu_vm_update_params { > * @num_dw_left: number of dw left for the IB > */ > unsigned int num_dw_left; > + > + /** > + * @resv: sync the resv and add job fence to it conditionally. > + */ > + struct dma_resv *resv; > }; > > struct amdgpu_vm_update_funcs { > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c > index 4cc7881f438c..0cfac59bff36 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c > @@ -70,6 +70,8 @@ static int amdgpu_vm_sdma_prepare(struct amdgpu_vm_update_params *p, > > p->num_dw_left = ndw; > > + p->resv = resv; > + > if (!resv) > return 0; > > @@ -111,6 +113,13 @@ static int amdgpu_vm_sdma_commit(struct amdgpu_vm_update_params *p, > swap(p->vm->last_delayed, tmp); > dma_fence_put(tmp); > > + /* add job fence to resv. > + * MM notifier path is an exception as we can not grab the > + * resv lock. > + */ > + if (!p->direct && p->resv) > + dma_resv_add_shared_fence(p->resv, f); > + > if (fence && !p->direct) > swap(*fence, f); > dma_fence_put(f); </div> </div> </div> </body> </html>