<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=gb2312"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:ZH-CN">Bye the way: if you want to avoid IB test pending by GPU recover, you can move IB test out of TDR routine, so IB test will execute after GPU scheduler resumed with TDR completed .<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:ZH-CN"><o:p> </o:p></span></p> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:ZH-CN">_____________________________________<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-family:"Calibri",sans-serif;color:black;background:white;mso-fareast-language:ZH-CN">Monk Liu|GPU Virtualization Team |</span><span style="font-family:"Calibri",sans-serif;color:#C82613;border:none windowtext 1.0pt;padding:0in;background:white;mso-fareast-language:ZH-CN">AMD<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:ZH-CN"><img width="80" height="80" style="width:.8333in;height:.8333in" id="Picture_x0020_1" src="cid:image001.png@01D6047D.43DC6A30" alt="sig-cloud-gpu"><o:p></o:p></span></p> </div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:ZH-CN"><o:p> </o:p></span></p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Pan, Xinhui <Xinhui.Pan@amd.com> <br> <b>Sent:</b> Thursday, March 26, 2020 2:02 PM<br> <b>To:</b> amd-gfx@lists.freedesktop.org; Liu, Monk <Monk.Liu@amd.com><br> <b>Cc:</b> Deucher, Alexander <Alexander.Deucher@amd.com>; Kuehling, Felix <Felix.Kuehling@amd.com>; Koenig, Christian <Christian.Koenig@amd.com><br> <b>Subject:</b> Re: [RFC PATCH 0/2] add direct IB pool<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <p style="margin:15.0pt"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#0078D7">[AMD Official Use Only - Internal Distribution Only]<o:p></o:p></span></p> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:11.0pt;font-family:"Arial",sans-serif;color:black">yes, IB test and vram restore will alloc IBs.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Arial",sans-serif;color:black">I hit this issue for quite a long time ago. We test benchmarks on ARM server which is running android.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:11.0pt;font-family:"Arial",sans-serif;color:black">Hunders of processes hit too many issues. Panic and memory corruption everywhere.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:11.0pt;font-family:"Arial",sans-serif;color:black">Now i have a littke time to fix this deadlock.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Arial",sans-serif;color:black">if you want to repro it, set gpu timeout to 50ms</span><span lang="JA" style="font-size:11.0pt;color:black">гм</span><span style="font-size:11.0pt;font-family:"Arial",sans-serif;color:black">then run vulkan,ocl, amdgputest, etc together.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:11.0pt;font-family:"Arial",sans-serif;color:black">I believe you will see more weird issues.<o:p></o:p></span></p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> <p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black"> Liu, Monk <<a href="mailto:Monk.Liu@amd.com">Monk.Liu@amd.com</a>><br> <b>Sent:</b> Thursday, March 26, 2020 1:31:04 PM<br> <b>To:</b> Pan, Xinhui <<a href="mailto:Xinhui.Pan@amd.com">Xinhui.Pan@amd.com</a>>; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>><br> <b>Cc:</b> Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>>; Kuehling, Felix <<a href="mailto:Felix.Kuehling@amd.com">Felix.Kuehling@amd.com</a>>; Pan, Xinhui <<a href="mailto:Xinhui.Pan@amd.com">Xinhui.Pan@amd.com</a>>; Koenig, Christian <<a href="mailto:Christian.Koenig@amd.com">Christian.Koenig@amd.com</a>><br> <b>Subject:</b> RE: [RFC PATCH 0/2] add direct IB pool</span> <o:p></o:p></p> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal"><span style="font-size:11.0pt">That sounds a roughly doable plan to me , although we didn't hit this issue in our virtualization stress test but like a possible issue.<br> <br> >>> So the ring test above got stuck if no ib to alloc.<br> Why there is IB alloc happened in ring test ? I remember there is no IB allocated for ring test, are you referring to IB test ?<br> <br> <br> <br> _____________________________________<br> Monk Liu|GPU Virtualization Team |AMD<br> <br> <br> -----Original Message-----<br> From: amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> On Behalf Of xinhui pan<br> Sent: Thursday, March 26, 2020 10:02 AM<br> To: <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> Cc: Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>>; Kuehling, Felix <<a href="mailto:Felix.Kuehling@amd.com">Felix.Kuehling@amd.com</a>>; Pan, Xinhui <<a href="mailto:Xinhui.Pan@amd.com">Xinhui.Pan@amd.com</a>>; Koenig, Christian <<a href="mailto:Christian.Koenig@amd.com">Christian.Koenig@amd.com</a>><br> Subject: [RFC PATCH 0/2] add direct IB pool<br> <br> druing gpu recovery, we alloc ibs for ring tests to test if recovery succeed or not.<br> <br> As gpu recovery parked the gpu scheduler thread, any pending jobs hold the ib resource has no chance to free. So the ring test above got stuck if no ib to alloc.<br> <br> If we schedule IBs directly in job_submit_direct, we can alloc ibs in the new ib pool. It should have less contention.<br> <br> If the IB could be freed in time, IOW, not depending on any scheduler, nor any other blocking code. It is better to alloc ibs in direct pool.<br> <br> xinhui pan (2):<br> drm/amdgpu: add direct ib pool<br> drm/amdgpu: use new job alloc variation if possible<br> <br> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +<br> drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-<br> drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 12 ++++++++++--<br> drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 8 +++++++-<br> drivers/gpu/drm/amd/amdgpu/amdgpu_job.h | 3 ++-<br> drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c | 2 +-<br> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-<br> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 2 +-<br> drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 4 ++--<br> drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 6 +++---<br> drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 3 ++-<br> drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 4 ++--<br> drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 4 ++--<br> 13 files changed, 35 insertions(+), 18 deletions(-)<br> <br> --<br> 2.17.1<br> <br> _______________________________________________<br> amd-gfx mailing list<br> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cmonk.liu%40amd.com%7C1f5b1a3ba10a452c9de608d7d129b396%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637207850237679644&sdata=cS7S7a8gDmIgyJNbr4qXSPMZTLwKz0W429Z%2F2Zo6gek%3D&reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cmonk.liu%40amd.com%7C1f5b1a3ba10a452c9de608d7d129b396%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637207850237679644&sdata=cS7S7a8gDmIgyJNbr4qXSPMZTLwKz0W429Z%2F2Zo6gek%3D&reserved=0</a><o:p></o:p></span></p> </div> </div> </div> </div> </body> </html>