<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> <p class="msipheadera92e061b" style="margin:0in;margin-bottom:.0001pt"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#0078D7">[AMD Official Use Only - Internal Distribution Only]</span><o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">1,Using the FCLK DPM table to set the MCLK for DPM states consist of<br> three entities:<br> FCLK<br> UCLK<br> MEMCLK<br> All these three clk change together, MEMCLK from FCLK, so use the fclk<br> frequency.<br> 2,we should show the current working clock freqency from clock table metric<br> <br> Change-Id: Ia45f3069fc7ae56db495cb5a3865e2c50c550774<br> Signed-off-by: Yuxian Dai <<a href="mailto:Yuxian.Dai@amd.com">Yuxian.Dai@amd.com</a>><br> ---<br> drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 8 ++++++++<br> drivers/gpu/drm/amd/powerplay/renoir_ppt.h | 2 +-<br> 2 files changed, 9 insertions(+), 1 deletion(-)<br> <br> diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c<br> index 7bf52ecba01d..5c5d3f974532 100644<br> --- a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c<br> +++ b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c<br> @@ -239,6 +239,7 @@ static int renoir_print_clk_levels(struct smu_context *smu,<br> uint32_t cur_value = 0, value = 0, count = 0, min = 0, max = 0;<br> DpmClocks_t *clk_table = smu->smu_table.clocks_table;<br> SmuMetrics_t metrics;<br> + bool cur_value_match_level = false;<br> <br> if (!clk_table || clk_type >= SMU_CLK_COUNT)<br> return -EINVAL;<br> @@ -297,6 +298,13 @@ static int renoir_print_clk_levels(struct smu_context *smu,<br> GET_DPM_CUR_FREQ(clk_table, clk_type, i, value);<br> size += sprintf(buf + size, "%d: %uMhz %s\n", i, value,<br> cur_value == value ? "*" : "");<br> + if(cur_value == value) {<br> + cur_value_match_level = true;<br> + }<br> + }<br> + <br> + if(!cur_value_match_level) {<br> + size += sprintf(buf + size, " %uMhz *\n",cur_value);<br> }<o:p></o:p></p> <div> <p class="MsoNormal">[kevin]:<o:p></o:p></p> </div> <div> <p class="MsoNormal">I have a little suggestion about coding style.<o:p></o:p></p> </div> <div> <p class="MsoNormal"><span style="font-family:"Segoe UI",sans-serif;color:black;background:white">"Do not unnecessarily use braces where a single statement will do."</span><o:p></o:p></p> </div> <div> <p class="MsoNormal"><span style="font-family:"Segoe UI",sans-serif;color:black;background:white">we'd better fix it.</span><o:p></o:p></p> </div> <div> <p class="MsoNormal"><span style="font-family:"Segoe UI",sans-serif;color:black;background:white">thanks.</span><o:p></o:p></p> </div> <div> <ul style="margin-top:0in" type="disc"> <li class="MsoListParagraph" style="margin-left:.25in;mso-list:l1 level1 lfo3">Ok, I will remove it.<o:p></o:p></li></ul> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal"><a href="https://www.kernel.org/doc/html/latest/process/coding-style.html">https://www.kernel.org/doc/html/latest/process/coding-style.html</a><o:p></o:p></p> </div> <div style="margin-top:12.0pt;margin-bottom:12.0pt;min-width: 424px" id="LPBorder_GTaHR0cHM6Ly93d3cua2VybmVsLm9yZy9kb2MvaHRtbC9sYXRlc3QvcHJvY2Vzcy9jb2Rpbmctc3R5bGUuaHRtbA.."> <table class="MsoNormalTable" border="1" cellspacing="3" cellpadding="0" width="100%" style="width:100.0%;border:solid #C8C8C8 1.0pt"> <tbody> <tr> <td width="100%" valign="top" style="width:100.0%;border:none;padding:9.0pt 27.0pt 9.0pt 9.0pt"> <div style="margin-right:6.0pt;margin-bottom:9.0pt" id="LPTitle234871"> <p class="MsoNormal"><span style="font-size:16.0pt;font-family:"Segoe UI Light",sans-serif"><a href="https://www.kernel.org/doc/html/latest/process/coding-style.html" target="_blank"><span style="text-decoration:none">Linux kernel coding style — The Linux Kernel documentation</span></a><o:p></o:p></span></p> </div> <div style="margin-right:6.0pt;margin-bottom:9.0pt;max-height: 100px;overflow:hidden" id="LPDescription234871"> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:#666666">Linux kernel coding style�. This is a short document describing the preferred coding style for the linux kernel. Coding style is very personal, and I won’t force my views on anybody, but this is what goes for anything that I have to be able to maintain, and I’d prefer it for most other things too. Please at least consider the points made here.<o:p></o:p></span></p> </div> <div id="LPMetadata234871"> <p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:#A6A6A6"><a href="http://www.kernel.org">www.kernel.org</a><o:p></o:p></span></p> </div> </td> </tr> </tbody> </table> </div> <div> <p class="MsoNormal" style="box-sizing: border-box"><span style="color:black"> </span><br> return size;<br> diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.h b/drivers/gpu/drm/amd/powerplay/renoir_ppt.h<br> index 2a390ddd37dd..89cd6da118a3 100644<br> --- a/drivers/gpu/drm/amd/powerplay/renoir_ppt.h<br> +++ b/drivers/gpu/drm/amd/powerplay/renoir_ppt.h<br> @@ -37,7 +37,7 @@ extern void renoir_set_ppt_funcs(struct smu_context *smu);<br> freq = table->SocClocks[dpm_level].Freq; \<br> break; \<br> case SMU_MCLK: \<br> - freq = table->MemClocks[dpm_level].Freq; \<br> + freq = table->FClocks[dpm_level].Freq; \<br> break; \<br> case SMU_DCEFCLK: \<br> freq = table->DcfClocks[dpm_level].Freq; \<br> -- <br> 2.17.1<br> <br> _______________________________________________<br> amd-gfx mailing list<br> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7CKevin1.Wang%40amd.com%7Cac64217a79c44e06267008d7d602484e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637213177638342283&sdata=iEt1JzC0wcb7rQ%2F2TWBu7RfJGrChPpt%2Fc2jXPfqjruU%3D&reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7CKevin1.Wang%40amd.com%7Cac64217a79c44e06267008d7d602484e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637213177638342283&sdata=iEt1JzC0wcb7rQ%2F2TWBu7RfJGrChPpt%2Fc2jXPfqjruU%3D&reserved=0</a><o:p></o:p></p> </div> </div> </body> </html>