<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#317100;margin:15pt;" align="Left">
[AMD Public Use]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Does this need to be protected by a asic_type check as well or is just the vbios version enough? Will we have other asics with D360 in the vbios version?<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Alex<br>
</div>
<div id="appendonsend"></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Kent Russell <kent.russell@amd.com><br>
<b>Sent:</b> Friday, April 3, 2020 10:43 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Russell, Kent <Kent.Russell@amd.com><br>
<b>Subject:</b> [PATCH] drm/amdgpu: Re-enable FRU check for most models</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">There are 2 SKUs that do not have the FRU on there, and trying to read<br>
that will cause a hang. For now, check for the gaming SKU until a proper<br>
fix can be implemented. This re-enables serial number reporting for<br>
server cards<br>
<br>
Signed-off-by: Kent Russell <kent.russell@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c | 15 +++++++++++++--<br>
1 file changed, 13 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c<br>
index bfe4259f9508..281bdfd4630a 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c<br>
@@ -31,9 +31,20 @@<br>
<br>
bool is_fru_eeprom_supported(struct amdgpu_device *adev)<br>
{<br>
- /* TODO: Resolve supported ASIC type */<br>
+ struct atom_context *atom_ctx = adev->mode_info.atom_context;<br>
<br>
- return false;<br>
+ if (!atom_ctx)<br>
+ return false;<br>
+<br>
+ /* TODO: Gaming SKUs don't have the FRU EEPROM.<br>
+ * Use this to address hangs on modprobe on gaming SKUs<br>
+ * until a proper solution can be implemented<br>
+ */<br>
+ if (strnstr(atom_ctx->vbios_version, "D360",<br>
+ sizeof(atom_ctx->vbios_version)))<br>
+ return false;<br>
+<br>
+ return true;<br>
}<br>
<br>
int amdgpu_fru_read_eeprom(struct amdgpu_device *adev, uint32_t addrptr,<br>
-- <br>
2.17.1<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Calexander.deucher%40amd.com%7C97d3aa4c34464592264508d7d7dd69a0%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637215218317453581&sdata=ABysYVGVyaYWc2HuebwGNdPbOkvC%2Fmmduk4EMROoDfw%3D&reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Calexander.deucher%40amd.com%7C97d3aa4c34464592264508d7d7dd69a0%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637215218317453581&sdata=ABysYVGVyaYWc2HuebwGNdPbOkvC%2Fmmduk4EMROoDfw%3D&reserved=0</a><br>
</div>
</span></font></div>
</div>
</body>
</html>