<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0078D7;margin:15pt;" align="Left">
[AMD Official Use Only - Internal Distribution Only]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks Alex!</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I send it again, please help review.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
BR,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Rico</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Alex Deucher <alexdeucher@gmail.com><br>
<b>Sent:</b> Friday, April 3, 2020 22:53<br>
<b>To:</b> Yin, Tianci (Rico) <Tianci.Yin@amd.com><br>
<b>Cc:</b> amd-gfx list <amd-gfx@lists.freedesktop.org>; Deucher, Alexander <Alexander.Deucher@amd.com>; Xu, Feifei <Feifei.Xu@amd.com>; Zhang, Hawking <Hawking.Zhang@amd.com>; Hesik, Christopher <Christopher.Hesik@amd.com><br>
<b>Subject:</b> Re: [PATCH] drm/amdgpu: add SPM golden settings for Navi10</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On Fri, Apr 3, 2020 at 1:30 AM Tianci Yin <tianci.yin@amd.com> wrote:<br>
><br>
> From: "Tianci.Yin" <tianci.yin@amd.com><br>
><br>
> Add RLC_SPM golden settings<br>
><br>
> Change-Id: I616e127171293d915cb3a05dee02f51cec8d8f6f<br>
> Signed-off-by: Tianci.Yin <tianci.yin@amd.com><br>
> ---<br>
> drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 9 +<br>
> .../gpu/drm/amd/amdgpu/golden_gc_spm_10_1_0.h | 1058 +++++++++++++++++<br>
> 2 files changed, 1067 insertions(+)<br>
> create mode 100644 drivers/gpu/drm/amd/amdgpu/golden_gc_spm_10_1_0.h<br>
><br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c<br>
> index 70edbbf84338..7c96a894ad37 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c<br>
> @@ -48,6 +48,7 @@<br>
> #include "v10_structs.h"<br>
> #include "gfx_v10_0.h"<br>
> #include "nbio_v2_3.h"<br>
> +#include "golden_gc_spm_10_1_0.h"<br>
<br>
Can we just include the table directly in this file instead of a<br>
separate header? One more comment below.<br>
<br>
><br>
> /**<br>
> * Navi10 has two graphic rings to share each graphic pipe.<br>
> @@ -138,6 +139,11 @@ static const struct soc15_reg_golden golden_settings_gc_10_0_nv10[] =<br>
> /* Pending on emulation bring up */<br>
> };<br>
><br>
> +static const struct soc15_reg_golden golden_settings_gc_rlc_spm_10_0_nv10[] =<br>
> +{<br>
> + GOLDEN_GC_SPM_10_1_0<br>
> +};<br>
> +<br>
> static const struct soc15_reg_golden golden_settings_gc_10_1_1[] =<br>
> {<br>
> SOC15_REG_GOLDEN_VALUE(GC, 0, mmCB_HW_CONTROL_4, 0xffffffff, 0x003c0014),<br>
> @@ -388,6 +394,9 @@ static void gfx_v10_0_init_golden_registers(struct amdgpu_device *adev)<br>
> soc15_program_register_sequence(adev,<br>
> golden_settings_gc_10_0_nv10,<br>
> (const u32)ARRAY_SIZE(golden_settings_gc_10_0_nv10));<br>
> + soc15_program_register_sequence(adev,<br>
> + golden_settings_gc_rlc_spm_10_0_nv10,<br>
> + (const u32)ARRAY_SIZE(golden_settings_gc_rlc_spm_10_0_nv10));<br>
> break;<br>
> case CHIP_NAVI14:<br>
> soc15_program_register_sequence(adev,<br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/golden_gc_spm_10_1_0.h b/drivers/gpu/drm/amd/amdgpu/golden_gc_spm_10_1_0.h<br>
> new file mode 100644<br>
> index 000000000000..e65af4a6fcdd<br>
> --- /dev/null<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/golden_gc_spm_10_1_0.h<br>
<br>
This file is missing a license.<br>
<br>
Alex<br>
</div>
</span></font></div>
</div>
</body>
</html>