<html><head> <meta http-equiv="Content-Type" content="text/html; charset=Windows-1252"> </head> <body> <p><br> </p> <div class="moz-cite-prefix">Am 2020-04-08 um 9:27 a.m. schrieb Deucher, Alexander:<br> </div> <blockquote type="cite" cite="mid:MN2PR12MB4488FA323BA0F10D1D894BFBF7C00@MN2PR12MB4488.namprd12.prod.outlook.com"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> <p style="font-family:Arial;font-size:10pt;color:#317100;margin:15pt;" align="Left"> [AMD Public Use]<br> </p> <br> <div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Acked-by: Alex Deucher <a class="moz-txt-link-rfc2396E" href="mailto:alexander.deucher@amd.com"><alexander.deucher@amd.com></a><br> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> amd-gfx <a class="moz-txt-link-rfc2396E" href="mailto:amd-gfx-bounces@lists.freedesktop.org"><amd-gfx-bounces@lists.freedesktop.org></a> on behalf of Jack Zhang <a class="moz-txt-link-rfc2396E" href="mailto:Jack.Zhang1@amd.com"><Jack.Zhang1@amd.com></a><br> <b>Sent:</b> Wednesday, April 8, 2020 6:33 AM<br> <b>To:</b> <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <a class="moz-txt-link-rfc2396E" href="mailto:amd-gfx@lists.freedesktop.org"><amd-gfx@lists.freedesktop.org></a><br> <b>Cc:</b> Zhang, Jack (Jian) <a class="moz-txt-link-rfc2396E" href="mailto:Jack.Zhang1@amd.com"><Jack.Zhang1@amd.com></a><br> <b>Subject:</b> [PATCH] drm/amdgpu/sriov move program of sq_config to PF</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">Since SQ_CONFIG will influence performance behavior, it's<br> unsafe to program in VF. Therefore, program of SQ_CONFIG<br> need to be moved to PF under siov. Skip it here in guest driver.<br> </div> </span></font></div> </div> </blockquote> <p>We'll need to change this register when the debugger enables address watch. If this setting is global across VFs, it will be a problem. Can this be saved and restored on world-switch so that each VF has its own setting? Then you could allow changing it in the VF.</p> <p><br> </p> <p>Otherwise we will not be able to enable the address watch feature in the debugger under virtualization.</p> <p><br> </p> <p>Regards,<br> Felix<br> </p> <p><br> </p> <blockquote type="cite" cite="mid:MN2PR12MB4488FA323BA0F10D1D894BFBF7C00@MN2PR12MB4488.namprd12.prod.outlook.com"> <div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText"> <br> Signed-off-by: Jack Zhang <a class="moz-txt-link-rfc2396E" href="mailto:Jack.Zhang1@amd.com"><Jack.Zhang1@amd.com></a><br> ---<br> drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 3 ++-<br> 1 file changed, 2 insertions(+), 1 deletion(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c<br> index 2d56b067..9bb89f2 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c<br> @@ -2575,7 +2575,8 @@ static void gfx_v9_0_constants_init(struct amdgpu_device *adev)<br> <br> gfx_v9_0_init_compute_vmid(adev);<br> gfx_v9_0_init_gds_vmid(adev);<br> - gfx_v9_0_init_sq_config(adev);<br> + if (!amdgpu_sriov_vf(adev))<br> + gfx_v9_0_init_sq_config(adev);<br> }<br> <br> static void gfx_v9_0_wait_for_rlc_serdes(struct amdgpu_device *adev)<br> -- <br> 2.7.4<br> <br> _______________________________________________<br> amd-gfx mailing list<br> <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cfelix.kuehling%40amd.com%7Cda6c5ebaaf6c4f1619f108d7dbc08d98%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637219493056058157&sdata=MAhOm9usqEEnTCO1XMxteWqFHMnlOeDG0V93sA%2BhE%2Bo%3D&reserved=0" originalsrc="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" shash="LMSc7q8PYLxK4VsGcI6XfAZQtG7rlmiyHEpcW+bvBV6Uv3wvMnT2iqo8SBKx4q6SWK2ggBvSyYJkp0yNstoD1lCG9pngWlwgnuQE8pgnwscW0ZvEmt8gFATrkA/NGHr3jjgQT902LStCeGvMk8AEEn6XDq6h/91O9Hahv6zASeg=" moz-do-not-send="true">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Calexander.deucher%40amd.com%7C38604ab03f8142a547f808d7dba854d4%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637219388971131150&sdata=gBSa%2BchPmFMSaTgAq8z5Sabs3G6ARuHN8wAPSi%2FoJqA%3D&reserved=0</a><br> </div> </span></font></div> </div> <br> <fieldset class="mimeAttachmentHeader"></fieldset> <pre class="moz-quote-pre" wrap="">_______________________________________________ amd-gfx mailing list <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cfelix.kuehling%40amd.com%7Cda6c5ebaaf6c4f1619f108d7dbc08d98%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637219493056078139&sdata=HCjruFYRNoF4bWVTCgwuxqk0h3dnxP%2FJBsq6%2Flr%2FFXw%3D&reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cfelix.kuehling%40amd.com%7Cda6c5ebaaf6c4f1619f108d7dbc08d98%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637219493056078139&sdata=HCjruFYRNoF4bWVTCgwuxqk0h3dnxP%2FJBsq6%2Flr%2FFXw%3D&reserved=0</a> </pre> </blockquote> </body> </html>