<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> </head> <body> <div dir="auto" style="direction: ltr; margin: 0; padding: 0; font-family: sans-serif; font-size: 11pt; color: black; "> Prike </div> <div dir="auto" style="direction: ltr; margin: 0; padding: 0; font-family: sans-serif; font-size: 11pt; color: black; "> I hit this issue too. reboot hung with my vega10. it is ok with navi10. </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr">From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Liang, Prike <Prike.Liang@amd.com> Sent: Sunday, April 12, 2020 11:49:39 AM To: Johannes Hirte <johannes.hirte@datenkhaos.de> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Ray <Ray.Huang@amd.com>; Quan, Evan <Evan.Quan@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org> Subject: RE: [PATCH v2] drm/amdgpu: fix gfx hang during suspend with video playback (v2) <div> </div> </div> <div class="BodyFragment"> <div class="PlainText">Thanks update and verify. Could you give more detail information and error log message about you observed issue? Thanks, Prike > -----Original Message----- > From: Johannes Hirte <johannes.hirte@datenkhaos.de> > Sent: Sunday, April 12, 2020 7:56 AM > To: Liang, Prike <Prike.Liang@amd.com> > Cc: amd-gfx@lists.freedesktop.org; Deucher, Alexander > <Alexander.Deucher@amd.com>; Huang, Ray <Ray.Huang@amd.com>; > Quan, Evan <Evan.Quan@amd.com> > Subject: Re: [PATCH v2] drm/amdgpu: fix gfx hang during suspend with video > playback (v2) > > On 2020 Apr 07, Prike Liang wrote: > > The system will be hang up during S3 suspend because of SMU is pending > > for GC not respose the register CP_HQD_ACTIVE access request.This > > issue root cause of accessing the GC register under enter GFX CGGPG > > and can be fixed by disable GFX CGPG before perform suspend. > > > > v2: Use disable the GFX CGPG instead of RLC safe mode guard. > > > > Signed-off-by: Prike Liang <Prike.Liang@amd.com> > > Tested-by: Mengbing Wang <Mengbing.Wang@amd.com> > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > > b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > > index 2e1f955..bf8735b 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > > @@ -2440,8 +2440,6 @@ static int > > amdgpu_device_ip_suspend_phase1(struct amdgpu_device *adev) { > > int i, r; > > > > - amdgpu_device_set_pg_state(adev, AMD_PG_STATE_UNGATE); > > - amdgpu_device_set_cg_state(adev, AMD_CG_STATE_UNGATE); > > > > for (i = adev->num_ip_blocks - 1; i >= 0; i--) { > > if (!adev->ip_blocks[i].status.valid) > > @@ -3470,6 +3468,9 @@ int amdgpu_device_suspend(struct drm_device > *dev, bool fbcon) > > } > > } > > > > + amdgpu_device_set_pg_state(adev, AMD_PG_STATE_UNGATE); > > + amdgpu_device_set_cg_state(adev, AMD_CG_STATE_UNGATE); > > + > > amdgpu_amdkfd_suspend(adev, !fbcon); > > > > amdgpu_ras_suspend(adev); > > > This breaks shutdown/reboot on my system (Dell latitude 5495). > > -- > Regards, > Johannes Hirte _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cxinhui.pan%40amd.com%7Cde6e0578174940b5f29808d7de948b88%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637222601969843248&sdata=quWGElw%2Fo70VJibuZ7%2BzS%2FcHH2OHSDB%2B5uaFPQUf2Os%3D&reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cxinhui.pan%40amd.com%7Cde6e0578174940b5f29808d7de948b88%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637222601969843248&sdata=quWGElw%2Fo70VJibuZ7%2BzS%2FcHH2OHSDB%2B5uaFPQUf2Os%3D&reserved=0</a> </div> </div> </body> </html>