<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> Could you share the PCI sub revision and I try check the issue on the Vega10(1002:687f) but can’t find the <o:p></o:p> reboot hang up.<o:p></o:p> <o:p> </o:p> Thanks,<o:p></o:p> Prike<o:p></o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Pan, Xinhui <Xinhui.Pan@amd.com> Sent: Sunday, April 12, 2020 2:58 PM To: Johannes Hirte <johannes.hirte@datenkhaos.de>; Liang, Prike <Prike.Liang@amd.com> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Ray <Ray.Huang@amd.com>; Quan, Evan <Evan.Quan@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH v2] drm/amdgpu: fix gfx hang during suspend with video playback (v2)<o:p></o:p> </div> </div> <o:p> </o:p> <div> Prike<o:p></o:p> </div> <div> I hit this issue too. reboot hung with my vega10. it is ok with navi10.<o:p></o:p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="1" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> From: amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of Liang, Prike <<a href="mailto:Prike.Liang@amd.com">Prike.Liang@amd.com</a>> Sent: Sunday, April 12, 2020 11:49:39 AM To: Johannes Hirte <<a href="mailto:johannes.hirte@datenkhaos.de">johannes.hirte@datenkhaos.de</a>> Cc: Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>>; Huang, Ray <<a href="mailto:Ray.Huang@amd.com">Ray.Huang@amd.com</a>>; Quan, Evan <<a href="mailto:Evan.Quan@amd.com">Evan.Quan@amd.com</a>>; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>> Subject: RE: [PATCH v2] drm/amdgpu: fix gfx hang during suspend with video playback (v2) <o:p></o:p> <div> <o:p></o:p> </div> </div> <div> <div> Thanks update and verify. Could you give more detail information and error log message about you observed issue? Thanks, Prike > -----Original Message----- > From: Johannes Hirte <<a href="mailto:johannes.hirte@datenkhaos.de">johannes.hirte@datenkhaos.de</a>> > Sent: Sunday, April 12, 2020 7:56 AM > To: Liang, Prike <<a href="mailto:Prike.Liang@amd.com">Prike.Liang@amd.com</a>> > Cc: <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>; Deucher, Alexander > <<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>>; Huang, Ray <<a href="mailto:Ray.Huang@amd.com">Ray.Huang@amd.com</a>>; > Quan, Evan <<a href="mailto:Evan.Quan@amd.com">Evan.Quan@amd.com</a>> > Subject: Re: [PATCH v2] drm/amdgpu: fix gfx hang during suspend with video > playback (v2) > > On 2020 Apr 07, Prike Liang wrote: > > The system will be hang up during S3 suspend because of SMU is pending > > for GC not respose the register CP_HQD_ACTIVE access request.This > > issue root cause of accessing the GC register under enter GFX CGGPG > > and can be fixed by disable GFX CGPG before perform suspend. > > > > v2: Use disable the GFX CGPG instead of RLC safe mode guard. > > > > Signed-off-by: Prike Liang <<a href="mailto:Prike.Liang@amd.com">Prike.Liang@amd.com</a>> > > Tested-by: Mengbing Wang <<a href="mailto:Mengbing.Wang@amd.com">Mengbing.Wang@amd.com</a>> > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > > b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > > index 2e1f955..bf8735b 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > > @@ -2440,8 +2440,6 @@ static int > > amdgpu_device_ip_suspend_phase1(struct amdgpu_device *adev) { > > int i, r; > > > > - amdgpu_device_set_pg_state(adev, AMD_PG_STATE_UNGATE); > > - amdgpu_device_set_cg_state(adev, AMD_CG_STATE_UNGATE); > > > > for (i = adev->num_ip_blocks - 1; i >= 0; i--) { > > if (!adev->ip_blocks[i].status.valid) > > @@ -3470,6 +3468,9 @@ int amdgpu_device_suspend(struct drm_device > *dev, bool fbcon) > > } > > } > > > > + amdgpu_device_set_pg_state(adev, AMD_PG_STATE_UNGATE); > > + amdgpu_device_set_cg_state(adev, AMD_CG_STATE_UNGATE); > > + > > amdgpu_amdkfd_suspend(adev, !fbcon); > > > > amdgpu_ras_suspend(adev); > > > This breaks shutdown/reboot on my system (Dell latitude 5495). > > -- > Regards, > Johannes Hirte _______________________________________________ amd-gfx mailing list <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cxinhui.pan%40amd.com%7Cde6e0578174940b5f29808d7de948b88%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637222601969843248&sdata=quWGElw%2Fo70VJibuZ7%2BzS%2FcHH2OHSDB%2B5uaFPQUf2Os%3D&reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cxinhui.pan%40amd.com%7Cde6e0578174940b5f29808d7de948b88%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637222601969843248&sdata=quWGElw%2Fo70VJibuZ7%2BzS%2FcHH2OHSDB%2B5uaFPQUf2Os%3D&reserved=0</a><o:p></o:p> </div> </div> </div> </div> </body> </html>