<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0078D7;margin:15pt;" align="Left">
[AMD Official Use Only - Internal Distribution Only]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="appendonsend"></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Christian König <ckoenig.leichtzumerken@gmail.com><br>
<b>Sent:</b> Monday, April 20, 2020 11:45 PM<br>
<b>To:</b> Wang, Kevin(Yang) <Kevin1.Wang@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com><br>
<b>Subject:</b> Re: [PATCH] drm/amdgpu: clean up unused variable about ring lru</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">Am 20.04.20 um 17:27 schrieb Kevin Wang:<br>
> clean up unused variable:<br>
> 1. ring_lru_list<br>
> 2. ring_lru_list_lock<br>
><br>
> related-commit:<br>
> drm/amdgpu: remove ring lru handling<br>
><br>
> Signed-off-by: Kevin Wang <kevin1.wang@amd.com><br>
<br>
Reviewed-by: Christian König <christian.koenig@amd.com><br>
<br>
Found by accident or used some tool? I'm asking because I'm pretty sure <br>
we have more like those.<br>
<br>
Thanks,<br>
Christian.<br>
<br>
[kevin]:</div>
<div class="PlainText"><span>I found it when I read the driver source code, and then I looked at the git history.</span></div>
<div class="PlainText"><span>no tools to help.</span></div>
<div class="PlainText"><span><br>
</span></div>
<div class="PlainText"><span>Best Regards,</span></div>
<div class="PlainText"><span>Kevin<br>
</span>
<div><br>
</div>
<span></span><br>
> ---<br>
> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 ---<br>
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---<br>
> 2 files changed, 6 deletions(-)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h<br>
> index 94dff899248d..e8ab3dde6a66 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h<br>
> @@ -953,9 +953,6 @@ struct amdgpu_device {<br>
> /* link all shadow bo */<br>
> struct list_head shadow_list;<br>
> struct mutex shadow_list_lock;<br>
> - /* keep an lru list of rings by HW IP */<br>
> - struct list_head ring_lru_list;<br>
> - spinlock_t ring_lru_list_lock;<br>
> <br>
> /* record hw reset is performed */<br>
> bool has_hw_reset;<br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br>
> index 71ea56e220ae..38eb736091d0 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br>
> @@ -2990,9 +2990,6 @@ int amdgpu_device_init(struct amdgpu_device *adev,<br>
> INIT_LIST_HEAD(&adev->shadow_list);<br>
> mutex_init(&adev->shadow_list_lock);<br>
> <br>
> - INIT_LIST_HEAD(&adev->ring_lru_list);<br>
> - spin_lock_init(&adev->ring_lru_list_lock);<br>
> -<br>
> INIT_DELAYED_WORK(&adev->delayed_init_work,<br>
> amdgpu_device_delayed_init_work_handler);<br>
> INIT_DELAYED_WORK(&adev->gfx.gfx_off_delay_work,<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>