<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Thanks for that explanation. I
suspected that there was a good reason to have that in the kernel,
but couldn't find one.<br>
<br>
In this case the patch is Reviewed-by: Christian König
<a class="moz-txt-link-rfc2396E" href="mailto:christian.koenig@amd.com"><christian.koenig@amd.com></a><br>
<br>
We should probably add this explanation as comment to the flag as
well.<br>
<br>
Thanks,<br>
Christian.<br>
<br>
Am 26.04.20 um 02:43 schrieb Marek Olšák:<br>
</div>
<blockquote type="cite"
cite="mid:CAAxE2A6Hgnq_zBjQQoa51S7KfVzddjndRGjrJYtjY7v9+vuwDw@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="auto">It was merged into amd-staging-drm-next.
<div dir="auto"><br>
</div>
<div dir="auto">I'm not absolutely sure, but I think we need to
invalidate before IBs if an IB is cached in L2 and the CPU has
updated it. It can only be cached in L2 if something other
than CP has read it or written to it without invalidation. CP
reads don't cache it but they can hit the cache if it's
already cached.</div>
<div dir="auto"><br>
</div>
<div dir="auto">For CE, we need to invalidate before the IB in
the kernel, because CE IBs can't do cache invalidations IIRC.
This is the number one reason for merging the already pushed
commits.</div>
<div dir="auto"><br>
</div>
<div dir="auto">Marek</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Sat., Apr. 25, 2020, 11:03
Christian König, <<a
href="mailto:ckoenig.leichtzumerken@gmail.com"
moz-do-not-send="true">ckoenig.leichtzumerken@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div>Was that patch set actually merged upstream? My last
status is that we couldn't find a reason why we need to do
this in the kernel.<br>
<br>
Christian.<br>
<br>
Am 25.04.20 um 10:52 schrieb Marek Olšák:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>This was missed.</div>
<div><br>
</div>
<div>Marek<br>
</div>
</div>
<br>
<fieldset></fieldset>
<pre>_______________________________________________
amd-gfx mailing list
<a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank" rel="noreferrer" moz-do-not-send="true">amd-gfx@lists.freedesktop.org</a>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank" rel="noreferrer" moz-do-not-send="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a>
</pre>
</blockquote>
<br>
</div>
</blockquote>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
amd-gfx mailing list
<a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a>
</pre>
</blockquote>
<br>
</body>
</html>