<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0078D7;margin:15pt;" align="Left">
[AMD Official Use Only - Internal Distribution Only]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Do we have open source code UMD code which uses this?</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Alex<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Christian König <ckoenig.leichtzumerken@gmail.com><br>
<b>Sent:</b> Sunday, April 26, 2020 4:55 AM<br>
<b>To:</b> Marek Olák <maraeo@gmail.com>; Koenig, Christian <Christian.Koenig@amd.com><br>
<b>Cc:</b> Deucher, Alexander <Alexander.Deucher@amd.com>; amd-gfx mailing list <amd-gfx@lists.freedesktop.org><br>
<b>Subject:</b> Re: drm/amdgpu: apply AMDGPU_IB_FLAG_EMIT_MEM_SYNC to compute IBs too</font>
<div> </div>
</div>
<div style="background-color:#FFFFFF">
<div class="x_moz-cite-prefix">Thanks for that explanation. I suspected that there was a good reason to have that in the kernel, but couldn't find one.<br>
<br>
In this case the patch is Reviewed-by: Christian König <a class="x_moz-txt-link-rfc2396E" href="mailto:christian.koenig@amd.com">
<christian.koenig@amd.com></a><br>
<br>
We should probably add this explanation as comment to the flag as well.<br>
<br>
Thanks,<br>
Christian.<br>
<br>
Am 26.04.20 um 02:43 schrieb Marek Olák:<br>
</div>
<blockquote type="cite">
<div dir="auto">It was merged into amd-staging-drm-next.
<div dir="auto"><br>
</div>
<div dir="auto">I'm not absolutely sure, but I think we need to invalidate before IBs if an IB is cached in L2 and the CPU has updated it. It can only be cached in L2 if something other than CP has read it or written to it without invalidation. CP reads don't
cache it but they can hit the cache if it's already cached.</div>
<div dir="auto"><br>
</div>
<div dir="auto">For CE, we need to invalidate before the IB in the kernel, because CE IBs can't do cache invalidations IIRC. This is the number one reason for merging the already pushed commits.</div>
<div dir="auto"><br>
</div>
<div dir="auto">Marek</div>
</div>
<br>
<div class="x_gmail_quote">
<div dir="ltr" class="x_gmail_attr">On Sat., Apr. 25, 2020, 11:03 Christian König, <<a href="mailto:ckoenig.leichtzumerken@gmail.com">ckoenig.leichtzumerken@gmail.com</a>> wrote:<br>
</div>
<blockquote class="x_gmail_quote" style="margin:0 0 0
.8ex; border-left:1px #ccc solid; padding-left:1ex">
<div bgcolor="#FFFFFF">
<div>Was that patch set actually merged upstream? My last status is that we couldn't find a reason why we need to do this in the kernel.<br>
<br>
Christian.<br>
<br>
Am 25.04.20 um 10:52 schrieb Marek Olák:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>This was missed.</div>
<div><br>
</div>
<div>Marek<br>
</div>
</div>
<br>
<fieldset></fieldset>
<pre>_______________________________________________
amd-gfx mailing list
<a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank" rel="noreferrer">amd-gfx@lists.freedesktop.org</a>
<a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7CAlexander.Deucher%40amd.com%7C6b35f61512d34bf2dc8b08d7e9bfa1a6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637234881577782939&sdata=%2B95wpbjY3Q675FaX9iH1BNIFyEz5jpN4PzjEOOpIu9Q%3D&reserved=0" originalsrc="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" shash="qFDNJ6J+Ha3DqF45+RVY44xxqdH6Z4eu59lTx1cfjRU8LXDoq2uEGKp1n6Dc25g5mKKrSdES7WM02hsv0fiyWsbUfeKg2toJcxHheSdz1N44wTjU9rkTCfF+nmggZ+X+/JOm64Z0KpWPFk2fu8IGjE3KRxxLPdgdyZRUgu6oWmg=" target="_blank" rel="noreferrer">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a>
</pre>
</blockquote>
<br>
</div>
</blockquote>
</div>
<br>
<fieldset class="x_mimeAttachmentHeader"></fieldset>
<pre class="x_moz-quote-pre">_______________________________________________
amd-gfx mailing list
<a class="x_moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>
<a class="x_moz-txt-link-freetext" href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7CAlexander.Deucher%40amd.com%7C6b35f61512d34bf2dc8b08d7e9bfa1a6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637234881577782939&sdata=%2B95wpbjY3Q675FaX9iH1BNIFyEz5jpN4PzjEOOpIu9Q%3D&reserved=0" originalsrc="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" shash="qFDNJ6J+Ha3DqF45+RVY44xxqdH6Z4eu59lTx1cfjRU8LXDoq2uEGKp1n6Dc25g5mKKrSdES7WM02hsv0fiyWsbUfeKg2toJcxHheSdz1N44wTjU9rkTCfF+nmggZ+X+/JOm64Z0KpWPFk2fu8IGjE3KRxxLPdgdyZRUgu6oWmg=">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a>
</pre>
</blockquote>
<br>
</div>
</div>
</body>
</html>