<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p>Yes, same question.</p>
<p>In fact, PAL cmd stream has itself Relase/Acquire packets. That
we use the flag is per your request.</p>
<p>-David<br>
</p>
<div class="moz-cite-prefix">在 2020/4/27 22:53, Christian König 写道:<br>
</div>
<blockquote type="cite" cite="mid:217db438-608d-d28c-6678-4173a6291d8b@gmail.com">
<div class="moz-cite-prefix">Yeah, but is Mesa going to use it?<br>
<br>
Christian.<br>
<br>
Am 27.04.20 um 15:54 schrieb Marek Olšák:<br>
</div>
<blockquote type="cite" cite="mid:CAAxE2A50b_+oX9wmF2D6LZs9GvG9Rhug8AQU40aeDbMDm_kFqw@mail.gmail.com">
<div dir="ltr">
<div>PAL requested it and they are going to use it. (it looks
like they have to use it for correctness)<br>
</div>
<div><br>
</div>
<div>Marek<br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Mon, Apr 27, 2020 at 9:02
AM Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com" moz-do-not-send="true">Alexander.Deucher@amd.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:rgb(0,120,215);margin:15pt" align="Left"> [AMD Official Use Only - Internal
Distribution Only]<br>
</p>
<br>
<div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">Do
we have open source code UMD code which uses this?</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)"><br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">Alex<br>
</div>
<hr style="display:inline-block;width:98%">
<div id="gmail-m_-4239586701017450887divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri,
sans-serif" color="#000000"><b>From:</b> Christian
König <<a href="mailto:ckoenig.leichtzumerken@gmail.com" target="_blank" moz-do-not-send="true">ckoenig.leichtzumerken@gmail.com</a>><br>
<b>Sent:</b> Sunday, April 26, 2020 4:55 AM<br>
<b>To:</b> Marek Olšák <<a href="mailto:maraeo@gmail.com" target="_blank" moz-do-not-send="true">maraeo@gmail.com</a>>;
Koenig, Christian <<a href="mailto:Christian.Koenig@amd.com" target="_blank" moz-do-not-send="true">Christian.Koenig@amd.com</a>><br>
<b>Cc:</b> Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com" target="_blank" moz-do-not-send="true">Alexander.Deucher@amd.com</a>>;
amd-gfx mailing list <<a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank" moz-do-not-send="true">amd-gfx@lists.freedesktop.org</a>><br>
<b>Subject:</b> Re: drm/amdgpu: apply
AMDGPU_IB_FLAG_EMIT_MEM_SYNC to compute IBs too</font>
<div> </div>
</div>
<div style="background-color:rgb(255,255,255)">
<div>Thanks for that explanation. I suspected that
there was a good reason to have that in the kernel,
but couldn't find one.<br>
<br>
In this case the patch is Reviewed-by: Christian
König <a href="mailto:christian.koenig@amd.com" target="_blank" moz-do-not-send="true">
<christian.koenig@amd.com></a><br>
<br>
We should probably add this explanation as comment
to the flag as well.<br>
<br>
Thanks,<br>
Christian.<br>
<br>
Am 26.04.20 um 02:43 schrieb Marek Olšák:<br>
</div>
<blockquote type="cite">
<div dir="auto">It was merged into
amd-staging-drm-next.
<div dir="auto"><br>
</div>
<div dir="auto">I'm not absolutely sure, but I
think we need to invalidate before IBs if an IB
is cached in L2 and the CPU has updated it. It
can only be cached in L2 if something other than
CP has read it or written to it without
invalidation. CP reads don't cache it but they
can hit the cache if it's already cached.</div>
<div dir="auto"><br>
</div>
<div dir="auto">For CE, we need to invalidate
before the IB in the kernel, because CE IBs
can't do cache invalidations IIRC. This is the
number one reason for merging the already pushed
commits.</div>
<div dir="auto"><br>
</div>
<div dir="auto">Marek</div>
</div>
<br>
<div>
<div dir="ltr">On Sat., Apr. 25, 2020, 11:03
Christian König, <<a href="mailto:ckoenig.leichtzumerken@gmail.com" target="_blank" moz-do-not-send="true">ckoenig.leichtzumerken@gmail.com</a>>
wrote:<br>
</div>
<blockquote style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF">
<div>Was that patch set actually merged
upstream? My last status is that we couldn't
find a reason why we need to do this in the
kernel.<br>
<br>
Christian.<br>
<br>
Am 25.04.20 um 10:52 schrieb Marek Olšák:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>This was missed.</div>
<div><br>
</div>
<div>Marek<br>
</div>
</div>
<br>
<fieldset></fieldset>
<pre>_______________________________________________
amd-gfx mailing list
<a href="mailto:amd-gfx@lists.freedesktop.org" rel="noreferrer" target="_blank" moz-do-not-send="true">amd-gfx@lists.freedesktop.org</a>
<a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cdavid1.zhou%40amd.com%7Ced56cca1a5214cf9132808d7eabac6d9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637235960880865820&sdata=1eMdG%2Fr07okHFC%2F%2B3Oz4mg6dAvnd%2FULM6ucEoy7xXDc%3D&reserved=0" originalsrc="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" shash="bQ6LZdwdzzCwNV2EqXiQfAcyvdzjXbTYyHK64lz3mRJBKJbIZm0xDdDeFJlNNzp1qVON7LzcvTP4A85Du/h4jY2a3b/ejhQmLP2Abe2GC+0wNmj2UEKjF2tm6GyA09NNgscey+Esqrhnaq1NpxwexH6ZRUJ+7sEgmuFb2J9LPus=" rel="noreferrer" target="_blank" moz-do-not-send="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a>
</pre>
</blockquote>
<br>
</div>
</blockquote>
</div>
<br>
<fieldset></fieldset>
<pre>_______________________________________________
amd-gfx mailing list
<a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank" moz-do-not-send="true">amd-gfx@lists.freedesktop.org</a>
<a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cdavid1.zhou%40amd.com%7Ced56cca1a5214cf9132808d7eabac6d9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637235960880875773&sdata=8IuVdWV7WS%2BZR60H8B9rWug64%2Bb7xnEUOucMzOlr1wY%3D&reserved=0" originalsrc="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" shash="vB2eCpZvtmS3gxgkCBI0szHocIrkxYjohPfqzIqRT6MjSPKmZ72B6d6zznHqsia1oUsaf45ySo6UZLiiVkU6FMstjas5dx4QruWuD0F8JGj90K7T7EsN7btMYzZFdPvMqmA/iQS907a3sOR2pJJCFxcuXjcR0M/mqvyb5fPT33c=" target="_blank" moz-do-not-send="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a>
</pre>
</blockquote>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
amd-gfx mailing list
<a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org" moz-do-not-send="true">amd-gfx@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cdavid1.zhou%40amd.com%7Ced56cca1a5214cf9132808d7eabac6d9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637235960880875773&sdata=8IuVdWV7WS%2BZR60H8B9rWug64%2Bb7xnEUOucMzOlr1wY%3D&reserved=0" originalsrc="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" shash="vB2eCpZvtmS3gxgkCBI0szHocIrkxYjohPfqzIqRT6MjSPKmZ72B6d6zznHqsia1oUsaf45ySo6UZLiiVkU6FMstjas5dx4QruWuD0F8JGj90K7T7EsN7btMYzZFdPvMqmA/iQS907a3sOR2pJJCFxcuXjcR0M/mqvyb5fPT33c=" moz-do-not-send="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a>
</pre>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
amd-gfx mailing list
<a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cdavid1.zhou%40amd.com%7Ced56cca1a5214cf9132808d7eabac6d9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637235960880895689&sdata=6p%2BAuZXHiUrO8wElftOqsJzHF%2BVLe5TMDIF%2BbJNV6ac%3D&reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cdavid1.zhou%40amd.com%7Ced56cca1a5214cf9132808d7eabac6d9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637235960880895689&sdata=6p%2BAuZXHiUrO8wElftOqsJzHF%2BVLe5TMDIF%2BbJNV6ac%3D&reserved=0</a>
</pre>
</blockquote>
</body>
</html>