<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body> <div dir="auto"> <div><br> <div class="gmail_extra"><br> <div class="gmail_quote">Am 06.05.2020 18:00 schrieb Alex Deucher <alexdeucher@gmail.com>:<br type="attribution"> <blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div><font size="2"><span style="font-size:11pt"> <div>On Wed, May 6, 2020 at 10:27 AM Zheng Bin <zhengbin13@huawei.com> wrote:<br> ><br> > Zheng Bin (14):<br> > drm/radeon: remove comparison to bool in btc_dpm.c<br> > drm/radeon: remove comparison to bool in ci_dpm.c<br> > drm/radeon: remove comparison to bool in ni_dpm.c<br> > drm/radeon: remove comparison to bool in radeon_atpx_handler.c<br> > drm/radeon: remove comparison to bool in radeon_object.c<br> > drm/radeon: remove comparison to bool in radeon_ttm.c<br> > drm/radeon: remove comparison to bool in r100.c<br> > drm/radeon: remove comparison to bool in r300.c<br> > drm/radeon: remove comparison to bool in r600.c<br> > drm/radeon: remove comparison to bool in rs600.c<br> > drm/radeon: remove comparison to bool in rs690.c<br> > drm/radeon: remove comparison to bool in rv6xx_dpm.c<br> > drm/radeon: remove comparison to bool in rv515.c<br> > drm/radeon: remove comparison to bool in si_dpm.c<br> <br> Does the checker need to be fixed? All of these are comparing boolean<br> variables to true/false. Seems like needless code churn to me.<br> </div> </span></font></div> </blockquote> </div> </div> </div> <div dir="auto"><br> </div> <div dir="auto">We should probably make sure that no new code like this leaks in, but I also don't see that this is necessary for the old driver stack.</div> <div dir="auto"><br> </div> <div dir="auto">Christian.</div> <div dir="auto"><br> </div> <div dir="auto"> <div class="gmail_extra"> <div class="gmail_quote"> <blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div><font size="2"><span style="font-size:11pt"> <div><br> Alex<br> <br> ><br> > drivers/gpu/drm/radeon/btc_dpm.c | 2 +-<br> > drivers/gpu/drm/radeon/ci_dpm.c | 4 ++--<br> > drivers/gpu/drm/radeon/ni_dpm.c | 6 +++---<br> > drivers/gpu/drm/radeon/r100.c | 2 +-<br> > drivers/gpu/drm/radeon/r300.c | 2 +-<br> > drivers/gpu/drm/radeon/r600.c | 3 ++-<br> > drivers/gpu/drm/radeon/radeon_atpx_handler.c | 4 ++--<br> > drivers/gpu/drm/radeon/radeon_object.c | 2 +-<br> > drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-<br> > drivers/gpu/drm/radeon/rs600.c | 2 +-<br> > drivers/gpu/drm/radeon/rs690.c | 3 ++-<br> > drivers/gpu/drm/radeon/rv515.c | 2 +-<br> > drivers/gpu/drm/radeon/rv6xx_dpm.c | 2 +-<br> > drivers/gpu/drm/radeon/si_dpm.c | 6 +++---<br> > 14 files changed, 22 insertions(+), 20 deletions(-)<br> ><br> > --<br> > 2.26.0.106.g9fadedd<br> ><br> > _______________________________________________<br> > amd-gfx mailing list<br> > amd-gfx@lists.freedesktop.org<br> > <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cchristian.koenig%40amd.com%7C10c2a90728574bb20ef208d7f1d69e2b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637243776401264275&sdata=Z6alCS8hPA7rWNKHimpkc6zBldtBagK0dGpX8mTOEZA%3D&reserved=0"> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cchristian.koenig%40amd.com%7C10c2a90728574bb20ef208d7f1d69e2b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637243776401264275&sdata=Z6alCS8hPA7rWNKHimpkc6zBldtBagK0dGpX8mTOEZA%3D&reserved=0</a><br> </div> </span></font></div> </blockquote> </div> <br> </div> </div> </div> </body> </html>