<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#317100;margin:15pt;" align="Left">
[AMD Public Use]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Yes, please drop this patch for stable.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Alex<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Marek Olk <maraeo@gmail.com><br>
<b>Sent:</b> Monday, May 18, 2020 6:35 PM<br>
<b>To:</b> Sasha Levin <sashal@kernel.org><br>
<b>Cc:</b> Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; stable@vger.kernel.org <stable@vger.kernel.org>; Pelloux-prayer, Pierre-eric <Pierre-eric.Pelloux-prayer@amd.com>; Olsak, Marek <Marek.Olsak@amd.com>; amd-gfx mailing list <amd-gfx@lists.freedesktop.org>;
 dri-devel <dri-devel@lists.freedesktop.org>; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com><br>
<b>Subject:</b> Re: [PATCH AUTOSEL 5.6 33/50] drm/amdgpu: bump version for invalidate L2 before SDMA IBs</font>
<div> </div>
</div>
<div>
<div dir="ltr">
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Hi Sasha,</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
I disagree with this. Bumping the driver version will have implications on other new features, because it's like an ABI barrier exposing new functionality.</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Marek<br>
</div>
</div>
<br>
<div class="x_gmail_quote">
<div dir="ltr" class="x_gmail_attr">On Thu, May 7, 2020 at 10:28 AM Sasha Levin <<a href="mailto:sashal@kernel.org">sashal@kernel.org</a>> wrote:<br>
</div>
<blockquote class="x_gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
From: Marek Olk <<a href="mailto:marek.olsak@amd.com" target="_blank">marek.olsak@amd.com</a>><br>
<br>
[ Upstream commit 9017a4897a20658f010bebea825262963c10afa6 ]<br>
<br>
This fixes GPU hangs due to cache coherency issues.<br>
Bump the driver version. Split out from the original patch.<br>
<br>
Signed-off-by: Marek Olk <<a href="mailto:marek.olsak@amd.com" target="_blank">marek.olsak@amd.com</a>><br>
Reviewed-by: Christian Knig <<a href="mailto:christian.koenig@amd.com" target="_blank">christian.koenig@amd.com</a>><br>
Tested-by: Pierre-Eric Pelloux-Prayer <<a href="mailto:pierre-eric.pelloux-prayer@amd.com" target="_blank">pierre-eric.pelloux-prayer@amd.com</a>><br>
Signed-off-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com" target="_blank">alexander.deucher@amd.com</a>><br>
Signed-off-by: Sasha Levin <<a href="mailto:sashal@kernel.org" target="_blank">sashal@kernel.org</a>><br>
---<br>
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-<br>
 1 file changed, 2 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c<br>
index 42f4febe24c6d..8d45a2b662aeb 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c<br>
@@ -85,9 +85,10 @@<br>
  * - 3.34.0 - Non-DC can flip correctly between buffers with different pitches<br>
  * - 3.35.0 - Add drm_amdgpu_info_device::tcc_disabled_mask<br>
  * - 3.36.0 - Allow reading more status registers on si/cik<br>
+ * - 3.37.0 - L2 is invalidated before SDMA IBs, needed for correctness<br>
  */<br>
 #define KMS_DRIVER_MAJOR       3<br>
-#define KMS_DRIVER_MINOR       36<br>
+#define KMS_DRIVER_MINOR       37<br>
 #define KMS_DRIVER_PATCHLEVEL  0<br>
<br>
 int amdgpu_vram_limit = 0;<br>
-- <br>
2.20.1<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
<a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a><br>
<a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Calexander.deucher%40amd.com%7C2bb4939b162b4d66d57708d7fb7bd608%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637254381604715852&sdata=uJEI0CDUeUbUGUgnhnobpKygBueEGg6UqwgzkEtIsh8%3D&reserved=0" originalsrc="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" shash="VAPmgi26LcB/ksdTS0iKaO1gfo9OB1JH8GmQQFjotKsRmhPuT0piirbA/yFnDeWQLl+KMcs8KOY8uKGQaG4/s8n9lxJDoR2XsOZAQJQlvgid1hHfg/I9wtqQAAK1Oly+MJtKsFsiGmHxCH+NNQa7vPyLQvIWHrwBtCb43RqMWj8=" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</blockquote>
</div>
</div>
</div>
</body>
</html>