<div dir="ltr"><div>Applied. Thanks!</div><div> </div><div>Alex </div></div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, May 20, 2020 at 11:33 AM Christian König <<a href="mailto:christian.koenig@amd.com">christian.koenig@amd.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Am 20.05.20 um 17:31 schrieb Ruhl, Michael J: >> -----Original Message----- >> From: Dan Carpenter <<a href="mailto:dan.carpenter@oracle.com" target="_blank">dan.carpenter@oracle.com</a>> >> Sent: Wednesday, May 20, 2020 11:26 AM >> To: Alex Deucher <<a href="mailto:alexander.deucher@amd.com" target="_blank">alexander.deucher@amd.com</a>>; Kevin Wang >> <<a href="mailto:kevin1.wang@amd.com" target="_blank">kevin1.wang@amd.com</a>>; Ruhl, Michael J <<a href="mailto:michael.j.ruhl@intel.com" target="_blank">michael.j.ruhl@intel.com</a>> >> Cc: Christian König <<a href="mailto:christian.koenig@amd.com" target="_blank">christian.koenig@amd.com</a>>; David Airlie >> <<a href="mailto:airlied@linux.ie" target="_blank">airlied@linux.ie</a>>; Daniel Vetter <<a href="mailto:daniel@ffwll.ch" target="_blank">daniel@ffwll.ch</a>>; Evan Quan >> <<a href="mailto:evan.quan@amd.com" target="_blank">evan.quan@amd.com</a>>; Rui Huang <<a href="mailto:ray.huang@amd.com" target="_blank">ray.huang@amd.com</a>>; Kenneth Feng >> <<a href="mailto:kenneth.feng@amd.com" target="_blank">kenneth.feng@amd.com</a>>; Yintian Tao <<a href="mailto:yttao@amd.com" target="_blank">yttao@amd.com</a>>; Hawking Zhang >> <<a href="mailto:Hawking.Zhang@amd.com" target="_blank">Hawking.Zhang@amd.com</a>>; <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a>; dri- >> <a href="mailto:devel@lists.freedesktop.org" target="_blank">devel@lists.freedesktop.org</a>; <a href="mailto:linux-kernel@vger.kernel.org" target="_blank">linux-kernel@vger.kernel.org</a>; kernel- >> <a href="mailto:janitors@vger.kernel.org" target="_blank">janitors@vger.kernel.org</a> >> Subject: [PATCH v3] drm/amdgpu: off by one in >> amdgpu_device_attr_create_groups() error handling >> >> This loop in the error handling code should start a "i - 1" and end at >> "i == 0". Currently it starts a "i" and ends at "i == 1". The result >> is that it removes one attribute that wasn't created yet, and leaks the >> zeroeth attribute. >> >> Fixes: 4e01847c38f7 ("drm/amdgpu: optimize amdgpu device attribute code") >> Signed-off-by: Dan Carpenter <<a href="mailto:dan.carpenter@oracle.com" target="_blank">dan.carpenter@oracle.com</a>> >> --- >> v2: style change >> v3: Fix embarrassing typo in the subject > 😊 > > Acked-by: Michael J. Ruhl <<a href="mailto:michael.j.ruhl@intel.com" target="_blank">michael.j.ruhl@intel.com</a>> Reviewed-by: Christian König <<a href="mailto:christian.koenig@amd.com" target="_blank">christian.koenig@amd.com</a>> > > m >> drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 3 +-- >> 1 files changed, 1 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c >> b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c >> index b75362bf0742..e809534fabd4 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c >> @@ -1942,9 +1942,8 @@ static int amdgpu_device_attr_create_groups(struct >> amdgpu_device *adev, >> return 0; >> >> failed: >> - for (; i > 0; i--) { >> + while (i--) >> amdgpu_device_attr_remove(adev, &attrs[i]); >> - } >> >> return ret; >> } _______________________________________________ dri-devel mailing list <a href="mailto:dri-devel@lists.freedesktop.org" target="_blank">dri-devel@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/dri-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/dri-devel</a> </blockquote></div>