<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0078D7;margin:15pt;" align="Left">
[AMD Official Use Only - Internal Distribution Only]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
The series are </div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Reviewed-by: Yong Zhao <Yong.Zhao@amd.com></div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Alex Deucher <alexdeucher@gmail.com><br>
<b>Sent:</b> Thursday, May 21, 2020 12:52 PM<br>
<b>To:</b> amd-gfx list <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Deucher, Alexander <Alexander.Deucher@amd.com><br>
<b>Subject:</b> Re: [PATCH 2/2] drm/amdgpu: drop navi pcie bw callback</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Ping on this series?<br>
<br>
On Tue, May 19, 2020 at 5:10 PM Alex Deucher <alexdeucher@gmail.com> wrote:<br>
><br>
> It's not implemented yet so just drop it so the sysfs<br>
> pcie bw file returns an appropriate error instead of<br>
> garbage.<br>
><br>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com><br>
> ---<br>
> drivers/gpu/drm/amd/amdgpu/nv.c | 8 --------<br>
> 1 file changed, 8 deletions(-)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c<br>
> index 9c42316c47c0..6655dd2009b6 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/nv.c<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/nv.c<br>
> @@ -548,13 +548,6 @@ static bool nv_need_full_reset(struct amdgpu_device *adev)<br>
> return true;<br>
> }<br>
><br>
> -static void nv_get_pcie_usage(struct amdgpu_device *adev,<br>
> - uint64_t *count0,<br>
> - uint64_t *count1)<br>
> -{<br>
> - /*TODO*/<br>
> -}<br>
> -<br>
> static bool nv_need_reset_on_init(struct amdgpu_device *adev)<br>
> {<br>
> #if 0<br>
> @@ -629,7 +622,6 @@ static const struct amdgpu_asic_funcs nv_asic_funcs =<br>
> .invalidate_hdp = &nv_invalidate_hdp,<br>
> .init_doorbell_index = &nv_init_doorbell_index,<br>
> .need_full_reset = &nv_need_full_reset,<br>
> - .get_pcie_usage = &nv_get_pcie_usage,<br>
> .need_reset_on_init = &nv_need_reset_on_init,<br>
> .get_pcie_replay_count = &nv_get_pcie_replay_count,<br>
> .supports_baco = &nv_asic_supports_baco,<br>
> --<br>
> 2.25.4<br>
><br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cyong.zhao%40amd.com%7C1a6de00e60b447bad54a08d7fda76316%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637256767681371342&sdata=EWwfgYQtOR1TGw6%2BL6w8Cw7Y9e7ixVI1xDJoWTUsWtk%3D&reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cyong.zhao%40amd.com%7C1a6de00e60b447bad54a08d7fda76316%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637256767681371342&sdata=EWwfgYQtOR1TGw6%2BL6w8Cw7Y9e7ixVI1xDJoWTUsWtk%3D&reserved=0</a><br>
</div>
</span></font></div>
</div>
</body>
</html>