<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> </head> <body> <div>Sorry I missed this. </div> <div>Series is Reviewed-By: Kent Russell <kent.russell@amd.com></div> <div><br> </div> <div> Kent</div> <div><br> </div> <div><br> </div> <div><style type="text/css" style="display:none">  </style> <div id="divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif"> <div style="font-family:Tahoma; font-size:13px"> <div style="font-family:Tahoma; font-size:13px"> <div style="font-family:Tahoma; font-size:13px"><font face="Verdana"><font size="2"><b></b></font> <p class="MsoNormal"><a name="_MailAutoSig"><b><span style="color:black; text-transform:uppercase">KENT RUSSELL</span></b></a><span style=""><b><span style="font-variant:small-caps; color:black"> </span></b></span><span style=""><span style="font-size:10.0pt; color:black"> </span></span></p> <p class="MsoNormal"><span style=""><span style="font-size:10.0pt; color:black">Sr. Software Engineer | Linux Compute Kernel</span></span></p> <p class="MsoNormal"><span style=""><span style="font-size:10.0pt; color:black">1 Commerce Valley Drive East</span></span></p> <p class="MsoNormal"><span style=""><span style="font-size:10.0pt; color:black">Markham, ON L3T 7X6</span></span></p> <p class="MsoNormal"><span style=""><b><span style="font-size:10.0pt; color:black">O</span></b></span><span style=""><span style="font-size:10.0pt; color:black"> +(1) 289-695-2122<b> </b><span style="">| Ext 72122</span></span></span></p> </font></div> </div> </div> </div> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Zhao, Yong <Yong.Zhao@amd.com><br> <b>Sent:</b> Thursday, May 21, 2020 1:27 PM<br> <b>To:</b> Alex Deucher <alexdeucher@gmail.com>; amd-gfx list <amd-gfx@lists.freedesktop.org><br> <b>Cc:</b> Deucher, Alexander <Alexander.Deucher@amd.com><br> <b>Subject:</b> Re: [PATCH 2/2] drm/amdgpu: drop navi pcie bw callback</font> <div> </div> </div> <style type="text/css" style="display:none">  </style> <div dir="ltr"> <p align="Left" style="font-family:Arial; font-size:10pt; color:#0078D7; margin:15pt"> [AMD Official Use Only - Internal Distribution Only]<br> </p> <br> <div> <p align="Left" style="font-family:Arial; font-size:10pt; color:#0078D7; margin:15pt"> [AMD Official Use Only - Internal Distribution Only]<br> </p> <br> <div> <div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)"> The series are </div> <div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)"> <br> </div> <div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)"> Reviewed-by: Yong Zhao <Yong.Zhao@amd.com></div> <div id="x_appendonsend"></div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Alex Deucher <alexdeucher@gmail.com><br> <b>Sent:</b> Thursday, May 21, 2020 12:52 PM<br> <b>To:</b> amd-gfx list <amd-gfx@lists.freedesktop.org><br> <b>Cc:</b> Deucher, Alexander <Alexander.Deucher@amd.com><br> <b>Subject:</b> Re: [PATCH 2/2] drm/amdgpu: drop navi pcie bw callback</font> <div> </div> </div> <div class="x_BodyFragment"><font size="2"><span style="font-size:11pt"> <div class="x_PlainText">Ping on this series?<br> <br> On Tue, May 19, 2020 at 5:10 PM Alex Deucher <alexdeucher@gmail.com> wrote:<br> ><br> > It's not implemented yet so just drop it so the sysfs<br> > pcie bw file returns an appropriate error instead of<br> > garbage.<br> ><br> > Signed-off-by: Alex Deucher <alexander.deucher@amd.com><br> > ---<br> > drivers/gpu/drm/amd/amdgpu/nv.c | 8 --------<br> > 1 file changed, 8 deletions(-)<br> ><br> > diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c<br> > index 9c42316c47c0..6655dd2009b6 100644<br> > --- a/drivers/gpu/drm/amd/amdgpu/nv.c<br> > +++ b/drivers/gpu/drm/amd/amdgpu/nv.c<br> > @@ -548,13 +548,6 @@ static bool nv_need_full_reset(struct amdgpu_device *adev)<br> > return true;<br> > }<br> ><br> > -static void nv_get_pcie_usage(struct amdgpu_device *adev,<br> > - uint64_t *count0,<br> > - uint64_t *count1)<br> > -{<br> > - /*TODO*/<br> > -}<br> > -<br> > static bool nv_need_reset_on_init(struct amdgpu_device *adev)<br> > {<br> > #if 0<br> > @@ -629,7 +622,6 @@ static const struct amdgpu_asic_funcs nv_asic_funcs =<br> > .invalidate_hdp = &nv_invalidate_hdp,<br> > .init_doorbell_index = &nv_init_doorbell_index,<br> > .need_full_reset = &nv_need_full_reset,<br> > - .get_pcie_usage = &nv_get_pcie_usage,<br> > .need_reset_on_init = &nv_need_reset_on_init,<br> > .get_pcie_replay_count = &nv_get_pcie_replay_count,<br> > .supports_baco = &nv_asic_supports_baco,<br> > --<br> > 2.25.4<br> ><br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Ckent.russell%40amd.com%7Cb24bbf754a294cc666ba08d7fdac5228%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637256789747127637&sdata=m%2BJ73URIHmwFL3IH%2BC%2BSgryLmztoLuXswA33XTFiy90%3D&reserved=0" originalsrc="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" shash="xjEFtKrMG2dKpsBHq0Na/4GT4aMW/gmzls6zpQLxYyPTEqnECoZleIW6rDtHnXFWhcgn6MhBD9AAW6NCt2BlQNkxyuDkWLR4W1R3z0AzwwD5qcqolizRLQYJoevQMDBc0XHrtW696ZsDnN1aZ28J7YS2AJgnpCVPspaZYAi1GJY=">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cyong.zhao%40amd.com%7C1a6de00e60b447bad54a08d7fda76316%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637256767681371342&sdata=EWwfgYQtOR1TGw6%2BL6w8Cw7Y9e7ixVI1xDJoWTUsWtk%3D&reserved=0</a><br> </div> </span></font></div> </div> </div> </div> </body> </html>