<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <p style="font-family:Arial;font-size:10pt;color:#0078D7;margin:15pt;" align="Left"> [AMD Official Use Only - Internal Distribution Only]<br> </p> <br> <div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Hi Fenghua,</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> I am okay with the idea.</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Regards,</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Yong</div> <div id="appendonsend"></div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Fenghua Yu <fenghua.yu@intel.com><br> <b>Sent:</b> Friday, May 22, 2020 5:21 PM<br> <b>To:</b> Kuehling, Felix <Felix.Kuehling@amd.com><br> <b>Cc:</b> Zhao, Yong <Yong.Zhao@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br> <b>Subject:</b> Re: drm/amdkfd: Change pasid's type to unsigned int</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">Hi, Felix,<br> <br> On Fri, May 22, 2020 at 03:40:06PM -0400, Felix Kuehling wrote:<br> > Hi Fenghua,<br> > <br> > The PASID width in KFD is currently limited to 16 bits. I believe this<br> > reflects what our hardware can handle. KFD will never allocate a PASID<br> > bigger than 16 bits. That said, I'm OK with changing this field in the<br> > kfd_process structure to unsigned int. Generally, I find uint16_t in<br> > structures not very useful except in tightly packed structures such as<br> > packet formats or ioctl arguments.<br> <br> Thank you very much for your insight!<br> <br> I'm writing the patch set to define pasid as "unsigned int" consistently<br> in iommu. I'll put the amdkfd changes (only a few changes including this<br> pasid change in struct kfd_processin) one patch and send it to you for<br> review.<br> <br> -Fenghua<br> </div> </span></font></div> </div> </body> </html>