<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <p style="font-family:Arial;font-size:10pt;color:#0078D7;margin:15pt;" align="Left"> [AMD Official Use Only - Internal Distribution Only]<br> </p> <br> <div> <div class="WordSection1"> <p class="msipheadera92e061b" style="margin:0in;margin-bottom:.0001pt"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#0078D7">[AMD Official Use Only - Internal Distribution Only]</span><o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Hmmmm…. <o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <ol style="margin-top:0in" start="1" type="1"> <li class="MsoListParagraph" style="margin-left:0in;mso-list:l0 level1 lfo3">There are some places in amdgpu driver using release_firmware like this way<o:p></o:p></li><li class="MsoListParagraph" style="margin-left:0in;mso-list:l0 level1 lfo3">This case is a little different, we use it in loop and maybe not all sdma instances’ fw is initialized, just like we did in v5_2<o:p></o:p></li></ol> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Brs<o:p></o:p></p> <p class="MsoNormal">Wenhui<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b>From:</b> Wang, Kevin(Yang) <Kevin1.Wang@amd.com> <br> <b>Sent:</b> Thursday, June 18, 2020 4:48 PM<br> <b>To:</b> Sheng, Wenhui <Wenhui.Sheng@amd.com>; amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH 2/2] drm/amdgpu: add fw release for sdma v5_0<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <p style="margin:15.0pt"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#0078D7">[AMD Official Use Only - Internal Distribution Only]<o:p></o:p></span></p> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">afte the API <b><i>firmware_realease </i></b>created, the api logic never changed. (the first commit by Linus)<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">and you can use below command to reference the api usage case in our drm driver.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><i><span style="font-size:12.0pt;color:black">$ grep -nR "release_firmware" -A 5 -B 5 drivers/gpu/drm/ | vim -</span></i><span style="font-size:12.0pt;color:black"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">Best Regards,<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">Kevin<o:p></o:p></span></p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> <p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> Sheng, Wenhui <</span><a href="mailto:Wenhui.Sheng@amd.com">Wenhui.Sheng@amd.com</a><span style="color:black">><br> <b>Sent:</b> Thursday, June 18, 2020 4:31 PM<br> <b>To:</b> Wang, Kevin(Yang) <</span><a href="mailto:Kevin1.Wang@amd.com">Kevin1.Wang@amd.com</a><span style="color:black">>; </span><a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><span style="color:black"> <</span><a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><span style="color:black">><br> <b>Subject:</b> RE: [PATCH 2/2] drm/amdgpu: add fw release for sdma v5_0</span> <o:p> </o:p></p> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> <div> <p style="margin:15.0pt"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#0078D7">[AMD Official Use Only - Internal Distribution Only]<o:p></o:p></span></p> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="xmsipheadera92e061b"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#0078D7">[AMD Official Use Only - Internal Distribution Only]</span><o:p></o:p></p> <p class="xmsonormal"> <o:p></o:p></p> <p class="xmsonormal">Although we know that release_firmware has null check, but the code is not maintained by ourselves, so I think it’s much more safe to add null check before invoke release_firmware.<o:p></o:p></p> <p class="xmsonormal"> <o:p></o:p></p> <p class="xmsonormal"> <o:p></o:p></p> <p class="xmsonormal">Brs<o:p></o:p></p> <p class="xmsonormal">Wenhui<o:p></o:p></p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="xmsonormal"><b>From:</b> Wang, Kevin(Yang) <<a href="mailto:Kevin1.Wang@amd.com">Kevin1.Wang@amd.com</a>> <br> <b>Sent:</b> Thursday, June 18, 2020 4:25 PM<br> <b>To:</b> Sheng, Wenhui <<a href="mailto:Wenhui.Sheng@amd.com">Wenhui.Sheng@amd.com</a>>; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> <b>Subject:</b> Re: [PATCH 2/2] drm/amdgpu: add fw release for sdma v5_0<o:p></o:p></p> </div> </div> <p class="xmsonormal"> <o:p></o:p></p> <p style="margin:15.0pt"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#0078D7">[AMD Official Use Only - Internal Distribution Only]</span><o:p></o:p></p> <p class="xmsonormal"> <o:p></o:p></p> <div> <div> <p class="xmsonormal"><span style="font-size:12.0pt;color:black"> </span><o:p></o:p></p> </div> <div> <p class="xmsonormal"><span style="font-size:12.0pt;color:black"> </span><o:p></o:p></p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="x_divRplyFwdMsg"> <p class="xmsonormal"><b><span style="color:black">From:</span></b><span style="color:black"> amd-gfx <</span><a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a><span style="color:black">> on behalf of Wenhui Sheng <</span><a href="mailto:Wenhui.Sheng@amd.com">Wenhui.Sheng@amd.com</a><span style="color:black">><br> <b>Sent:</b> Thursday, June 18, 2020 3:53 PM<br> <b>To:</b> </span><a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><span style="color:black"> <</span><a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><span style="color:black">><br> <b>Cc:</b> Sheng, Wenhui <</span><a href="mailto:Wenhui.Sheng@amd.com">Wenhui.Sheng@amd.com</a><span style="color:black">><br> <b>Subject:</b> [PATCH 2/2] drm/amdgpu: add fw release for sdma v5_0</span> <o:p> </o:p></p> <div> <p class="xmsonormal"> <o:p></o:p></p> </div> </div> <div> <div> <p class="xmsonormal">sdma v5_0 fw isn't released when module exit<br> <br> Signed-off-by: Wenhui Sheng <<a href="mailto:Wenhui.Sheng@amd.com">Wenhui.Sheng@amd.com</a>><br> ---<br> drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 6 +++++-<br> 1 file changed, 5 insertions(+), 1 deletion(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c<br> index 58d2a80af450..6751ad69ed90 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c<br> @@ -1299,8 +1299,12 @@ static int sdma_v5_0_sw_fini(void *handle)<br> struct amdgpu_device *adev = (struct amdgpu_device *)handle;<br> int i;<br> <br> - for (i = 0; i < adev->sdma.num_instances; i++)<br> + for (i = 0; i < adev->sdma.num_instances; i++) {<br> + if (adev->sdma.instance[i].fw != NULL)<br> + release_firmware(adev->sdma.instance[i].fw);<o:p></o:p></p> </div> <div> <p class="xmsonormal"><span style="font-size:12.0pt;color:black">[kevin]:</span><o:p></o:p></p> <div> <p class="xmsonormal"><span style="font-size:12.0pt;color:black">the kernel api "release_firmware()" will check argument (is NULL pointer).</span><o:p></o:p></p> </div> <div> <p class="xmsonormal"><span style="font-size:12.0pt;color:black">i think the patch don't need to double check it.</span><o:p></o:p></p> </div> <p class="xmsonormal">+<br> amdgpu_ring_fini(&adev->sdma.instance[i].ring);<br> + }<br> <br> return 0;<br> }<br> -- <br> 2.17.1<br> <br> _______________________________________________<br> amd-gfx mailing list<br> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7CKevin1.Wang%40amd.com%7Cd0b8b72e0be443a7343d08d8135cb093%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637280636699912801&sdata=HrKVAmRO0HKFZBRG6oWq3thNlGBd0T9bMramDU1ijys%3D&reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7CKevin1.Wang%40amd.com%7Cd0b8b72e0be443a7343d08d8135cb093%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637280636699912801&sdata=HrKVAmRO0HKFZBRG6oWq3thNlGBd0T9bMramDU1ijys%3D&reserved=0</a><o:p></o:p></p> </div> </div> </div> </div> </div> </div> </div> </div> </div> </body> </html>