<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <p style="font-family:Arial;font-size:10pt;color:#317100;margin:15pt;" align="Left"> [AMD Public Use]<br> </p> <br> <div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Ah, yes, indeed.</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Thanks,</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Alex<br> </div> <div id="appendonsend"></div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Quan, Evan <Evan.Quan@amd.com><br> <b>Sent:</b> Monday, July 6, 2020 9:31 PM<br> <b>To:</b> Alex Deucher <alexdeucher@gmail.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br> <b>Cc:</b> Deucher, Alexander <Alexander.Deucher@amd.com><br> <b>Subject:</b> RE: [PATCH] drm/amdgpu/swSMU: drop pm_enabled check in set mp1 state</font> <div> </div> </div> <div class="BodyFragment"><font face="Times New Roman" size="3"><span style="font-size:12pt;"><a name="BM_BEGIN"></a> <div><font size="2"><span style="font-size:11pt;">[AMD Official Use Only - Internal Distribution Only]<br> <br> I think you may wrongly treated the "pm_enabled" as "dpm_enabled".<br> pm_enabled should be always true unless user specifies "dpm=0" on module loading.<br> <br> -----Original Message-----<br> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Alex Deucher<br> Sent: Tuesday, July 7, 2020 3:16 AM<br> To: amd-gfx@lists.freedesktop.org<br> Cc: Deucher, Alexander <Alexander.Deucher@amd.com><br> Subject: [PATCH] drm/amdgpu/swSMU: drop pm_enabled check in set mp1 state<br> <br> We need to set the mp1 state in PCI shutdown and certain reset cases which happens after we've already suspended the SMU. SMU suspend sets pm_enabled to false which prevents this code from being run.<br> <br> Signed-off-by: Alex Deucher <alexander.deucher@amd.com><br> ---<br> drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 3 ---<br> 1 file changed, 3 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c<br> index fe4948aa662f..0ed75a9897eb 100644<br> --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c<br> +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c<br> @@ -1924,9 +1924,6 @@ int smu_set_mp1_state(struct smu_context *smu,<br> uint16_t msg;<br> int ret;<br> <br> -if (!smu->pm_enabled)<br> -return -EOPNOTSUPP;<br> -<br> mutex_lock(&smu->mutex);<br> <br> switch (mp1_state) {<br> --<br> 2.25.4<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cevan.quan%40amd.com%7C833334723b854666ac1f08d821e11cf8%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637296598083021484&sdata=bD1UlSdYqXuPoDoTCvGZHRJr2F6DoJu2LHN6v5p4%2FoA%3D&reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cevan.quan%40amd.com%7C833334723b854666ac1f08d821e11cf8%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637296598083021484&sdata=bD1UlSdYqXuPoDoTCvGZHRJr2F6DoJu2LHN6v5p4%2FoA%3D&reserved=0</a><br> </span></font></div> </span></font></div> </div> </body> </html>