<div dir="ltr"><div dir="ltr"> </div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jul 27, 2020 at 8:31 PM Alex Deucher <<a href="mailto:alexdeucher@gmail.com">alexdeucher@gmail.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Sun, Jul 26, 2020 at 11:31 AM Mauro Rossi <<a href="mailto:issor.oruam@gmail.com" target="_blank">issor.oruam@gmail.com</a>> wrote: > > Hello, > > On Fri, Jul 24, 2020 at 8:31 PM Alex Deucher <<a href="mailto:alexdeucher@gmail.com" target="_blank">alexdeucher@gmail.com</a>> wrote: >> >> On Wed, Jul 22, 2020 at 3:57 AM Mauro Rossi <<a href="mailto:issor.oruam@gmail.com" target="_blank">issor.oruam@gmail.com</a>> wrote: >> > >> > Hello, >> > re-sending and copying full DL >> > >> > On Wed, Jul 22, 2020 at 4:51 AM Alex Deucher <<a href="mailto:alexdeucher@gmail.com" target="_blank">alexdeucher@gmail.com</a>> wrote: >> >> >> >> On Mon, Jul 20, 2020 at 6:00 AM Mauro Rossi <<a href="mailto:issor.oruam@gmail.com" target="_blank">issor.oruam@gmail.com</a>> wrote: >> >> > >> >> > Hi Christian, >> >> > >> >> > On Mon, Jul 20, 2020 at 11:00 AM Christian König >> >> > <<a href="mailto:ckoenig.leichtzumerken@gmail.com" target="_blank">ckoenig.leichtzumerken@gmail.com</a>> wrote: >> >> > > >> >> > > Hi Mauro, >> >> > > >> >> > > I'm not deep into the whole DC design, so just some general high level >> >> > > comments on the cover letter: >> >> > > >> >> > > 1. Please add a subject line to the cover letter, my spam filter thinks >> >> > > that this is suspicious otherwise. >> >> > >> >> > My mistake in the editing of covert letter with git send-email, >> >> > I may have forgot to keep the Subject at the top >> >> > >> >> > > >> >> > > 2. Then you should probably note how well (badly?) is that tested. Since >> >> > > you noted proof of concept it might not even work. >> >> > >> >> > The Changelog is to be read as: >> >> > >> >> > [RFC] was the initial Proof of concept was the RFC and [PATCH v2] was >> >> > just a rebase onto amd-staging-drm-next >> >> > >> >> > this series [PATCH v3] has all the known changes required for DCE6 specificity >> >> > and based on a long offline thread with Alexander Deutcher and past >> >> > dri-devel chats with Harry Wentland. >> >> > >> >> > It was tested for my possibilities of testing with HD7750 and HD7950, >> >> > with checks in dmesg output for not getting "missing registers/masks" >> >> > kernel WARNING >> >> > and with kernel build on Ubuntu 20.04 and with android-x86 >> >> > >> >> > The proposal I made to Alex is that AMD testing systems will be used >> >> > for further regression testing, >> >> > as part of review and validation for eligibility to amd-staging-drm-next >> >> > >> >> >> >> We will certainly test it once it lands, but presumably this is >> >> working on the SI cards you have access to? >> > >> > >> > Yes, most of my testing was done with android-x86 Android CTS (EGL, GLES2, GLES3, VK) >> > >> > I am also in contact with a person with Firepro W5130M who is running a piglit session >> > >> > I had bought an HD7850 to test with Pitcairn, but it arrived as defective so I could not test with Pitcair >> > >> > >> >> >> >> > > >> >> > > 3. How feature complete (HDMI audio?, Freesync?) is it? >> >> > >> >> > All the changes in DC impacting DCE8 (dc/dce80 path) were ported to >> >> > DCE6 (dc/dce60 path) in the last two years from initial submission >> >> > >> >> > > >> >> > > Apart from that it looks like a rather impressive piece of work :) >> >> > > >> >> > > Cheers, >> >> > > Christian. >> >> > >> >> > Thanks, >> >> > please consider that most of the latest DCE6 specific parts were >> >> > possible due to recent Alex support in getting the correct DCE6 >> >> > headers, >> >> > his suggestions and continuous feedback. >> >> > >> >> > I would suggest that Alex comments on the proposed next steps to follow. >> >> >> >> The code looks pretty good to me. I'd like to get some feedback from >> >> the display team to see if they have any concerns, but beyond that I >> >> think we can pull it into the tree and continue improving it there. >> >> Do you have a link to a git tree I can pull directly that contains >> >> these patches? Is this the right branch? >> >> <a href="https://github.com/maurossi/linux/commits/kernel-5.8rc4_si_next" rel="noreferrer" target="_blank">https://github.com/maurossi/linux/commits/kernel-5.8rc4_si_next</a> >> >> >> >> Thanks! >> >> >> >> Alex >> > >> > >> > The following branch was pushed with the series on top of amd-staging-drm-next >> > >> > <a href="https://github.com/maurossi/linux/commits/kernel-5.6_si_drm-next" rel="noreferrer" target="_blank">https://github.com/maurossi/linux/commits/kernel-5.6_si_drm-next</a> >> >> I gave this a quick test on all of the SI asics and the various >> monitors I had available and it looks good. A few minor patches I >> noticed are attached. If they look good to you, I'll squash them into >> the series when I commit it. I've pushed it to my fdo tree as well: >> <a href="https://cgit.freedesktop.org/~agd5f/linux/log/?h=si_dc_support" rel="noreferrer" target="_blank">https://cgit.freedesktop.org/~agd5f/linux/log/?h=si_dc_support</a> >> >> Thanks! >> >> Alex > > > The new patches are ok and with the following infomation about piglit tests, > the series may be good to go. > > I have performed piglit tests on Tahiti HD7950 on kernel 5.8.0-rc6 with AMD DC support for SI > and comparison with vanilla kernel 5.8.0-rc6 > > Results are the following > > [piglit gpu tests with kernel 5.8.0-rc6-amddcsi] > > utente@utente-desktop:~/piglit$ ./piglit run gpu . > [26714/26714] skip: 1731, pass: 24669, warn: 15, fail: 288, crash: 11 > Thank you for running Piglit! > Results have been written to /home/utente/piglit > > [piglit gpu tests with vanilla 5.8.0-rc6] > > utente@utente-desktop:~/piglit$ ./piglit run gpu . > [26714/26714] skip: 1731, pass: 24673, warn: 13, fail: 283, crash: 14 > Thank you for running Piglit! > Results have been written to /home/utente/piglit > > In the attachment the comparison of "5.8.0-rc6-amddcsi" vs "5.8.0-rc6" vanilla > and viceversa, I see no significant regression and in the delta of failed tests I don't recognize DC related test cases, > but you may also have a look. Looks good to me. The series is: Reviewed-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com" target="_blank">alexander.deucher@amd.com</a>> </blockquote><div> </div><div>Thank you Alex for review and the help in finalizing the series</div><div>and to Harry who initially encouraged me and provided the feedbacks to previous v2 series</div><div> </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> > > dmesg for "5.8.0-rc6-amddcsi" is also provide the check the crashes > > Regarding the other user testing the series with Firepro W5130M > he found an already existing issue in amdgpu si_support=1 which is independent from my series and matches a problem alrady reported. [1] > amdgpu does not currently implement GPU reset support for SI. Alex </blockquote><div> </div><div>If you have in the plans to add support and prevent those crashes, </div><div>the user would be glad to be available for glxgears and piglit testing on Firepro W5130M</div><div> </div><div>Please let me know</div><div> </div><div>Mauro</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> > Mauro > > [1] <a href="https://bbs.archlinux.org/viewtopic.php?id=249097" rel="noreferrer" target="_blank">https://bbs.archlinux.org/viewtopic.php?id=249097</a> > >> >> >> > >> >> >> >> >> >> > >> >> > Mauro >> >> > >> >> > > >> >> > > Am 16.07.20 um 23:22 schrieb Mauro Rossi: >> >> > > > The series adds SI support to AMD DC >> >> > > > >> >> > > > Changelog: >> >> > > > >> >> > > > [RFC] >> >> > > > Preliminar Proof Of Concept, with DCE8 headers still used in dce60_resources.c >> >> > > > >> >> > > > [PATCH v2] >> >> > > > Rebase on amd-staging-drm-next dated 17-Oct-2018 >> >> > > > >> >> > > > [PATCH v3] >> >> > > > Add support for DCE6 specific headers, >> >> > > > ad hoc DCE6 macros, funtions and fixes, >> >> > > > rebase on current amd-staging-drm-next >> >> > > > >> >> > > > >> >> > > > Commits [01/27]..[08/27] SI support added in various DC components >> >> > > > >> >> > > > [PATCH v3 01/27] drm/amdgpu: add some required DCE6 registers (v6) >> >> > > > [PATCH v3 02/27] drm/amd/display: add asics info for SI parts >> >> > > > [PATCH v3 03/27] drm/amd/display: dc/dce: add initial DCE6 support (v9b) >> >> > > > [PATCH v3 04/27] drm/amd/display: dc/core: add SI/DCE6 support (v2) >> >> > > > [PATCH v3 05/27] drm/amd/display: dc/bios: add support for DCE6 >> >> > > > [PATCH v3 06/27] drm/amd/display: dc/gpio: add support for DCE6 (v2) >> >> > > > [PATCH v3 07/27] drm/amd/display: dc/irq: add support for DCE6 (v4) >> >> > > > [PATCH v3 08/27] drm/amd/display: amdgpu_dm: add SI support (v4) >> >> > > > >> >> > > > Commits [09/27]..[24/27] DCE6 specific code adaptions >> >> > > > >> >> > > > [PATCH v3 09/27] drm/amd/display: dc/clk_mgr: add support for SI parts (v2) >> >> > > > [PATCH v3 10/27] drm/amd/display: dc/dce60: set max_cursor_size to 64 >> >> > > > [PATCH v3 11/27] drm/amd/display: dce_audio: add DCE6 specific macros,functions >> >> > > > [PATCH v3 12/27] drm/amd/display: dce_dmcu: add DCE6 specific macros >> >> > > > [PATCH v3 13/27] drm/amd/display: dce_hwseq: add DCE6 specific macros,functions >> >> > > > [PATCH v3 14/27] drm/amd/display: dce_ipp: add DCE6 specific macros,functions >> >> > > > [PATCH v3 15/27] drm/amd/display: dce_link_encoder: add DCE6 specific macros,functions >> >> > > > [PATCH v3 16/27] drm/amd/display: dce_mem_input: add DCE6 specific macros,functions >> >> > > > [PATCH v3 17/27] drm/amd/display: dce_opp: add DCE6 specific macros,functions >> >> > > > [PATCH v3 18/27] drm/amd/display: dce_transform: add DCE6 specific macros,functions >> >> > > > [PATCH v3 19/27] drm/amdgpu: add some required DCE6 registers (v7) >> >> > > > [PATCH v3 20/27] drm/amd/display: dce_transform: DCE6 Scaling Horizontal Filter Init >> >> > > > [PATCH v3 21/27] drm/amd/display: dce60_hw_sequencer: add DCE6 macros,functions >> >> > > > [PATCH v3 22/27] drm/amd/display: dce60_hw_sequencer: add DCE6 specific .cursor_lock >> >> > > > [PATCH v3 23/27] drm/amd/display: dce60_timing_generator: add DCE6 specific functions >> >> > > > [PATCH v3 24/27] drm/amd/display: dc/dce60: use DCE6 headers (v6) >> >> > > > >> >> > > > >> >> > > > Commits [25/27]..[27/27] SI support final enablements >> >> > > > >> >> > > > [PATCH v3 25/27] drm/amd/display: create plane rotation property for Bonarie and later >> >> > > > [PATCH v3 26/27] drm/amdgpu: enable DC support for SI parts (v2) >> >> > > > [PATCH v3 27/27] drm/amd/display: enable SI support in the Kconfig (v2) >> >> > > > >> >> > > > >> >> > > > Signed-off-by: Mauro Rossi <<a href="mailto:issor.oruam@gmail.com" target="_blank">issor.oruam@gmail.com</a>> >> >> > > > >> >> > > > _______________________________________________ >> >> > > > amd-gfx mailing list >> >> > > > <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a> >> >> > > > <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> >> >> > > >> >> > _______________________________________________ >> >> > amd-gfx mailing list >> >> > <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a> >> >> > <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> </blockquote></div></div>