<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> [AMD Official Use Only - Internal Distribution Only] <div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Thanks very much Luben!</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Regards,</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Rico </div> <div id="appendonsend"></div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr">From: Tuikov, Luben <Luben.Tuikov@amd.com> Sent: Wednesday, July 29, 2020 2:29 To: Yin, Tianci (Rico) <Tianci.Yin@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Zhang, Hawking <Hawking.Zhang@amd.com>; Xu, Feifei <Feifei.Xu@amd.com>; Hesik, Christopher <Christopher.Hesik@amd.com>; Swamy, Manjunatha <Manjunatha.Swamy@amd.com>; Quan, Evan <Evan.Quan@amd.com>; Feng, Kenneth <Kenneth.Feng@amd.com> Subject: Re: [PATCH 1/2] drm/amdgpu: add interface amdgpu_gfx_init_spm_golden for Navi1x <div> </div> </div> <div class="BodyFragment"> <div class="PlainText">On 2020-07-28 1:27 a.m., Tianci Yin wrote: > From: "Tianci.Yin" <tianci.yin@amd.com> > > On Navi1x, the SPM golden settings will be lost after GFXOFF enter/exit, Use present tense:............... " are lost after " > reconfiguration is needed. Make the configuration code as an interface for Add "so a reconfiguration is needed. " > future use. > If the lines of your commit message are too long, then "git push" complains about them. Sixty char wide is perfect, since "git log" indents them when displaying them. With this fixed, then Reviewed-by: Luben Tuikov <luben.tuikov@amd.com> Regards, Luben > Change-Id: I172f3dc7f59da69b0364052dcad75a9c9aab019e > Signed-off-by: Tianci.Yin <tianci.yin@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 2 ++ > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 34 ++++++++++++++++++------- > 2 files changed, 27 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h > index 1e7a2b0997c5..a611e78dd4ba 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h > @@ -216,6 +216,7 @@ struct amdgpu_gfx_funcs { > int (*ras_error_inject)(struct amdgpu_device *adev, void *inject_if); > int (*query_ras_error_count) (struct amdgpu_device *adev, void *ras_error_status); > void (*reset_ras_error_count) (struct amdgpu_device *adev); > + void (*init_spm_golden)(struct amdgpu_device *adev); > }; > > struct sq_work { > @@ -324,6 +325,7 @@ struct amdgpu_gfx { > #define amdgpu_gfx_get_gpu_clock_counter(adev) (adev)->gfx.funcs->get_gpu_clock_counter((adev)) > #define amdgpu_gfx_select_se_sh(adev, se, sh, instance) (adev)->gfx.funcs->select_se_sh((adev), (se), (sh), (instance)) > #define amdgpu_gfx_select_me_pipe_q(adev, me, pipe, q, vmid) (adev)->gfx.funcs->select_me_pipe_q((adev), (me), (pipe), (q), (vmid)) > +#define amdgpu_gfx_init_spm_golden(adev) (adev)->gfx.funcs->init_spm_golden((adev)) > > /** > * amdgpu_gfx_create_bitmask - create a bitmask > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c > index db9f1e89a0f8..da21ad04ac0f 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c > @@ -3307,6 +3307,29 @@ static void gfx_v10_0_set_kiq_pm4_funcs(struct amdgpu_device *adev) > adev->gfx.kiq.pmf = &gfx_v10_0_kiq_pm4_funcs; > } > > +static void gfx_v10_0_init_spm_golden_registers(struct amdgpu_device *adev) > +{ > + switch (adev->asic_type) { > + case CHIP_NAVI10: > + soc15_program_register_sequence(adev, > + golden_settings_gc_rlc_spm_10_0_nv10, > + (const u32)ARRAY_SIZE(golden_settings_gc_rlc_spm_10_0_nv10)); > + break; > + case CHIP_NAVI14: > + soc15_program_register_sequence(adev, > + golden_settings_gc_rlc_spm_10_1_nv14, > + (const u32)ARRAY_SIZE(golden_settings_gc_rlc_spm_10_1_nv14)); > + break; > + case CHIP_NAVI12: > + soc15_program_register_sequence(adev, > + golden_settings_gc_rlc_spm_10_1_2_nv12, > + (const u32)ARRAY_SIZE(golden_settings_gc_rlc_spm_10_1_2_nv12)); > + break; > + default: > + break; > + } > +} > + > static void gfx_v10_0_init_golden_registers(struct amdgpu_device *adev) > { > switch (adev->asic_type) { > @@ -3317,9 +3340,6 @@ static void gfx_v10_0_init_golden_registers(struct amdgpu_device *adev) > soc15_program_register_sequence(adev, > golden_settings_gc_10_0_nv10, > (const u32)ARRAY_SIZE(golden_settings_gc_10_0_nv10)); > - soc15_program_register_sequence(adev, > - golden_settings_gc_rlc_spm_10_0_nv10, > - (const u32)ARRAY_SIZE(golden_settings_gc_rlc_spm_10_0_nv10)); > break; > case CHIP_NAVI14: > soc15_program_register_sequence(adev, > @@ -3328,9 +3348,6 @@ static void gfx_v10_0_init_golden_registers(struct amdgpu_device *adev) > soc15_program_register_sequence(adev, > golden_settings_gc_10_1_nv14, > (const u32)ARRAY_SIZE(golden_settings_gc_10_1_nv14)); > - soc15_program_register_sequence(adev, > - golden_settings_gc_rlc_spm_10_1_nv14, > - (const u32)ARRAY_SIZE(golden_settings_gc_rlc_spm_10_1_nv14)); > break; > case CHIP_NAVI12: > soc15_program_register_sequence(adev, > @@ -3339,9 +3356,6 @@ static void gfx_v10_0_init_golden_registers(struct amdgpu_device *adev) > soc15_program_register_sequence(adev, > golden_settings_gc_10_1_2_nv12, > (const u32)ARRAY_SIZE(golden_settings_gc_10_1_2_nv12)); > - soc15_program_register_sequence(adev, > - golden_settings_gc_rlc_spm_10_1_2_nv12, > - (const u32)ARRAY_SIZE(golden_settings_gc_rlc_spm_10_1_2_nv12)); > break; > case CHIP_SIENNA_CICHLID: > soc15_program_register_sequence(adev, > @@ -3360,6 +3374,7 @@ static void gfx_v10_0_init_golden_registers(struct amdgpu_device *adev) > default: > break; > } > + gfx_v10_0_init_spm_golden_registers(adev); > } > > static void gfx_v10_0_scratch_init(struct amdgpu_device *adev) > @@ -4147,6 +4162,7 @@ static const struct amdgpu_gfx_funcs gfx_v10_0_gfx_funcs = { > .read_wave_sgprs = &gfx_v10_0_read_wave_sgprs, > .read_wave_vgprs = &gfx_v10_0_read_wave_vgprs, > .select_me_pipe_q = &gfx_v10_0_select_me_pipe_q, > + .init_spm_golden = &gfx_v10_0_init_spm_golden_registers, > }; > > static void gfx_v10_0_gpu_early_init(struct amdgpu_device *adev) > </div> </div> </div> </body> </html>