<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0078D7;margin:15pt;" align="Left">
[AMD Official Use Only - Internal Distribution Only]<br>
</p>
<br>
<div>
<div style=""><span style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">​Acked-by: Slava Abramov <slava.abramov@amd.com></span><br>
</div>
<div id="appendonsend"></div>
<div style=""><br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">From:</span><span style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> amd-gfx <amd-gfx-bounces@lists.freedesktop.org>
 on behalf of Luben Tuikov <luben.tuikov@amd.com></span><br>
<span style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">Sent:</span><span style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Wednesday, September 16, 2020 1:08 PM</span><br>
<span style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">To:</span><span style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org></span><br>
<span style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">Cc:</span><span style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Deucher, Alexander <Alexander.Deucher@amd.com>; Tuikov,
 Luben <Luben.Tuikov@amd.com></span><br>
<span style="font-size: 12pt; font-family: Calibri, Helvetica, sans-serif; color: rgb(0, 0, 0);">Subject:</span><span style="font-size: 12pt; font-family: Calibri, Helvetica, sans-serif; color: rgb(0, 0, 0);"> [PATCH] drm/amdgpu: No sysfs, not an error condition</span>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">Not being able to create amdgpu sysfs attributes<br>
is not a fatal error warranting not to continue<br>
to try to bring up the display. Thus, if we get<br>
an error trying to create amdgpu sysfs attrs,<br>
report it and continue on to try to bring up<br>
a display.<br>
<br>
Signed-off-by: Luben Tuikov <luben.tuikov@amd.com><br>
---<br>
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +---<br>
 1 file changed, 1 insertion(+), 3 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br>
index 5d702f6e77de..62174f5e8311 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br>
@@ -3400,10 +3400,8 @@ int amdgpu_device_init(struct amdgpu_device *adev,<br>
                 flush_delayed_work(&adev->delayed_init_work);<br>
 <br>
         r = sysfs_create_files(&adev->dev->kobj, amdgpu_dev_attributes);<br>
-       if (r) {<br>
+       if (r)<br>
                 dev_err(adev->dev, "Could not create amdgpu device attr\n");<br>
-               return r;<br>
-       }<br>
 <br>
         if (IS_ENABLED(CONFIG_PERF_EVENTS))<br>
                 r = amdgpu_pmu_init(adev);<br>
-- <br>
2.28.0.394.ge197136389<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Cslava.abramov%40amd.com%7C08421e1e2e0041c5b71c08d85a633ac5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637358729546814375&amp;sdata=KOD9dj7ibpXC6s0PiXJFyxWfhdC74zxQkGOIKjcw3EY%3D&amp;reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Cslava.abramov%40amd.com%7C08421e1e2e0041c5b71c08d85a633ac5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637358729546814375&amp;sdata=KOD9dj7ibpXC6s0PiXJFyxWfhdC74zxQkGOIKjcw3EY%3D&amp;reserved=0</a><br>
</div>
</span></font></div>
</div>
</body>
</html>