<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0078D7;margin:15pt;" align="Left">
[AMD Official Use Only - Internal Distribution Only]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks,<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
.calc_vupdate_position : Used to help avoid cursor stuttering
<div>.set_pipe : Needed for setting abm<br>
</div>
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
WIll add these before pushing.<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com><br>
<b>Sent:</b> October 5, 2020 2:12 PM<br>
<b>To:</b> Lakha, Bhawanpreet <Bhawanpreet.Lakha@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com><br>
<b>Cc:</b> rodrigo.siqOFueira@amd.com <rodrigo.siqOFueira@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Subject:</b> Re: [PATCH] drm/amd/display: Add missing function pointers for dcn3</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On 2020-10-05 2:10 p.m., Bhawanpreet Lakha wrote:<br>
> These function pointers are missing from dcn30_init<br>
> <br>
> .calc_vupdate_position<br>
> .set_pipe<br>
> <br>
> So add them<br>
> <br>
> Signed-off-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com><br>
<br>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com><br>
<br>
Would be good to mention what these are used for specifically though.<br>
<br>
The calc_vupdate_position in particular is used to help avoid cursor <br>
stuttering.<br>
<br>
Regards,<br>
Nicholas Kazlauskas<br>
<br>
> ---<br>
> drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c | 2 ++<br>
> 1 file changed, 2 insertions(+)<br>
> <br>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c<br>
> index 7c90c2222506..dc312d4172af 100644<br>
> --- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c<br>
> +++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c<br>
> @@ -90,9 +90,11 @@ static const struct hw_sequencer_funcs dcn30_funcs = {<br>
> .init_vm_ctx = dcn20_init_vm_ctx,<br>
> .set_flip_control_gsl = dcn20_set_flip_control_gsl,<br>
> .get_vupdate_offset_from_vsync = dcn10_get_vupdate_offset_from_vsync,<br>
> + .calc_vupdate_position = dcn10_calc_vupdate_position,<br>
> .apply_idle_power_optimizations = dcn30_apply_idle_power_optimizations,<br>
> .set_backlight_level = dcn21_set_backlight_level,<br>
> .set_abm_immediate_disable = dcn21_set_abm_immediate_disable,<br>
> + .set_pipe = dcn21_set_pipe,<br>
> };<br>
> <br>
> static const struct hwseq_private_funcs dcn30_private_funcs = {<br>
> <br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>