<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <p style="font-family:Arial;font-size:10pt;color:#0078D7;margin:15pt;" align="Left"> [AMD Official Use Only - Internal Distribution Only]<br> </p> <br> <div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Reviewed-by: Kevin Wang <kevin1.wang@amd.com></div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Best Regards,</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Kevin</div> <div id="appendonsend"></div> <div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)"> <br> </div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Huang Rui <ray.huang@amd.com><br> <b>Sent:</b> Tuesday, October 13, 2020 7:45 PM<br> <b>To:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br> <b>Cc:</b> Huang, Ray <Ray.Huang@amd.com><br> <b>Subject:</b> [PATCH] drm/amdgpu: fix the issue that apu has no smu firmware binary</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt"> <div class="PlainText">The driver needn't load smu binary on APU platforms.<br> <br> Signed-off-by: Huang Rui <ray.huang@amd.com><br> ---<br> drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c<br> index 9d31f9339e02..042ad5e4292b 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c<br> @@ -7049,7 +7049,7 @@ static int gfx_v10_0_hw_init(void *handle)<br> * loaded firstly, so in direct type, it has to load smc ucode<br> * here before rlc.<br> */<br> - if (adev->smu.ppt_funcs != NULL) {<br> + if (adev->smu.ppt_funcs != NULL && !(adev->flags & AMD_IS_APU)) {<br> r = smu_load_microcode(&adev->smu);<br> if (r)<br> return r;<br> -- <br> 2.25.1<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7CKevin1.Wang%40amd.com%7C2bcdef4a06454092df7708d86f6d7f8b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637381863385762892&sdata=PK8E49RMQ3myvBXdV7pE7rxQTRd9p7SVGJOhcXUFNHE%3D&reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7CKevin1.Wang%40amd.com%7C2bcdef4a06454092df7708d86f6d7f8b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637381863385762892&sdata=PK8E49RMQ3myvBXdV7pE7rxQTRd9p7SVGJOhcXUFNHE%3D&reserved=0</a><br> </div> </span></font></div> </div> </body> </html>