<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0078D7;margin:15pt;" align="Left">
[AMD Official Use Only - Internal Distribution Only]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks very much Alex!<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Alex Deucher <alexdeucher@gmail.com><br>
<b>Sent:</b> Thursday, October 22, 2020 11:45<br>
<b>To:</b> Yin, Tianci (Rico) <Tianci.Yin@amd.com><br>
<b>Cc:</b> amd-gfx list <amd-gfx@lists.freedesktop.org>; Long, Gang <Gang.Long@amd.com>; Chen, Guchun <Guchun.Chen@amd.com>; Xu, Feifei <Feifei.Xu@amd.com>; Tuikov, Luben <Luben.Tuikov@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Cui, Flora <Flora.Cui@amd.com>;
 Zhang, Hawking <Hawking.Zhang@amd.com><br>
<b>Subject:</b> Re: [PATCH 2/2] drm/amdgpu: disable DCN and VCN for navi10 blockchain SKU(v3)</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On Wed, Oct 21, 2020 at 11:43 PM Tianci Yin <tianci.yin@amd.com> wrote:<br>
><br>
> From: "Tianci.Yin" <tianci.yin@amd.com><br>
><br>
> The blockchain SKU has no display and video support, remove them.<br>
><br>
> Change-Id: I419cfae8b00125f3bff18c0a8cd92f3266d5f04a<br>
> Signed-off-by: Tianci.Yin <tianci.yin@amd.com><br>
> ---<br>
>  drivers/gpu/drm/amd/amdgpu/nv.c | 14 ++++++++++++--<br>
>  1 file changed, 12 insertions(+), 2 deletions(-)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c<br>
> index ce787489aaeb..26702c85caf8 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/nv.c<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/nv.c<br>
> @@ -497,6 +497,14 @@ void nv_set_virt_ops(struct amdgpu_device *adev)<br>
>         adev->virt.ops = &xgpu_nv_virt_ops;<br>
>  }<br>
><br>
> +bool nv_is_blockchain_sku(struct pci_dev *pdev)<br>
<br>
This can be static.  With that fixed, the series is:<br>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com><br>
<br>
> +{<br>
> +       if (pdev->device == 0x731E &&<br>
> +           (pdev->revision == 0xC6 || pdev->revision == 0xC7))<br>
> +               return true;<br>
> +       return false;<br>
> +}<br>
> +<br>
>  int nv_set_ip_blocks(struct amdgpu_device *adev)<br>
>  {<br>
>         int r;<br>
> @@ -530,7 +538,8 @@ int nv_set_ip_blocks(struct amdgpu_device *adev)<br>
>                 if (adev->enable_virtual_display || amdgpu_sriov_vf(adev))<br>
>                         amdgpu_device_ip_block_add(adev, &dce_virtual_ip_block);<br>
>  #if defined(CONFIG_DRM_AMD_DC)<br>
> -               else if (amdgpu_device_has_dc_support(adev))<br>
> +               else if (amdgpu_device_has_dc_support(adev) &&<br>
> +                        !nv_is_blockchain_sku(adev->pdev))<br>
>                         amdgpu_device_ip_block_add(adev, &dm_ip_block);<br>
>  #endif<br>
>                 amdgpu_device_ip_block_add(adev, &gfx_v10_0_ip_block);<br>
> @@ -538,7 +547,8 @@ int nv_set_ip_blocks(struct amdgpu_device *adev)<br>
>                 if (adev->firmware.load_type == AMDGPU_FW_LOAD_DIRECT &&<br>
>                     !amdgpu_sriov_vf(adev))<br>
>                         amdgpu_device_ip_block_add(adev, &smu_v11_0_ip_block);<br>
> -               amdgpu_device_ip_block_add(adev, &vcn_v2_0_ip_block);<br>
> +               if (!nv_is_blockchain_sku(adev->pdev))<br>
> +                       amdgpu_device_ip_block_add(adev, &vcn_v2_0_ip_block);<br>
>                 amdgpu_device_ip_block_add(adev, &jpeg_v2_0_ip_block);<br>
>                 if (adev->enable_mes)<br>
>                         amdgpu_device_ip_block_add(adev, &mes_v10_1_ip_block);<br>
> --<br>
> 2.17.1<br>
><br>
> _______________________________________________<br>
> amd-gfx mailing list<br>
> amd-gfx@lists.freedesktop.org<br>
> <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=04%7C01%7Ctianci.yin%40amd.com%7C69a8d879c10a4a95df8408d8763d00da%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637389351668689049%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=BoBEgmT7npcabo5NhzjKxqeyErXx3CKFzK1HNHa8LWU%3D&amp;reserved=0">
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=04%7C01%7Ctianci.yin%40amd.com%7C69a8d879c10a4a95df8408d8763d00da%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637389351668689049%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=BoBEgmT7npcabo5NhzjKxqeyErXx3CKFzK1HNHa8LWU%3D&amp;reserved=0</a><br>
</div>
</span></font></div>
</div>
</body>
</html>