<html><head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body text="#000000" bgcolor="#FFFFFF"> Hi, back to this after a long context switch for some higher priority stuff. So here I was able eventually to drop all this code and this change here <a class="moz-txt-link-freetext" href="https://cgit.freedesktop.org/~agrodzov/linux/commit/?h=amd-staging-drm-next-device-unplug&id=61852c8a59b4dd89d637693552c73175b9f2ccd6">https://cgit.freedesktop.org/~agrodzov/linux/commit/?h=amd-staging-drm-next-device-unplug&id=61852c8a59b4dd89d637693552c73175b9f2ccd6</a> was enough for me. Seems like while device_remove_file can handle the use case where the file and the parent directory already gone, sysfs_remove_group goes down in flames in that case due to <span style="color: rgb(51, 51, 51); font-family: monospace; font-size: 13.3333px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration-style: initial; text-decoration-color: initial; display: inline !important; float: none;">kobj->sd being unset on device removal. Andrey <div class="moz-cite-prefix">On 6/24/20 2:11 AM, Greg KH wrote: </div> <blockquote type="cite" cite="mid:20200624061153.GA933050@kroah.com"> <blockquote type="cite" style="color: #000000;"> <blockquote type="cite" style="color: #000000;"> <pre class="moz-quote-pre" wrap="">But why are things being removed twice? </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> Not sure I understand what removed twice ? I remove only once per sysfs attribute. </pre> </blockquote> <pre class="moz-quote-pre" wrap="">This code path shows that the kernel is trying to remove a file that is not present, so someone removed it already... thanks, gre k-h </pre> </blockquote> </body> </html>