<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:11pt;color:#0078D7;margin:5pt;" align="Left">
[AMD Official Use Only - Internal Distribution Only]<br>
</p>
<br>
<div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Koenig, Christian <Christian.Koenig@amd.com><br>
<b>Sent:</b> Monday, December 7, 2020 4:23 PM<br>
<b>To:</b> Wang, Kevin(Yang) <Kevin1.Wang@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Subject:</b> Re: [PATCH] drm/amdgpu: change trace event parameter name from 'driect' to 'immediate'</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">Am 07.12.20 um 07:56 schrieb Kevin Wang:<br>
> s/direct/immediate/g<br>
><br>
> amdgpu vm has renamed parameter name from 'direct' to 'immedate'.<br>
> however, the trace event is not updated yet.<br>
><br>
> Signed-off-by: Kevin Wang <kevin1.wang@amd.com><br>
There is a small typo in the subject line "driect", apart from that the <br>
patch is Reviewed-by: Christian König <christian.koenig@amd.com>.<br>
<br>
Thanks for removing one item from my TODO list :)<br>
<br>
Regards,<br>
Christian.</div>
<div class="PlainText"><br>
</div>
<div class="PlainText">[kevin]:</div>
<div class="PlainText">ok, thank you for reminding me.</div>
<div class="PlainText"><br>
</div>
<div class="PlainText">> ---<br>
> drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 24 +++++++++++------------<br>
> 1 file changed, 12 insertions(+), 12 deletions(-)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h<br>
> index ee9480d14cbc..324d5e3f3579 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h<br>
> @@ -366,15 +366,15 @@ TRACE_EVENT(amdgpu_vm_update_ptes,<br>
> <br>
> TRACE_EVENT(amdgpu_vm_set_ptes,<br>
> TP_PROTO(uint64_t pe, uint64_t addr, unsigned count,<br>
> - uint32_t incr, uint64_t flags, bool direct),<br>
> - TP_ARGS(pe, addr, count, incr, flags, direct),<br>
> + uint32_t incr, uint64_t flags, bool immediate),<br>
> + TP_ARGS(pe, addr, count, incr, flags, immediate),<br>
> TP_STRUCT__entry(<br>
> __field(u64, pe)<br>
> __field(u64, addr)<br>
> __field(u32, count)<br>
> __field(u32, incr)<br>
> __field(u64, flags)<br>
> - __field(bool, direct)<br>
> + __field(bool, immediate)<br>
> ),<br>
> <br>
> TP_fast_assign(<br>
> @@ -383,32 +383,32 @@ TRACE_EVENT(amdgpu_vm_set_ptes,<br>
> __entry->count = count;<br>
> __entry->incr = incr;<br>
> __entry->flags = flags;<br>
> - __entry->direct = direct;<br>
> + __entry->immediate = immediate;<br>
> ),<br>
> TP_printk("pe=%010Lx, addr=%010Lx, incr=%u, flags=%llx, count=%u, "<br>
> - "direct=%d", __entry->pe, __entry->addr, __entry->incr,<br>
> - __entry->flags, __entry->count, __entry->direct)<br>
> + "immediate=%d", __entry->pe, __entry->addr, __entry->incr,<br>
> + __entry->flags, __entry->count, __entry->immediate)<br>
> );<br>
> <br>
> TRACE_EVENT(amdgpu_vm_copy_ptes,<br>
> - TP_PROTO(uint64_t pe, uint64_t src, unsigned count, bool direct),<br>
> - TP_ARGS(pe, src, count, direct),<br>
> + TP_PROTO(uint64_t pe, uint64_t src, unsigned count, bool immediate),<br>
> + TP_ARGS(pe, src, count, immediate),<br>
> TP_STRUCT__entry(<br>
> __field(u64, pe)<br>
> __field(u64, src)<br>
> __field(u32, count)<br>
> - __field(bool, direct)<br>
> + __field(bool, immediate)<br>
> ),<br>
> <br>
> TP_fast_assign(<br>
> __entry->pe = pe;<br>
> __entry->src = src;<br>
> __entry->count = count;<br>
> - __entry->direct = direct;<br>
> + __entry->immediate = immediate;<br>
> ),<br>
> - TP_printk("pe=%010Lx, src=%010Lx, count=%u, direct=%d",<br>
> + TP_printk("pe=%010Lx, src=%010Lx, count=%u, immediate=%d",<br>
> __entry->pe, __entry->src, __entry->count,<br>
> - __entry->direct)<br>
> + __entry->immediate)<br>
> );<br>
> <br>
> TRACE_EVENT(amdgpu_vm_flush,<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>