<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <p style="font-family:Arial;font-size:11pt;color:#0078D7;margin:5pt;" align="Left"> [AMD Official Use Only - Internal Distribution Only]<br> </p> <br> <div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Reviewed-by: Alex Deucher <alexander.deucher@amd.com><br> </div> <div id="appendonsend"></div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Rodrigo Siqueira <Rodrigo.Siqueira@amd.com><br> <b>Sent:</b> Monday, December 7, 2020 5:55 PM<br> <b>To:</b> Wentland, Harry <Harry.Wentland@amd.com>; Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com>; Pillai, Aurabindo <Aurabindo.Pillai@amd.com><br> <b>Cc:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br> <b>Subject:</b> [PATCH] drm/amd/display: Drop unnecessary function call</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">After refactor our amdgpu_dm_atomic_commit, this function only invoke<br> drm_atomic_helper_commit. For this reason, this commit drops<br> amdgpu_dm_atomic_commit and add drm_atomic_helper_commit directly in the<br> atomic_commit hook.<br> <br> Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com><br> ---<br> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 16 +---------------<br> 1 file changed, 1 insertion(+), 15 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c<br> index a37948f2e596..c89066b1c471 100644<br> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c<br> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c<br> @@ -2212,7 +2212,7 @@ static const struct drm_mode_config_funcs amdgpu_dm_mode_funcs = {<br> .get_format_info = amd_get_format_info,<br> .output_poll_changed = drm_fb_helper_output_poll_changed,<br> .atomic_check = amdgpu_dm_atomic_check,<br> - .atomic_commit = amdgpu_dm_atomic_commit,<br> + .atomic_commit = drm_atomic_helper_commit,<br> };<br> <br> static struct drm_mode_config_helper_funcs amdgpu_dm_mode_config_helperfuncs = {<br> @@ -8158,20 +8158,6 @@ static void amdgpu_dm_crtc_copy_transient_flags(struct drm_crtc_state *crtc_stat<br> stream_state->mode_changed = drm_atomic_crtc_needs_modeset(crtc_state);<br> }<br> <br> -static int amdgpu_dm_atomic_commit(struct drm_device *dev,<br> - struct drm_atomic_state *state,<br> - bool nonblock)<br> -{<br> - /*<br> - * Add check here for SoC's that support hardware cursor plane, to<br> - * unset legacy_cursor_update<br> - */<br> -<br> - return drm_atomic_helper_commit(dev, state, nonblock);<br> -<br> - /*TODO Handle EINTR, reenable IRQ*/<br> -}<br> -<br> /**<br> * amdgpu_dm_atomic_commit_tail() - AMDgpu DM's commit tail implementation.<br> * @state: The atomic state to commit<br> -- <br> 2.29.2<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Calexander.deucher%40amd.com%7Cbbf5c6ea7e2f4e32d50d08d89b033b75%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637429785490973923%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=V5Wg2XgI9zUCTH0OhTSr3Oky8PTvy8XYIa3eAhVDnlk%3D&reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Calexander.deucher%40amd.com%7Cbbf5c6ea7e2f4e32d50d08d89b033b75%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637429785490973923%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=V5Wg2XgI9zUCTH0OhTSr3Oky8PTvy8XYIa3eAhVDnlk%3D&reserved=0</a><br> </div> </span></font></div> </div> </body> </html>