<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> <p class="msipheader251902e5" style="margin:0in"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#317100">[AMD Public Use]</span><o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Thanks for your reminder, I’ll add another patch to enable gpu recovery.<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Tao<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b>From:</b> Deucher, Alexander <Alexander.Deucher@amd.com> <br> <b>Sent:</b> Tuesday, December 15, 2020 10:27 PM<br> <b>To:</b> Chen, Jiansong (Simon) <Jiansong.Chen@amd.com>; Zhou1, Tao <Tao.Zhou1@amd.com>; Gui, Jack <Jack.Gui@amd.com>; Zhang, Hawking <Hawking.Zhang@amd.com>; amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH] drm/amdgpu: set mode1 reset as default for dimgrey_cavefish<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <p style="margin:5.0pt"><span style="font-family:"Arial",sans-serif;color:#0078D7">[AMD Official Use Only - Internal Distribution Only]<o:p></o:p></span></p> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">You will also need to add the asic_type to amdgpu_device_should_recover_gpu() if you the driver to actually use GPU reset when it encounters a hang.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">Alex<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> <p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of Chen, Jiansong (Simon) <<a href="mailto:Jiansong.Chen@amd.com">Jiansong.Chen@amd.com</a>><br> <b>Sent:</b> Tuesday, December 15, 2020 5:33 AM<br> <b>To:</b> Zhou1, Tao <<a href="mailto:Tao.Zhou1@amd.com">Tao.Zhou1@amd.com</a>>; Gui, Jack <<a href="mailto:Jack.Gui@amd.com">Jack.Gui@amd.com</a>>; Zhang, Hawking <<a href="mailto:Hawking.Zhang@amd.com">Hawking.Zhang@amd.com</a>>; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>><br> <b>Subject:</b> RE: [PATCH] drm/amdgpu: set mode1 reset as default for dimgrey_cavefish</span> <o:p></o:p></p> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal">[AMD Official Use Only - Internal Distribution Only]<br> <br> [AMD Official Use Only - Internal Distribution Only]<br> <br> Reviewed-by: Jiansong Chen <<a href="mailto:Jiansong.Chen@amd.com">Jiansong.Chen@amd.com</a>><br> <br> -----Original Message-----<br> From: Zhou1, Tao <<a href="mailto:Tao.Zhou1@amd.com">Tao.Zhou1@amd.com</a>><br> Sent: Tuesday, December 15, 2020 6:23 PM<br> To: Chen, Jiansong (Simon) <<a href="mailto:Jiansong.Chen@amd.com">Jiansong.Chen@amd.com</a>>; Gui, Jack <<a href="mailto:Jack.Gui@amd.com">Jack.Gui@amd.com</a>>; Zhang, Hawking <<a href="mailto:Hawking.Zhang@amd.com">Hawking.Zhang@amd.com</a>>; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> Cc: Zhou1, Tao <<a href="mailto:Tao.Zhou1@amd.com">Tao.Zhou1@amd.com</a>><br> Subject: [PATCH] drm/amdgpu: set mode1 reset as default for dimgrey_cavefish<br> <br> Use mode1 reset for dimgrey_cavefish by default.<br> <br> Signed-off-by: Tao Zhou <<a href="mailto:tao.zhou1@amd.com">tao.zhou1@amd.com</a>><br> ---<br> drivers/gpu/drm/amd/amdgpu/nv.c | 1 +<br> 1 file changed, 1 insertion(+)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c index ac02dd707c44..6bee3677394a 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/nv.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/nv.c<br> @@ -362,6 +362,7 @@ nv_asic_reset_method(struct amdgpu_device *adev)<br> switch (adev->asic_type) {<br> case CHIP_SIENNA_CICHLID:<br> case CHIP_NAVY_FLOUNDER:<br> +case CHIP_DIMGREY_CAVEFISH:<br> return AMD_RESET_METHOD_MODE1;<br> default:<br> if (smu_baco_is_support(smu))<br> --<br> 2.17.1<br> <br> _______________________________________________<br> amd-gfx mailing list<br> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Calexander.deucher%40amd.com%7Cb3da8467a171425a6cf208d8a0e4d612%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637436252010819826%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=fr8uXVyoVz5WlYtYPRbKm1%2BN0ROBWuLuqPOuL3%2BHC0E%3D&reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Calexander.deucher%40amd.com%7Cb3da8467a171425a6cf208d8a0e4d612%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637436252010819826%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=fr8uXVyoVz5WlYtYPRbKm1%2BN0ROBWuLuqPOuL3%2BHC0E%3D&reserved=0</a><o:p></o:p></p> </div> </div> </div> </div> </div> </body> </html>