<html><head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body> <div class="moz-cite-prefix">On 2021-01-18 6:28 p.m., Felix Kuehling wrote: </div> <blockquote type="cite" cite="mid:20210118232824.32649-1-Felix.Kuehling@amd.com"> <pre class="moz-quote-pre" wrap="">ROCm user mode depends on userptr support. Without it, KFD is basically useless. Make sure HSA_AMD selects the same options as DRM_AMDGPU_USERPTR to avoid broken configurations where userptr gets enabled but its dependencies are disabled. Signed-off-by: Felix Kuehling <a class="moz-txt-link-rfc2396E" href="mailto:Felix.Kuehling@amd.com"><Felix.Kuehling@amd.com></a> --- drivers/gpu/drm/amd/amdkfd/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig index e8fb10c41f16..f02c938f75da 100644 --- a/drivers/gpu/drm/amd/amdkfd/Kconfig +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig @@ -7,6 +7,8 @@ config HSA_AMD bool "HSA kernel driver for AMD GPU devices" depends on DRM_AMDGPU && (X86_64 || ARM64 || PPC64) imply AMD_IOMMU_V2 if X86_64 + select HMM_MIRROR select MMU_NOTIFIER + select DRM_AMDGPU_USERPTR</pre> </blockquote> amd/amdgpu/Kconfig select HMM_MIRROR and MMU_NOTIFIER if DRM_AMDGPU_USERPTR is enabled, I guess select DRM_AMDGPU_USERPTR here is enough, HMM_MIRROR and MMU_NOTIFIER is redundant. Philip <blockquote type="cite" cite="mid:20210118232824.32649-1-Felix.Kuehling@amd.com"> <pre class="moz-quote-pre" wrap=""> help Enable this if you want to use HSA features on AMD GPU devices. </pre> </blockquote> </body> </html>